From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758233AbYDUVX0 (ORCPT ); Mon, 21 Apr 2008 17:23:26 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753504AbYDUVWW (ORCPT ); Mon, 21 Apr 2008 17:22:22 -0400 Received: from hs-out-0708.google.com ([64.233.178.249]:8102 "EHLO hs-out-0708.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753538AbYDUVWU (ORCPT ); Mon, 21 Apr 2008 17:22:20 -0400 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references:x-google-sender-auth; b=jFdW/hgFrMUNfoEEXdCEBHqdgWq2cs9hy2VI55KFjeWYf8RkNdDj2W1QzrX0WVft4U141j70XU1ZCibfby7s8n6VbMvYCTQy/uUA0tcCnqlnmvuAH0hKzwV2eBapLXf8/Yrw/Ch31mNjFaUUp5/q2p77mmaPtLR/IJqZjZUSmR4= Message-ID: <76366b180804211422k33057607p586b5deed7849c07@mail.gmail.com> Date: Mon, 21 Apr 2008 17:22:15 -0400 From: "Andrew Paprocki" To: "Francois Romieu" Subject: Re: kernel BUG at /usr/src/linux-2.6.25/kernel/workqueue.c:224! (r8169?) Cc: LKML , netdev@vger.kernel.org In-Reply-To: <20080421203458.GA2931@electric-eye.fr.zoreil.com> MIME-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Content-Disposition: inline References: <76366b180804201548g309ae6cci286ed6552f3cb71e@mail.gmail.com> <76366b180804202016l19ac362cyb814781449f81e9a@mail.gmail.com> <20080421203458.GA2931@electric-eye.fr.zoreil.com> X-Google-Sender-Auth: 2bc975182b1f217b Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Francois, On this kernel CONFIG_R8169_NAPI is disabled, so that code would not even be compiled in. Is NAPI stable enough that I should be using it now? (It is still marked experimental) Thanks, -Andrew On Mon, Apr 21, 2008 at 4:34 PM, Francois Romieu wrote: > Andrew Paprocki : > > > I just received a similar bug on workqueue.c:223 while I was not doing > > anything with the card. These bugs seem to have increased with > > frequency when running under 2.6.25. It used to take me some time to > > cause a problem to appear under 2.6.24, but under 2.6.25 they appear > > very readily. I was actually not touching the machine at all when this > > appeared on the console: > > Does the patch below decrease the frequency of the bug ? > > diff --git a/drivers/net/r8169.c b/drivers/net/r8169.c > index 3acfeea..6ee9db1 100644 > --- a/drivers/net/r8169.c > +++ b/drivers/net/r8169.c > @@ -2398,8 +2398,6 @@ static void rtl8169_wait_for_quiescence(struct net_device *dev) > rtl8169_irq_mask_and_ack(ioaddr); > > #ifdef CONFIG_R8169_NAPI > - tp->intr_mask = 0xffff; > - RTL_W16(IntrMask, tp->intr_event); > napi_enable(&tp->napi); > #endif > } > > -- > Ueimor > >