Re: [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability

[Johannes Berg <johannes@sipsolutions.net>]

> + * @NL80211_ATTR_SMD_SUPPORT: Flag attribute to indicate SMD support. Used with
> + *	multiple commands to indicate appropriate SMD support (refer DOC).

This (with the wiphy flag) is the wrong way to do this, we have extended
flags that don't need the double enum value and pass through to
userspace directly.

But also, this does absolutely _nothing_, the only thing you do with it
is pass a completely ignored NL80211_ATTR_SMD_SUPPORT to START_AP ...
it's not even passed to the driver.

I suspect there might be a case for having WIPHY_FLAG_SUPPORTS_SMD and
gating the CMD() on it or so, like I did for the client side?

+                       if (rdev->wiphy.flags & WIPHY_FLAG_SMD_TRANSITION_CLIENT)
+                               CMD(execute_st, EXECUTE_SMD_TRANSITION);

but this seems rather confusingly pared down from what you had before.

johannes

PS: I'll probably not get through the entire patchset today since I have
to go soon, so best wait until tomorrow or so.