mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Yunsheng Lin <linyunsheng@huawei.com>
To: Mina Almasry <almasrymina@google.com>, <netdev@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-kselftest@vger.kernel.org>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Simon Horman <horms@kernel.org>,
	Jesper Dangaard Brouer <hawk@kernel.org>,
	Ilias Apalodimas <ilias.apalodimas@linaro.org>,
	Shuah Khan <shuah@kernel.org>
Subject: Re: [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc_netmem
Date: Fri, 1 Nov 2024 19:14:13 +0800	[thread overview]
Message-ID: <763d9630-3064-4d88-8e99-549a07328ec8@huawei.com> (raw)
In-Reply-To: <20241029204541.1301203-3-almasrymina@google.com>

On 2024/10/30 4:45, Mina Almasry wrote:
> Create page_pool_alloc_netmem to be the mirror of page_pool_alloc.
> 
> This enables drivers that want currently use page_pool_alloc to
> transition to netmem by converting the call sites to
> page_pool_alloc_netmem.

For old API, page_pool_alloc_pages() always return a whole page, and
page_pool_alloc() returns a whole page or a page fragment based on the
requested size.

For new netmem API, page_pool_alloc_netmems() always return a whole
netmem, and page_pool_alloc_netmem() returns a whole netmem or a netmem
fragment based on the requested size.

Isn't it a little odd that old and new are not following the same
pattern?

  reply	other threads:[~2024-11-01 11:14 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-29 20:45 [PATCH net-next v1 0/7] devmem TCP fixes Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 1/7] net: page_pool: rename page_pool_alloc_netmem to *_netmems Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 2/7] net: page_pool: create page_pool_alloc_netmem Mina Almasry
2024-11-01 11:14   ` Yunsheng Lin [this message]
2024-11-01 13:10     ` Mina Almasry
2024-11-03 14:35       ` Yunsheng Lin
2024-11-07 21:08         ` Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 3/7] page_pool: Set `dma_sync` to false for devmem memory provider Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 4/7] page_pool: disable sync for cpu for dmabuf " Mina Almasry
2024-10-29 20:45 ` [PATCH net-next v1 5/7] netmem: add netmem_prefetch Mina Almasry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=763d9630-3064-4d88-8e99-549a07328ec8@huawei.com \
    --to=linyunsheng@huawei.com \
    --cc=almasrymina@google.com \
    --cc=davem@davemloft.net \
    --cc=edumazet@google.com \
    --cc=hawk@kernel.org \
    --cc=horms@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=shuah@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®