From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751719AbdJYHbx (ORCPT ); Wed, 25 Oct 2017 03:31:53 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:55007 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751407AbdJYHbv (ORCPT ); Wed, 25 Oct 2017 03:31:51 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171025073148euoutp013b373a4881d004129cf156a1a179325e~wv8CCf2ew2895328953euoutp017 X-AuditID: cbfec7f5-f79d06d0000031c7-b1-59f03de30546 Subject: Re: [RFC PATCH v2 1/3] regulator: bindings: Add properties for coupled regulators To: Rob Herring Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Mark Brown , Liam Girdwood , Mark Rutland , Marek Szyprowski , Bartlomiej Zolnierkiewicz From: Maciej Purski Message-id: <76404da2-fe50-b124-0f18-e93e3cb14014@samsung.com> Date: Wed, 25 Oct 2017 09:31:45 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 MIME-version: 1.0 In-reply-to: <20171024185801.bq27wszp7socsxqx@rob-hp-laptop> Content-type: text/plain; charset="utf-8"; format="flowed" Content-language: en-US Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrEKsWRmVeSWpSXmKPExsWy7djPc7qPbT9EGhxYrW6xccZ6VoupD5+w Wcw/co7V4tuVDiaLy7vmsFmsPXKX3WLp9YtMFv/37GB34PBYM28No8fOWXfZPTat6mTz6Nuy itHj8ya5ANYoLpuU1JzMstQifbsErox7ne8ZCz7zV5x9OomxgfEvTxcjJ4eEgInE6tlz2CBs MYkL99YD2VwcQgJLGSWe7u1gh3A+M0qcaJ3NCNPxsOE1E0RiGaPE6s39YO1CAs8YJe7ckwGx hQViJM5fnM8MYosIKEr8bpvGCtLALDCBSWL2zDagBg4ONgEtiTXt8SA1vAJ2Eg/WLGIBsVkE VCVmdkxmBbFFBSIkLmz6yQRRIyjxY/I9sBpOARuJ/q9PwWqYBawknv1rhbLFJZpbb7JA2PIS m9e8ZQbZKyFwnU3i2PudzBAfuEhcmtXBCmELS7w6voUdwpaR6Ow4yARhV0tc/LoLGi41Eo23 N0DVWEt8nrSFGWIBn8SkbdOZQX6REOCV6GgTgijxkHjT2QI1xlGiuecqIySwmpkklh34yzaB UX4Wkn9mIflhFpIfZiH5YQEjyypGkdTS4tz01GJTveLE3OLSvHS95PzcTYzAlHP63/GvOxiX HrM6xCjAwajEwysw/X2kEGtiWXFl7iFGCQ5mJRFehVdAId6UxMqq1KL8+KLSnNTiQ4zSHCxK 4ry2UW2RQgLpiSWp2ampBalFMFkmDk6pBsbdjzxrG6L+KnDqfZH8xzktxf736+Zvv9dGtB6S aCxJPfjXQ9z+25wJz+5/2KoZd/na6Q3vlvLyNT3V/Ko8LTo9LKhl3g5mLr6/l02C1GSMPro/ /eH0gv/chXqVf+m6y0uDRVZNnZPMsU31suviZ0yJiWbrrXg/K8r4enUaPuafM/HyT+//6pZK LMUZiYZazEXFiQAjOFHQNQMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrOLMWRmVeSWpSXmKPExsVy+t/xa7qPbT9EGux9zmSxccZ6VoupD5+w Wcw/co7V4tuVDiaLy7vmsFmsPXKX3WLp9YtMFv/37GB34PBYM28No8fOWXfZPTat6mTz6Nuy itHj8ya5ANYoLpuU1JzMstQifbsErox7ne8ZCz7zV5x9OomxgfEvTxcjJ4eEgInEw4bXTBC2 mMSFe+vZQGwhgSWMEs1nUrsYuYDsZ4wSn059BSsSFoiRWD/5NzOILSKgKPG7bRorSBGzwCQm ifsPTjFCdDQzSfy9fRkow8HBJqAlsaY9HqSBV8BO4sGaRSwgNouAqsTMjslgJaICERIbNvJD lAhK/Jh8D6yEU8BGov/rU1YQm1nATOLLy8NQtrhEc+tNFghbXmLzmrfMExgFZyFpn4WkZRaS lllIWhYwsqxiFEktLc5Nzy021CtOzC0uzUvXS87P3cQIjI5tx35u3sF4aWPwIUYBDkYlHl6B 6e8jhVgTy4orcw8xSnAwK4nwKrwCCvGmJFZWpRblxxeV5qQWH2KU5mBREuft3bM6UkggPbEk NTs1tSC1CCbLxMEp1cBYXFPwVdUy1PjDjXOFFxxEnP2miYgUSKtd5ZPWFF4Q+uxFiqhbkFUc //dD3H3NqdMak6oZcks/ct4JE4qoNs5dEs9v7fjDknuNc8YK6R/ySlKFEfPm3GNa2i/755TX nX+l3jJrHRuYne/E1le/5U//vzax9fb0HIuCR5nRezinT7//p+OzghJLcUaioRZzUXEiAAFD ssKKAgAA X-CMS-MailID: 20171025073147eucas1p1662d8aec54c950385ac8110cd343bd45 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171018124727eucas1p255ccce41852d5585640f2d97153d2fa8 X-RootMTR: 20171018124727eucas1p255ccce41852d5585640f2d97153d2fa8 References: <1508330822-8039-1-git-send-email-m.purski@samsung.com> <1508330822-8039-2-git-send-email-m.purski@samsung.com> <20171024185801.bq27wszp7socsxqx@rob-hp-laptop> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/24/2017 08:58 PM, Rob Herring wrote: > On Wed, Oct 18, 2017 at 02:47:00PM +0200, Maciej Purski wrote: >> Some regulators require keeping their voltage spread below defined >> max_spread. >> >> Add properties to provide information on regulators' coupling. >> >> Signed-off-by: Maciej Purski >> --- >> Documentation/devicetree/bindings/regulator/regulator.txt | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/regulator/regulator.txt b/Documentation/devicetree/bindings/regulator/regulator.txt >> index 378f6dc..6769565 100644 >> --- a/Documentation/devicetree/bindings/regulator/regulator.txt >> +++ b/Documentation/devicetree/bindings/regulator/regulator.txt >> @@ -60,6 +60,10 @@ Optional properties: >> 0: Disable active discharge. >> 1: Enable active discharge. >> Absence of this property will leave configuration to default. >> +- regulator-coupled-with: Phandle to regulators with which the regulator >> + should be coupled. Allow up to 9 phandles. > > 9? Sounds like a driver detail and pretty arbitrary. > It's just a constant number that I defined as MAX_COUPLED, because in fact there isn't any use-case yet for even more than two regulators so MAX_COUPLED equal to 9 is a really high number. If you find it cleaner, I can make this value variable. > Is this linkage 2-way meaning 2 coupled regulators both have links to > the other one? If so, then what happens when you have a high number? If > not, how does one decide which regulator has this property? Yes, it is 2-way. When you have a high number, then each regulator should have phandles to every other. So, if you have 3 regulators coupled, then each one should have 2 phandles. > >> +- regulator-coupled-max-spread: Max spread between voltages of coupled regulators >> + in microvolts. >> >> Deprecated properties: >> - regulator-compatible: If a regulator chip contains multiple >> -- >> 2.7.4 >> > > >