From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 95B301B87C3 for ; Fri, 24 Jan 2025 10:00:44 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.48 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737712846; cv=none; b=t0dhwf233xJBwMnZPvSghI6ZGprf3MzHMFC7HHh0GMSjfu4V+Bg/ucqQ+6ZocVyAhGB01Jma/IZRJjco/loZ/eRjVNtQ21LqUZDigpJYLctqzBnoOAp0sKbBNboaMG3wTnkJmEv1NTE+mi2C6eDoxOa2GHWFnCrSYRI26Kv/4Lk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1737712846; c=relaxed/simple; bh=sFprJVFwJ2E7g7E3sEaLKEWRDzMN6Z2rx69KzoKoQTw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=bRQXskt/sA5M6IhMv1QcAB7/GiA+coBFjHwQs7rz2MvLn7skUtKEi+AjPtDe8oVdy+OC4eRw78wTxtx+2yXxBx5OO7NSoDCUTRVrS5gue3n/fdLNimRSTHNrcz5STkU8Vul9+0yTdGkMSsXvuWjG5j9UdVfP/aJRAY5ZkvIrltQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com; spf=pass smtp.mailfrom=bytedance.com; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b=Gasn0qMA; arc=none smtp.client-ip=209.85.216.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=bytedance.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bytedance.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bytedance.com header.i=@bytedance.com header.b="Gasn0qMA" Received: by mail-pj1-f48.google.com with SMTP id 98e67ed59e1d1-2ef05d0ef18so451008a91.0 for ; Fri, 24 Jan 2025 02:00:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1737712844; x=1738317644; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=BmTxH03KXDQTDv/Uw7GBBM8E4pylSL3aSkfPVMzEuWQ=; b=Gasn0qMAqg7q9uMweLS6GNtSQWNHJSGBATclZoe5eiW7YafUqZHthM8V7O9VUXzkvl d6UZ49bq9cCT5MDx2qJHevfRNKLHTJIfRqPfol2QyfmXwTCZNdGfLpPhVUQNqOkJImjx aNXX+JR1iEzXOVcbRjrURLu5AY6S05qQbSt4E9jzZ2itJSeuE7W/sTRIIsJJ3yxeNQmk WYno/ey6UtlZbOJ03UMcaTvjKtDByEoUDuSs8IqALvvNOj7xNYcTQx0M1viaIPc8trGg WWMXeUrm8avKKTMN84ieCnDATmWQb3zZsPyHSaZbYkWMeBTWyyLlKvliCe3BJk2c1Ox/ aczQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1737712844; x=1738317644; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BmTxH03KXDQTDv/Uw7GBBM8E4pylSL3aSkfPVMzEuWQ=; b=Tl7EvMlJezUt1DDHPI09TSANK8s3+wU/OY4cOMMn7AZ8nWnOcgK9NfF14+uXaSJ87d 1UsYRqC85LTkOUKHjgxSaNulC+OjnmWqgu4HHw5zpyy9DnzNySBMUX3VygYo7FvO8eLi JMZT1ZlssvV6FJefOjYGWiSVjV3Ys0/cP6EYLH+pisOdaWnMj3F36GS8h0LAsk3kYmae 5H5X+R51T+brfC0fHS0VmlJ7S5e9VIgfaMivUj7wHkPJSWOZAkyi+b6JK4jfx3m9j2iI cKT11NgqNKEVbCI5+9rclSMQEhQpKeT0zG/LubrMG8m3UbdoHx3+JSZ5LKlFzVp8PJbS 49dQ== X-Forwarded-Encrypted: i=1; AJvYcCX5Bq7vKfp/P+zVaOPw5qM73TGRQWQXU21yjCGMqTIOYCV6tU9PUjtgULdKiqcvQ8AHoaUfRngpmb1hMiU=@vger.kernel.org X-Gm-Message-State: AOJu0YyPrR07HC8NpW8i2dhKyWY0fnzaHom34za4wYc2Yl8lJ7xrQI5p dEmlWgNEIF6YJ+ViBl600iK4HXHtt3TLJg97sGc5h/daQtC3jEbW+bCKKwKNvo4= X-Gm-Gg: ASbGncuT+mnRoERTeCKeWLgTasG6XuaDIEVJgwn5xHrf3sU/zK5XjC1gM1oZwadizRP YfzlgdvmxQzdp7UbGhZeznlC/orSdtmkeCMD8k8bNsaH8Zs/v1iExSSaFWoHAozfnswWe5KrRY/ VJNR1cRhqiPW5Aalx1F6wAHOCRdyOjZKsnfGv0h77IxwKAJeVID6lggUP/AlqZt1IWs3o3WjzvG 6oxOP/7xRew3TLGFYhiZkEpR18Ch4yYm5GGeqi/PdMnGVlPgik0M7CAya+qysr7IrCdokt/mTo5 cB8jF3WiGJCJUIG1ZYEjhHhayCR51A== X-Google-Smtp-Source: AGHT+IElO9gB3UAtHo+GuhS7uM8VXUkiIauC0sqTubx0f3SOShH1kUjljV5ZgDcKKMWCosxHHkPDQQ== X-Received: by 2002:a05:6a00:21c7:b0:71e:4bda:71ec with SMTP id d2e1a72fcca58-72dafb9b2c7mr14455055b3a.4.1737712843813; Fri, 24 Jan 2025 02:00:43 -0800 (PST) Received: from [10.254.144.106] ([139.177.225.251]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-72f8a77c969sm1428288b3a.150.2025.01.24.02.00.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 24 Jan 2025 02:00:43 -0800 (PST) Message-ID: <764096dd-4d2c-4934-9c07-500a476bb140@bytedance.com> Date: Fri, 24 Jan 2025 18:00:34 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 2/3] cgroup/rstat: Cleanup cpu.stat once for all Content-Language: en-US To: =?UTF-8?Q?Michal_Koutn=C3=BD?= Cc: Tejun Heo , Johannes Weiner , Jonathan Corbet , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , Andrew Morton , Bitao Hu , Thomas Gleixner , Yury Norov , Chen Ridong , "open list:CONTROL GROUP (CGROUP)" , "open list:DOCUMENTATION" , open list References: <20250123174713.25570-1-wuyun.abel@bytedance.com> <20250123174713.25570-3-wuyun.abel@bytedance.com> <2fenjyawa46abfrpcebluaoi6dd4z5v2y7pp7jyuu2oblmfmhk@reaaehe6pkzn> From: Abel Wu In-Reply-To: <2fenjyawa46abfrpcebluaoi6dd4z5v2y7pp7jyuu2oblmfmhk@reaaehe6pkzn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 1/24/25 5:22 PM, Michal Koutný Wrote: > On Fri, Jan 24, 2025 at 01:47:02AM +0800, Abel Wu wrote: >> -static void cgroup_force_idle_show(struct seq_file *seq, struct cgroup_base_stat *bstat) >> +static void __append_bstat(struct seq_file *seq, struct cgroup_base_stat *bstat, >> + struct bstat_entry *entry) > > Not sure if starting with double underscore is needed when the helper is > `static`. Also something like s/append/show/ -> cgroup_bstat_entry_show. Yeah, "cgroup_bstat_entry_show" looks better! Will fix. Thanks, Abel