From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4AC0D30BBBB for ; Tue, 28 Oct 2025 10:58:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761649099; cv=none; b=HthdqFN5P+2NlSeJLXCtnU5oLzxXjxeBKJHvKTsXA73NNk5Xa2TH6sSlAkQJnICCG72eBO4m/fvHugfIcKV4O/PXKVQTo0iicY/KfWapYasUpLMLxaYeoJpDCD6jlVb+R9DEXMVr5OAALWzpqT3iusdgSZv4uuLgPoT0rlTBOy8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761649099; c=relaxed/simple; bh=vqremv0t2yHOOQI/+Hfhb2D20oc4q1/kuqwTB3jLX4E=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=j0HdnsqsKL+erARqXFuOV1Pgfnqsgg56V9KUj32UKtiaV8GFSCuvF4g7WFoZHdAa8InAWsNAW0QLwcZXCwqOUbDWjs+XYhvhWrnBcpCvwHBJRdhgw4K0bVBf3qF60dyCesR/oDLvU8CQZ6wLV8LBLuFehwhtBhONR7/XdmviIYg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=VbQud6Pf; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="VbQud6Pf" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 59S7OCGs3813156 for ; Tue, 28 Oct 2025 10:58:17 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= BctJ7Ge/xFD3/rRPCMnaqZXGXFAhHKqB0rU31331hjo=; b=VbQud6PfI2L7XENN Zukjk+GBpCddPcK84H5T6TKNuwLxdcxmJiYHXIB2mZV5vlGtI/7yR9il7CgCvXn/ yoB37di3Jmscgd9GwG6tFbqnvyFoG0EYkTgg/6855jiyU5gZWA+SNCzJUSEInSRY ltwrWTlsrGjFfC0lCfdCoXxGqBtzAxzODEab284lBJE4VAUcrx6WPOs7y35mZJ5o BngoLd3lvZu/30vx2mCq1EpkhphPGPonYcFLAawJ/JTCyLAYQdrHhClInoYm7unO bG59M11+K+w4j+E6aldOZGzJA2lc0Cjv6ZsI7JD82jMUJdLCMWqBos7J6jC88W72 Xyd5RQ== Received: from mail-pl1-f198.google.com (mail-pl1-f198.google.com [209.85.214.198]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4a2g2ft460-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 28 Oct 2025 10:58:17 +0000 (GMT) Received: by mail-pl1-f198.google.com with SMTP id d9443c01a7336-290c2d13a01so43295175ad.0 for ; Tue, 28 Oct 2025 03:58:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761649097; x=1762253897; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=BctJ7Ge/xFD3/rRPCMnaqZXGXFAhHKqB0rU31331hjo=; b=SDl2aebVBA3POjE1B5ZvQxxGbiarrZVkH74XGPpLpgW1Q8Zs5lkdNdxAhlIn4jM2Mx 37E9/Tj9vkQRU/tYwwXX2SW7RanYlxTNM7dFi84o/tXPKN7yZK6vaApGauECUms3ND+g pRrECBotBpH9cAHLjO3gy8Cm2oLslwG4ZFC9pMEnqCAAQvojmS0AJuOfr0ZJz0Hv93Ol meHm44X1omZ51bTGHhjx1T+1JJDRbWjYOWfERzyn0yRKhXY+7V1WA9Aogh/JGGh1uXfA Lk0J5VAT0/AkqQhHzR3DigI84k8Z+nn/JarIeGPCvKYpdIudmy5XwLAaleP+mnVk7GTL bPIg== X-Forwarded-Encrypted: i=1; AJvYcCUS59n1JO6Gzb51imxRi6VsmI3mva9l5voBNfFlFD28uQlvHu15iOUb47Y3VeGlCqp9s+VN86RNIMIBHY0=@vger.kernel.org X-Gm-Message-State: AOJu0YxG+eXP2nARkv2w0XSpndFvFDcLSQax7rXxj/0ZPAAVOrSokP1F oAQIncMgfa/s3w1+OVLn4TK+10stVFvuwhEmmO5vhCjKqsntz2sTRIaJxuE/gtMPaoc56lz7cLV IXp28IwVWktuQmhL4x/gHMotWLxClmVybkdClcYEekV0jFt6KAjeT5RAN8Nz7dslL4vY= X-Gm-Gg: ASbGncvcZTIBcS73orScV3c5V8Mqd7JcQWbZxV5Yp7mlLa6VqzCzNiPqo8IZ63TENWZ X9CP3VopME+CCYR5+5WdB2uXu6I8omxqIfOclPCSATBsbNpEGqc4MQJLKd44ndv+3sq/nacWKUR D9+CMYWahqHyTPWuSSlhy1VclRLucZdzmBoPiDBEPqAbioJKQ8x2K+CuFRr3lLZoAvd2pDo1u6O i4lydX2B9eeviz4Yg8Rya2hJhMixwZ4T/s3jRASh3nxXaGZvvYTV1k63YTPxS4LzTEx25XPK8c/ iemesoLz6qzd5W9t/5bg/o8A9m2yBFfw80N1Vfv+Ebodd63c7+AcoAr8PtiStpsssQehsdqmzom DFRsIyBe9Rdc3iAOZJi2dCtMydM94eSNyRfKy8X8unCYos4r0gJwBGcZoD/ym05xOJMLYN5WcRn UOsRlq2RO81T/vLWjTa94gQA== X-Received: by 2002:a17:903:1c8:b0:267:8049:7c87 with SMTP id d9443c01a7336-294cc70eccbmr32590015ad.14.1761649096638; Tue, 28 Oct 2025 03:58:16 -0700 (PDT) X-Google-Smtp-Source: AGHT+IE0mw89yeFqR3a6GQze79ilRQbukr6qbMLLAHbQ/m/vxaAEX6diASv/5hii+JLxpSNZMzMZQA== X-Received: by 2002:a17:903:1c8:b0:267:8049:7c87 with SMTP id d9443c01a7336-294cc70eccbmr32589645ad.14.1761649096102; Tue, 28 Oct 2025 03:58:16 -0700 (PDT) Received: from [10.190.211.199] (blr-bdr-fw-01_GlobalNAT_AllZones-Outside.qualcomm.com. [103.229.18.19]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29498d40de4sm114963405ad.77.2025.10.28.03.58.12 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 28 Oct 2025 03:58:15 -0700 (PDT) Message-ID: <76479593-c47b-41a7-8349-5d7c1403f7c0@oss.qualcomm.com> Date: Tue, 28 Oct 2025 16:28:10 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] watchdog: Add driver for Gunyah Watchdog To: Krzysztof Kozlowski , Bjorn Andersson , Konrad Dybcio , Wim Van Sebroeck , Guenter Roeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-watchdog@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Pavan Kondeti , Neil Armstrong References: <20251028-gunyah_watchdog-v3-1-e6d1ea438b1d@oss.qualcomm.com> <25f7ff09-08ea-4969-9184-9fd01b097558@kernel.org> Content-Language: en-US From: Hrishabh Rajput In-Reply-To: <25f7ff09-08ea-4969-9184-9fd01b097558@kernel.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDI4MDA5MyBTYWx0ZWRfX/S4gLPuqegYd ZzSYmapZeeDg78W8K89C9yNgtLJkcZXr9LTza7dCV3axuy3PJrxqvr6yyPUWCuD7SaQUZHROsoH /WmqmN57d6nUmn0WSMV57i5v8cgGfcW238AwRSFivPdCXEhf/fI+HtNWSclveM/bxQ4Ia9HPPJb M0ZHKnsV3Y/Nv/v26yPyXVMBoAIrK1MhhYlSt3zjrZ/jETgxNeym/z8Z6cz/UF7KXj8W8WyFzKB ZDxxcQUnoEkogRx12sg99thhHnJ1tqvWn08GFOcG7M2qeQG0/Wsb21N2FGMHNwjNdiYQq/wxJLg fHbHG+aCGqPXVeSwXDt31N26ZDwMQn8q6QL7pAnk+j320oGJVxtJhtxmS02DrUIiD3oHxvDyO3m Cvx4mi3VKTecmDM88OecxCphGf/6yw== X-Proofpoint-ORIG-GUID: N2Tq0SHOycap0SV0aj0mOnzXfKwq075n X-Proofpoint-GUID: N2Tq0SHOycap0SV0aj0mOnzXfKwq075n X-Authority-Analysis: v=2.4 cv=FIMWBuos c=1 sm=1 tr=0 ts=6900a1c9 cx=c_pps a=MTSHoo12Qbhz2p7MsH1ifg==:117 a=Ou0eQOY4+eZoSc0qltEV5Q==:17 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=SxZnsEcJDSkJ1Opw4BEA:9 a=3ZKOabzyN94A:10 a=QEXdDO2ut3YA:10 a=GvdueXVYPmCkWapjIL-Q:22 X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-28_04,2025-10-22_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 priorityscore=1501 lowpriorityscore=0 bulkscore=0 clxscore=1015 malwarescore=0 adultscore=0 impostorscore=0 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2510020000 definitions=main-2510280093 On 10/28/2025 3:10 PM, Krzysztof Kozlowski wrote: > On 28/10/2025 10:35, Hrishabh Rajput via B4 Relay wrote: >> + >> +static int __init gunyah_wdt_init(void) >> +{ >> + struct arm_smccc_res res; >> + struct device_node *np; >> + int ret; >> + >> + /* Check if we're running on a Qualcomm device */ >> + np = of_find_compatible_node(NULL, NULL, "qcom,smem"); > I don't think you implemented my feedback. This again is executed on > every platform, e.g. on Samsung, pointlessly. > > Implement previous feedback. Do you want us to add platform device from another driver which is probed only on Qualcomm devices (like socinfo from previous discussion) and get rid of the module init function entirely? As keeping anything in the module init will get it executed on all platforms. With this patch version, we have tried to reduce the code execution on non-Qualcomm devices (also tried the alternative as mentioned in the cover letter). Adding platform device from another driver as described above would eliminate it entirely, please let us know if you want us to do that. Thanks, Hrishabh