From: "Martin Hundebøll" <martin@geanix.com>
To: Jiri Slaby <jslaby@suse.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-kernel@vger.kernel.org
Cc: "Esben Haabendal" <esben@geanix.com>, "Sean Nyekjær" <sean@geanix.com>
Subject: Re: [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty
Date: Tue, 9 Jul 2019 08:52:22 +0200 [thread overview]
Message-ID: <764ab112-0e0d-fa10-607a-6ffb1f53297d@geanix.com> (raw)
In-Reply-To: <97618a78-36e7-f071-47e2-beadbd505cb6@suse.com>
On 09/07/2019 08.49, Jiri Slaby wrote:
> On 09. 07. 19, 8:46, Martin Hundebøll wrote:
>> @@ -2623,6 +2624,9 @@ static int gsmld_ioctl(struct tty_struct *tty, struct file *file,
>> if (copy_from_user(&c, (void *)arg, sizeof(c)))
>> return -EFAULT;
>> return gsm_config(gsm, &c);
>> + case GSMIOC_GETBASE:
>> + base = mux_num_to_base(gsm);
>> + return put_user(base, (int __user *)arg);
> I am not sure, but do you need the local variable at all?
No, I kept it around just to avoid too many parenthesis in the
put_user() call.
Your call.
// Martin
prev parent reply other threads:[~2019-07-09 6:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 6:46 [PATCHv2 1/4] tty: n_gsm: remove obsolete mknod doc example Martin Hundebøll
2019-07-09 6:46 ` [PATCHv2 2/4] tty: n_gsm: update doc example to use header for N_GSM0710 define Martin Hundebøll
2019-07-09 6:46 ` [PATCHv2 3/4] tty: n_gsm: add helper to convert mux-num to/from tty-base Martin Hundebøll
2019-07-10 11:48 ` Alan Cox
2019-07-09 6:46 ` [PATCHv2 4/4] tty: n_gsm: add ioctl to map serial device to mux'ed tty Martin Hundebøll
2019-07-09 6:49 ` Jiri Slaby
2019-07-09 6:52 ` Martin Hundebøll [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764ab112-0e0d-fa10-607a-6ffb1f53297d@geanix.com \
--to=martin@geanix.com \
--cc=esben@geanix.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sean@geanix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®