From: Lukasz Luba <lukasz.luba@arm.com>
To: "Rafael J. Wysocki" <rjw@rjwysocki.net>
Cc: LKML <linux-kernel@vger.kernel.org>,
Linux PM <linux-pm@vger.kernel.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: Re: [PATCH v1 1/2] PM: EM: Drop unused parameter from em_adjust_new_capacity()
Date: Mon, 10 Feb 2025 11:25:07 +0000 [thread overview]
Message-ID: <764b2869-8023-45b2-bae9-5a24be1ea519@arm.com> (raw)
In-Reply-To: <2369979.ElGaqSPkdT@rjwysocki.net>
On 1/27/25 13:37, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> The max_cap parameter is never used in em_adjust_new_capacity(), so
> drop it.
>
> No functional impact.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
> ---
> kernel/power/energy_model.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -728,8 +728,7 @@
> * are correctly calculated.
> */
> static void em_adjust_new_capacity(struct device *dev,
> - struct em_perf_domain *pd,
> - u64 max_cap)
> + struct em_perf_domain *pd)
> {
> struct em_perf_table __rcu *em_table;
>
> @@ -800,7 +799,7 @@
> cpu, cpu_capacity, em_max_perf);
>
> dev = get_cpu_device(cpu);
> - em_adjust_new_capacity(dev, pd, cpu_capacity);
> + em_adjust_new_capacity(dev, pd);
> }
>
> free_cpumask_var(cpu_done_mask);
>
>
>
LGTM
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
next prev parent reply other threads:[~2025-02-10 11:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-01-27 13:10 [PATCH v1 0/2] PM: EM: Two cleanups related to em_check_capacity_update() Rafael J. Wysocki
2025-01-27 13:37 ` [PATCH v1 1/2] PM: EM: Drop unused parameter from em_adjust_new_capacity() Rafael J. Wysocki
2025-02-10 11:25 ` Lukasz Luba [this message]
2025-01-27 13:38 ` [PATCH v1 2/2] PM: EM: Slightly reduce em_check_capacity_update() overhead Rafael J. Wysocki
2025-02-10 11:26 ` Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764b2869-8023-45b2-bae9-5a24be1ea519@arm.com \
--to=lukasz.luba@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=ricardo.neri-calderon@linux.intel.com \
--cc=rjw@rjwysocki.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®