From: "Limonciello, Mario" <mario.limonciello@amd.com>
To: Shuah Khan <skhan@linuxfoundation.org>, Huang Rui <ray.huang@amd.com>
Cc: "Yuan, Perry" <Perry.Yuan@amd.com>,
"Karny, Wyes" <Wyes.Karny@amd.com>,
"trenn@suse.com" <trenn@suse.com>,
"shuah@kernel.org" <shuah@kernel.org>,
"rafael.j.wysocki@intel.com" <rafael.j.wysocki@intel.com>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"chenhq2005@gmail.com" <chenhq2005@gmail.com>
Subject: Re: [PATCH] cpupower: Fix querying boost support for amd-pstate-epp mode
Date: Mon, 14 Aug 2023 18:33:03 -0500 [thread overview]
Message-ID: <764c49f6-0dd4-4bc0-8d7a-3054a5d75999@amd.com> (raw)
In-Reply-To: <62da8b7c-3a90-cffc-4750-532c2b440764@linuxfoundation.org>
On 8/14/2023 6:22 PM, Shuah Khan wrote:
> On 8/14/23 15:50, Limonciello, Mario wrote:
>>
>>
>> On 8/14/2023 4:28 PM, Shuah Khan wrote:
>>> On 8/13/23 22:14, Huang Rui wrote:
>>>> On Sat, Aug 12, 2023 at 05:35:01AM +0800, Limonciello, Mario wrote:
>>>>> When running in active mode the driver for amd-pstate has -epp
>>>>> appended.
>>>>> This throws off amd-pstate detection.
>>>>>
>>>>> To detect amd-pstate look for the prefix instead.
>>>>>
>>>>> Fixes: ffa5096a7c33 ("cpufreq: amd-pstate: implement Pstate EPP
>>>>> support for the AMD processors")
>>>>> Reported-by: chenhq2005@gmail.com
>>>>> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=217755
>>>>> Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
>>>>
>>>> Acked-by: Huang Rui <ray.huang@amd.com>
>>>>
>>>
>>> This patch doesn't apply on top of cpupower latest:
>>>
>>> https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux.git coupower
>>>
>>> Please rebase and send it.
>>>
>>> thanks,
>>> -- Shuah
>>>
>>
>> It looks like a variation of it is already in your tree as:
>>
>> a1cf97c2d43ae ("cpupower: Recognise amd-pstate active mode driver")
>>
>> Considering it was also reported to a kernel bugzilla, perhaps this
>> should be considered for fixes?
>
> If it is already fixed, there is no need to revert and apply your fix.
> Please close the bugzilla bug as fixed with the above commit.
Sorry I was unclear. My suggestion was that perhaps a1cf97c2d43ae
should be considered alone for 6.5-rc7 instead of waiting for 6.6-rc1 as
it fixes the Bugzilla issue. Otherwise we should wait until it's in
Linus' tree for 6.6-rc1 to close the Bugzilla.
next prev parent reply other threads:[~2023-08-14 23:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-11 21:35 Mario Limonciello
2023-08-14 4:14 ` Huang Rui
2023-08-14 21:28 ` Shuah Khan
2023-08-14 21:50 ` Limonciello, Mario
2023-08-14 23:22 ` Shuah Khan
2023-08-14 23:33 ` Limonciello, Mario [this message]
2023-08-15 0:03 ` Shuah Khan
2023-08-15 1:46 ` Limonciello, Mario
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=764c49f6-0dd4-4bc0-8d7a-3054a5d75999@amd.com \
--to=mario.limonciello@amd.com \
--cc=Perry.Yuan@amd.com \
--cc=Wyes.Karny@amd.com \
--cc=chenhq2005@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rafael.j.wysocki@intel.com \
--cc=ray.huang@amd.com \
--cc=shuah@kernel.org \
--cc=skhan@linuxfoundation.org \
--cc=trenn@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®