From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 019F736683D for ; Thu, 25 Jun 2026 07:59:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782374362; cv=none; b=rmqpPjxMPaa7+ap7yk3N+rwu37sTVYEyBVzzwjSshq0WBsWK4ccd5lr2fmITD/bvsOBu6QJSFPSmHjj7ugucKh0JjA+uUH8cNyWItMA4KSui7LyuknDcjeJkY7LqupWW6Hy20iRXeCsXzujVRwlvYUCBxW95HfFgtjoQPCfKmA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782374362; c=relaxed/simple; bh=z/WYgAPYjwAq4I23XYwEmqwh3cYJlJxhp2py1iXT17Q=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=COQN000rNlWJ5GrMpUdLh7xo/6HUEWwO3yVZbueDPfAR8IBE8vJszWO/M51Suy0nMQLg2NTHPBui9XRNIefW/dLUXAeMkE4FgIxXaneWkZp2qyqCwT4vambIPb59gx1nkKcXbUVQmlJudMXwHTpoiNDwsTUBOi4lf9lxVnkADkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=QyUc/VMk; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=YxBHHCxu; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="QyUc/VMk"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="YxBHHCxu" Received: from pps.filterd (m0279864.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65P75Lv51009118 for ; Thu, 25 Jun 2026 07:59:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Bt52y0UxYjJxGefuoc5i72x0TXQgvEF722OpeKsWqXs=; b=QyUc/VMkWOezro87 GzYLcaU76xRkzFuqv1/JyXF6K1s1nl94FasXPwSZHvFTI5F0b+udy7aoGR3bxw8Q fkXHt9/43wd0pmpdIq69xX5cB/MerZXHZ3BFmssDa1bjbc9/1+0EWU4se5Uh7EOM wzRWyW75R0YpPVOX86h4J6jURLzKzBv58DcUX9rETq4SvG72p3m8MmBFrrJ7gVtw GfPg7SCwU1N9eky1dwf1DBN4dZvsv2UasotEfZRNMDj5xMWfvzibxR2z67ywoILF Rrls71YMMj1hfIUx7NI7pILQ3+a7iS9yOPoLpRM++Q2F2C8qMFtAVdTwPZGA3vdi vh2jOA== Received: from mail-qt1-f199.google.com (mail-qt1-f199.google.com [209.85.160.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f0ymv06r8-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Thu, 25 Jun 2026 07:59:19 +0000 (GMT) Received: by mail-qt1-f199.google.com with SMTP id d75a77b69052e-517796be724so3929361cf.3 for ; Thu, 25 Jun 2026 00:59:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782374358; x=1782979158; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=Bt52y0UxYjJxGefuoc5i72x0TXQgvEF722OpeKsWqXs=; b=YxBHHCxuQyhPrVId/jrGuHOe2MLRJzga65SYw2YWSQOTYr/a3C0xfB7F+UF4sKcxnt 4gReACjtP3uPWl6P5gG06u3+wv4dCUCJTW5/wSXlS6EDeJhYadvXWFMils7oGusN2QJn odmNSPT19cbbV9qQgFqMy76z+3haZnKOjyvQZpHIwhe1EQkNwaq22zfRz5fyuGK7X1Ed 6ugeqwjwb4cXeGVDs4O2PsMWku7h2PbQqjGnFJRn9GW4oa20KJqDpMPoSUFikjaEGwda Sai2wWysmcs1YNaFiRRT6dglp67WhuIbpQTsGjqqnrtVv0D9hVQzYNktfng91QiMnbhA At8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782374358; x=1782979158; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=Bt52y0UxYjJxGefuoc5i72x0TXQgvEF722OpeKsWqXs=; b=NKetTg17r0AjCvOAbZiFH1Bq+e01x8/+zk6+EQePN51nm8T5hrKIBSZS6QNldeZjAa zaxdm7PGiAHUP64U/L+gjKt825qB561MNOeO/+o4dBkAMzyQLlblB4dGeICYg2y/+kwH 2Iax4cVSqj/ZlGVGisIXYgnVso1UinA2A2Q4xIKIbE5qVyrKLeB5zAkCh9d78Yeq+3rz Q4j5OrkFunG6BaJ1r5W7d68ZeS+EwFgs9++zQHu9am7I/b07PY3FCgy0k5SLCyvL0wSm B2fr28RF6VDYiIDryDHyoBkY5Xo6oKG7/QPLhC1GJEDICH55VFe8KUP9TqPndEJY0pNM u0Ow== X-Forwarded-Encrypted: i=1; AFNElJ9PjAqh/Vcqe98++OcPNmg4HXKfJ0+a4gWvxxo3szuHLxMvK5iBPdouWZok+f4hOX5OzBmCdVonKLmfuv4=@vger.kernel.org X-Gm-Message-State: AOJu0YyNJti6NL0hxWlFhfwTiuR/SpDewtieh3YPAGRiIC3s7QvZxM3R 7P74QH/5vjXxO16/Cdcfp1feVCDBeQlR1wNoa5fEir6sdsfBClV4nKy9ugHvFlC6CwnRYNYEGzc Or7pP973Pd3kiLkCgli/RMgFThaIsoTK/JP6H3VNon06sUGCM/Mane/5xjgVjK3MynNo= X-Gm-Gg: AfdE7cnMke1HvQrvgpY04m0by+EIZcghPpgDX6O7e43ZfC1Sk69gGKK3d3afkGHiwGk ZfjqA1OssKGJJzglWYKipGnH/2MFC6lrLAQ2kFLhsFJb5nbIK+7vVkeXQNyQDz6a/T/CAcD4B49 DNOMXSj+OOeXl9wXWE5HEdegAawwdO8FkmcZVMcwUjTOnT9j0U1YO6Fj/2moLjs3b78Lv76natU tmoHOpxpKpnuMosxD8qnR7xf82M1hjDkM2o1FWxQBAdOQUp/xB3xcdePzOx/x37cMo+HVd+ZVsB JzD5qDz45PsOY5EXHBcOOWpUTivGVPe3e5UXfqQVEUK7wimKp7IYVX07IT1dt6nkb06gjtscecd MlFxw+Lm2y+KmJ2fVqxIDUF+VTb5lDbPqLn8= X-Received: by 2002:ac8:57c5:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-51a72a47ba5mr10403651cf.3.1782374358299; Thu, 25 Jun 2026 00:59:18 -0700 (PDT) X-Received: by 2002:ac8:57c5:0:b0:517:6162:daf5 with SMTP id d75a77b69052e-51a72a47ba5mr10403331cf.3.1782374357864; Thu, 25 Jun 2026 00:59:17 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-c11fbe5f249sm120328866b.50.2026.06.25.00.59.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 25 Jun 2026 00:59:17 -0700 (PDT) Message-ID: <765b17f5-0ae1-4efd-8af4-9f9411862acf@oss.qualcomm.com> Date: Thu, 25 Jun 2026 09:59:15 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3] pinctrl: qcom: Unconditionally mark gpio as wakeup enable To: Sneh Mankad , Bjorn Andersson , Linus Walleij , Neil Armstrong , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, Maulik Shah References: <20260616-enable_wakeup_capable_gpios-v3-1-fb59647d89cb@oss.qualcomm.com> <37f34aff-c68f-43ca-b23c-500cc9bb119e@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <37f34aff-c68f-43ca-b23c-500cc9bb119e@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Authority-Analysis: v=2.4 cv=DqBmPm/+ c=1 sm=1 tr=0 ts=6a3cdfd7 cx=c_pps a=WeENfcodrlLV9YRTxbY/uA==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=DJpcGTmdVt4CTyJn9g5Z:22 a=EUspDBNiAAAA:8 a=isb_plKU-JZBI8JTm9kA:9 a=QEXdDO2ut3YA:10 a=kacYvNCVWA4VmyqE58fU:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI1MDA2OCBTYWx0ZWRfX7NNjPUD5t2to xDnwQdiQc4YBL/b+/vtl6LRFQVdgFDZ5LxMSukwKrlU8I8r7tkixqFLRSkvbny3SREOpiHjapGh EbJajVskFPGnCpIeioJZGN19mRLACvk= X-Proofpoint-ORIG-GUID: in91l2yS8Z4pz0fue0W3L1q-kuQH-Cfg X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI1MDA2OCBTYWx0ZWRfX/Zdtea/NpZoE iaoxkn5WWvtty/klFzuKTqFNTs6roRtyPMbvlWoqoBche5Scrn6GvxuwXgVZYIwarV6ZBRtDUCS MhhXsE3kp6EUVF5OlsEf+QJ18dQcpsecmA5Ar0Z1LWYpAuBGkXRvaZ3Z6pBS8FQjT/SeHGOo5/w lD8xOF2nehZdZFma6NMFPiPVPN8BNQxWvgjZ5BS9NKyl53o3F3BQBqjBtsbQ6QbH2z7IjJNpCpj eOuVl/dkUwSYRjhm7Ydyu5shko4XE3+LXPljQe6m6DNYLdIjdYhTYvp8TQQSc/YY/LA6kM1Urr+ eL5CM+sQCVT7ynK4EcHQBGa9SSMkwhEaGu9dMslz3zUaI6L2wMGy9y1PYH0vlfFaNczfA034sdl VUYdDg9mKNSKaCqY0FINgwgkXOWFNPOqdhfixOI5eAVXSEkSkJjXZh9Z9UDmrRKxn5wuVUTg/WP pvY534JPEa/UIY/dNFg== X-Proofpoint-GUID: in91l2yS8Z4pz0fue0W3L1q-kuQH-Cfg X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-25_01,2026-06-24_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1015 lowpriorityscore=0 priorityscore=1501 malwarescore=0 suspectscore=0 bulkscore=0 adultscore=0 spamscore=0 impostorscore=0 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606250068 On 6/25/26 6:33 AM, Sneh Mankad wrote: > > > [...] >> >> This is a much better commit message, thank you! >> >> One question remains - should we set skip_wake_irqs for MPM too? >> >> My understanding is that no, since the MPM HW is simpler and doesn't >> have a register for acking IRQs, so we need to do it from the recipient >> (TLMM). Is that right? >> > Yes that is correct. skip_wake_irqs is set for PDC since PDC can handle interrupts > during active time and SoC sleep time both, so any wakeup capable interrupt source can > be handled via PDC at all times. However MPM can only handle interrupts when > SoC is in low power mode, it does not have the functionality to detect them when SoC > is active. skip_wake_irqs differentiates this behaviour. Thank you! Reviewed-by: Konrad Dybcio Konrad