From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f47.google.com (mail-io1-f47.google.com [209.85.166.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DAF171E4AE for ; Fri, 27 Sep 2024 16:16:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.166.47 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727453796; cv=none; b=OmN0KcxSPYmLNcOFB9NHDbbYsvI6yN9xVJnWRVAm2q49XwXoBM+SNcX0MOlzolP9vmUVPTRC9/CO/Aeob73q/EJy+sTbQWrkw6zBdXGUz/B0xOMMbA/JEVD4jsdxS5F7wfQ4JP1gK1Yn/iI29oqQGNR7TGH3X6oZL1dnleQChgM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1727453796; c=relaxed/simple; bh=Wu52U0EBGUW8RDbNXrq7iBFkfNUHVmBD2A0I09aK/XU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=gAtWKETr/Cw6VfQ2pdkZrMkv5nmvkpsL5/JhEMDOIM+SWjpqjfnoxldb7fppNXlJAY97MfChpUy6zVX4JT4sMaaDS1SCC7ximM3JLskziNbNOczYh8ioRNo9zAdt8S0wE+XMO+VnWZlX+Z9zjfRnkCo/IC8hhQ3bUGZdboKgITI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org; spf=pass smtp.mailfrom=linuxfoundation.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b=bmSxR155; arc=none smtp.client-ip=209.85.166.47 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linuxfoundation.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linuxfoundation.org header.i=@linuxfoundation.org header.b="bmSxR155" Received: by mail-io1-f47.google.com with SMTP id ca18e2360f4ac-82ce1cd2026so81283839f.3 for ; Fri, 27 Sep 2024 09:16:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linuxfoundation.org; s=google; t=1727453794; x=1728058594; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=HR9L1tFGwvsuWLdcZhMfYeFWtiRJ32Evy1PyzIhswm4=; b=bmSxR155LpztWLjHuK6OM0XH94QISn4Cqa81heCkCyb5UEC+4TRjr/I2E53cOBwyGX 42L0hLiGtkq/WGzzGYYaOa+BLvFHkkJGc2Os+T1omyzcbPEgFmiXkB42ab0pef67UTWE JVKeSMdgXCc3TRjddUPE7HxeTXc5bw2ZNtiM4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1727453794; x=1728058594; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=HR9L1tFGwvsuWLdcZhMfYeFWtiRJ32Evy1PyzIhswm4=; b=fktWedi/yFojLp+prlBnDLxgN7X2hnj2LUpW9bFJGlFfTDP4Gig3lpvwkiFicYSH4c EwF3bBZ4nV2vCosjaUpoh66a0O41JnVdEgNqw1UzGmHF5cxEgdigzodqUqTqgcxBpi6T jUCFhyxDHEu0cMu+C4SFTEjqJMCqhWxEQFR+AqhPz6so+vLBhIhpzG2CTGGbz1ODJnFw AvjrfZHrUmgVobZ+KTuSd22hvi9j0MoRWJLgzR6LCDud3nA6uTo4dp/I5ewcZBMv4qbS u/O1I+GHotu/1jMEGGlYUjzBSta8lKm5v5iPreBVqZnh8IqfrTonPq4H8iDuSMNDY2ey lEEw== X-Forwarded-Encrypted: i=1; AJvYcCWR2Bmig+y/AKkjNA2WevFFMEWian7jafigCkowWWr+Cn3nyr2MrAMtJWwYgOexvaelEADxp45e7Oa/Kwg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxn14g7skbMdbojcjTeFJlQC3D41UBYraVVmIiTYM2BLUqPAprK Sg39FziDJlp76Jz14p/mW5KF1ILNIybKooX/W2QwF6LjsSXIrJqPEzBaHepEThU= X-Google-Smtp-Source: AGHT+IEP5nmUu95Efe+WgHxrtI1tFEnKpgExLNzW4lKixMYXEZzO3I9iY25TPelr+EvCIoR5XQW/Sw== X-Received: by 2002:a05:6602:2b0b:b0:81f:8f5d:6e19 with SMTP id ca18e2360f4ac-834931ae996mr458104939f.2.1727453793860; Fri, 27 Sep 2024 09:16:33 -0700 (PDT) Received: from [192.168.1.128] ([38.175.170.29]) by smtp.gmail.com with ESMTPSA id 8926c6da1cb9f-4d888835209sm554605173.11.2024.09.27.09.16.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 27 Sep 2024 09:16:33 -0700 (PDT) Message-ID: <765e0a55-8bb6-45a7-a32e-73b40f92f7dd@linuxfoundation.org> Date: Fri, 27 Sep 2024 10:16:32 -0600 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net v2] selftests: forwarding: no_forwarding: Fix issue related with assigning two different vids to the same interface. To: =?UTF-8?Q?Kacper_Ludwi=C5=84ski?= , "davem@davemloft.net" Cc: "kuba@kernel.org" , "vladimir.oltean@nxp.com" , "linux-kernel@vger.kernel.org" , "linux-kselftest@vger.kernel.org" , "netdev@vger.kernel.org" , "pabeni@redhat.com" , "petrm@nvidia.com" , "horms@kernel.org" , "edumazet@google.com" , "shuah@kernel.org" , Shuah Khan References: Content-Language: en-US From: Shuah Khan In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 9/27/24 01:03, Kacper Ludwiński wrote: > Fix typo. Remove the above line. It gives the impression that this is a minor spelling fix when it is not. It is fixing a problem that prevents the test from running correctly. > Currently, the second bridge command overwrites the first one. > Fix this by adding this VID to the interface behind $swp2. > > Fixes: 476a4f05d9b8 ("selftests: forwarding: add a no_forwarding.sh test") > Signed-off-by: Kacper Ludwinski > --- > tools/testing/selftests/net/forwarding/no_forwarding.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/testing/selftests/net/forwarding/no_forwarding.sh b/tools/testing/selftests/net/forwarding/no_forwarding.sh > index 9e677aa64a06..694ece9ba3a7 100755 > --- a/tools/testing/selftests/net/forwarding/no_forwarding.sh > +++ b/tools/testing/selftests/net/forwarding/no_forwarding.sh > @@ -202,7 +202,7 @@ one_bridge_two_pvids() > ip link set $swp2 master br0 > > bridge vlan add dev $swp1 vid 1 pvid untagged > - bridge vlan add dev $swp1 vid 2 pvid untagged > + bridge vlan add dev $swp2 vid 2 pvid untagged > > run_test "Switch ports in VLAN-aware bridge with different PVIDs" > > -- > 2.43.0 > With the above change: Reviewed-by: Shuah Khan thanks, -- Shuah