From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC9EE13B58A for ; Mon, 29 Dec 2025 07:00:51 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766991653; cv=none; b=Etl5tZPvatYKqppc4Q+mMrtZouOJxQqwVTpP7ahXEjGwpkVMIinapApyTZ9dv4USUNk8oPhmey2a07ASwJqnOBtif9oNVjMMk96Sl4rToggeHjc5ZQCT1fvX+GqfyOXDjINwNRFz+s8Z/rxEdPaY91a1aAYq+vAMyNagoiB8Zm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766991653; c=relaxed/simple; bh=t8OcG2twO/nrzWxVIrhkWMvBJQ/Zx/Os/S+s48QKCNc=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=goD3khQiC52mluvUuce50F9yKHpu7mTDbQgX0hQXRW/RyWXVK2JvgwFOLlsYz5xJCrLX6k66KpeW/ZDsHofLQQMKfWlSfW695XhOT9K3Jsd8jjjla+KCKJHonO/9kcAmM+ES+OFol3Jc2GmJzSn8ItJsPbS5eZ4id1BD5MbI96M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=cl3AapKc; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=Bvnwq311; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="cl3AapKc"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="Bvnwq311" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1766991650; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=t8OcG2twO/nrzWxVIrhkWMvBJQ/Zx/Os/S+s48QKCNc=; b=cl3AapKcrE+0c/jL+5MSLAhtB94GFtXR/VO8C1vmA6VNIRzfADzp0uZ3GWVcsW7zrLtMW+ Keni7hIH5z2Lc3DNn/0Ciq/z38O0xiivp5cm5d/hGavtRCr6Dr+6C86dHomba94PunsdZH ur7h/6jOtb65e4GS3BPuQu3NGjPQ3ig= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-78-nW3CG17sN7648Eg2DlkQNQ-1; Mon, 29 Dec 2025 02:00:48 -0500 X-MC-Unique: nW3CG17sN7648Eg2DlkQNQ-1 X-Mimecast-MFC-AGG-ID: nW3CG17sN7648Eg2DlkQNQ_1766991647 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-47777158a85so99562595e9.3 for ; Sun, 28 Dec 2025 23:00:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1766991647; x=1767596447; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:from:to :cc:subject:date:message-id:reply-to; bh=t8OcG2twO/nrzWxVIrhkWMvBJQ/Zx/Os/S+s48QKCNc=; b=Bvnwq311jv38h3BoayA4b52t3rIFbSAj7oODqZXlWOu+R5hNJxau+gulLeEe2r/gNB a10u2vqs6N6VF5M3ZJKgdF4uwWVRnWw8ltbtyhOl4EoIOHbLkF/8wnprMfOgrQEIz/SQ jh9OC3ICETSN7V8hcKplPrXN0aHcxOMkgEWxQiBF2bmhTfAuGNu6cLcc/rWSo/PNVRLf kwiTPfIbV9b6jNPIGt/3nKbRwjK02i9K7IkS+S6m1AV5wNDr+Y+XgisxnpdWoicsFJtF lke86Rr4DitRa/+GdxTP8kUikv7Hje4xzuboLjQsCrbn5dTLrp3bQFG0jmN1gH0mj0Ri YSgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766991647; x=1767596447; h=mime-version:user-agent:content-transfer-encoding:autocrypt :references:in-reply-to:date:cc:to:from:subject:message-id:x-gm-gg :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=t8OcG2twO/nrzWxVIrhkWMvBJQ/Zx/Os/S+s48QKCNc=; b=iAx2Lg1wTrst+dxmVlMZxdh7PXlYUjNLpuZknjwcpWlbJ9hRirhv0YOGGJZhFPfZe+ /D9DkhpsIXqx8yqBZCnFVSyOamg+h/YwFGF7gZrnqheLRcN51BdidPIEzIixKrstc6x1 aEX3dTi0ivr4DpCQydvr8Wt5mpu7Y2/i4amfZQXaJJNFbotBlChTrCU1Uoep6iYhQBTX d+frtL5yEA0FCVDuUXBhXpQ7cnN7V+VrwUo918rn/517jf4m3WJ7lLuIMPa9UIdu+aNs LBj8Bjy/RkTqhjJtc6mGlppj5lKPBktV+wNSBjxnfWl7zWEPMv8E1G3iqec0hbQcTiOu fQOw== X-Forwarded-Encrypted: i=1; AJvYcCUxyX8CLIAiCAjn+GFMDpv5Ur/PGMx1jDAmLyTyfH7QoQVRtFsk4hJfUwZu66oVN2eSnKMT/WkDTJ0MGFo=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr89P+vGeuZZkXFGAj1zBzC8HeMRYcjeoeDH0kZrVLnoouJVDx 7+7M68JKXioi67O+q1ixNy0MnRqSrDxndKInSwS9qx8S00zqlnAvQb0A9d+IKSAX6dI+ZWiAe2C VdUFq+h8ffKtRjj1e/shXOaEcGl+Mvi7ahTW4kTzGSA8wKYeUCPLhQ1ze1I8rJHgbuw== X-Gm-Gg: AY/fxX5IB5kzIoUVum3CoIjvLsZz3m90YSEd22sDUPUcj/UOpGR0MwMfn+NxMWY5Dos FHwe7eHpGRzWrAIE1ZuoWWTsqf9imh0vgwMQEsJRABbwj0Ch9nLUSQG6OutaRPIQkISXKJZk11/ Gmt/Lmns2SNGoRFkMYprePal4C+oBpkuFXqa91rZ8b1CEiJvivAmeyJk+thDRI2ByhhFlooIJYv Y8fbaJwh9iTz3Fd/EXosHHQc69Psh29UDlpj/FkVXL/FowC6daLchS3x39cfDMBQ2/lT6zGc8ZM wPkV7jVLuvouJnaXVcDgf6EZOOCx9mpPpVh0jBP5v4CdkRyY1qCH+hRa1nDnJB90tNShYuB4wLt F2VxBKH2/inbAtbjt9fjnN8ncMLsmEfR4asMC1sBfb2S4lktEXDDpd+3wGt+Cv0oUbgzUjfObj2 6BlcgodLGA X-Received: by 2002:a05:600c:1d1d:b0:477:abea:9023 with SMTP id 5b1f17b1804b1-47d19577fb8mr332907645e9.9.1766991647284; Sun, 28 Dec 2025 23:00:47 -0800 (PST) X-Google-Smtp-Source: AGHT+IEmFC/mzoVHhr44ireW2o9YalzKlM0MsJyH2BzxwmYl5AR9TFxemVezBupGB3gx7MCpUqcDFQ== X-Received: by 2002:a05:600c:1d1d:b0:477:abea:9023 with SMTP id 5b1f17b1804b1-47d19577fb8mr332907295e9.9.1766991646898; Sun, 28 Dec 2025 23:00:46 -0800 (PST) Received: from gmonaco-thinkpadt14gen3.rmtit.csb (185-132-178-103.hosted-by-worldstream.net. [185.132.178.103]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-47be3af6dbdsm232499725e9.19.2025.12.28.23.00.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 28 Dec 2025 23:00:46 -0800 (PST) Message-ID: <765e80ba6895985aadafc5c1bfe8a361575252f2.camel@redhat.com> Subject: Re: [PATCH v3 12/13] rv: Add deadline monitors From: Gabriele Monaco To: Nam Cao , linux-kernel@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , linux-trace-kernel@vger.kernel.org Cc: Tomas Glozar , Juri Lelli , Clark Williams , John Kacur Date: Mon, 29 Dec 2025 08:00:44 +0100 In-Reply-To: <87y0mr9vaw.fsf@yellow.woof> References: <20251205131621.135513-1-gmonaco@redhat.com> <20251205131621.135513-13-gmonaco@redhat.com> <874ipfbay7.fsf@yellow.woof> <87y0mr9vaw.fsf@yellow.woof> Autocrypt: addr=gmonaco@redhat.com; prefer-encrypt=mutual; keydata=mDMEZuK5YxYJKwYBBAHaRw8BAQdAmJ3dM9Sz6/Hodu33Qrf8QH2bNeNbOikqYtxWFLVm0 1a0JEdhYnJpZWxlIE1vbmFjbyA8Z21vbmFjb0BrZXJuZWwub3JnPoiZBBMWCgBBFiEEysoR+AuB3R Zwp6j270psSVh4TfIFAmjKX2MCGwMFCQWjmoAFCwkIBwICIgIGFQoJCAsCBBYCAwECHgcCF4AACgk Q70psSVh4TfIQuAD+JulczTN6l7oJjyroySU55Fbjdvo52xiYYlMjPG7dCTsBAMFI7dSL5zg98I+8 cXY1J7kyNsY6/dcipqBM4RMaxXsOtCRHYWJyaWVsZSBNb25hY28gPGdtb25hY29AcmVkaGF0LmNvb T6InAQTFgoARAIbAwUJBaOagAULCQgHAgIiAgYVCgkICwIEFgIDAQIeBwIXgBYhBMrKEfgLgd0WcK eo9u9KbElYeE3yBQJoymCyAhkBAAoJEO9KbElYeE3yjX4BAJ/ETNnlHn8OjZPT77xGmal9kbT1bC1 7DfrYVISWV2Y1AP9HdAMhWNAvtCtN2S1beYjNybuK6IzWYcFfeOV+OBWRDQ== Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.2 (3.58.2-1.fc43) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Thu, 2025-12-25 at 08:58 +0700, Nam Cao wrote: > Nam Cao writes: > > There are some helper functions that I am a bit uncomfortable with > > (e.g. pi_of, is_dl_boosted, dl_is_implicit, ...) because they are > > relying on implementation details of deadline scheduler which can be > > changed. So ideally this patch should have an Ack from the scheduler pe= ople. Thanks for the review! I'm going to ping scheduler guys some time after the holidays. > Think about this again, perhaps we should move all these helpers to > include/linux/sched/deadline.h instead? The scheduler people must be > aware of these functions, and maintain them. I don't want a situation > where the scheduler people make changes, and something else (which they > do not know exist) breaks. That's a fair point, I just copied those functions from kernel/sched/deadli= ne.c but that's dirty indeed. Going to try exporting them to deadline.h and see if no one complains. > Ideally, non-scheduler code should not look at private fields of > scheduler's structs. Yeah, one may argue those modules shouldn't be doing what they're doing wit= h the deadline entities. To be fair those modules are quite dependant on the data structure implementation, but the alternative would be to maintain a set of getter functions which might as well break. Or at least I don't see a better way. Thanks, Gabriele