Re: [PATCH] platform: arm64: EC_ACER_ASPIRE1 should depend on ARCH_QCOM

[Hans de Goede <hdegoede@redhat.com>]

Hi Geert,

On 7/11/24 4:30 PM, Geert Uytterhoeven wrote:
> The Acer Aspire 1 Embedded Controller is only present on the Qualcomm
> Snapdragon-based Acer Aspire 1 laptop.  Hence add a dependency on
> ARCH_QCOM, to prevent asking the user about this driver when configuring
> a kernel without Qualcomm SoC support.
> 
> Fixes: 2b3efb7c515111ea ("platform: arm64: Add Acer Aspire 1 embedded controller driver")

Thanks, patch looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

Not sure if this warrants a fixes tag though, anyways I'll leave that up
to Ilpo when he applies this.

Regards,

Hans


> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
>  drivers/platform/arm64/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/platform/arm64/Kconfig b/drivers/platform/arm64/Kconfig
> index 8c103b3150d1d0a6..058a4baa216a83b8 100644
> --- a/drivers/platform/arm64/Kconfig
> +++ b/drivers/platform/arm64/Kconfig
> @@ -18,6 +18,7 @@ if ARM64_PLATFORM_DEVICES
>  
>  config EC_ACER_ASPIRE1
>  	tristate "Acer Aspire 1 Embedded Controller driver"
> +	depends on ARCH_QCOM || COMPILE_TEST
>  	depends on I2C
>  	depends on DRM
>  	depends on POWER_SUPPLY