From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1036529AbdEYTfu (ORCPT ); Thu, 25 May 2017 15:35:50 -0400 Received: from mout.web.de ([212.227.15.3]:52776 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S936593AbdEYTfi (ORCPT ); Thu, 25 May 2017 15:35:38 -0400 To: linux-pm@vger.kernel.org, Greg Kroah-Hartman , Len Brown , Pavel Machek , "Rafael J. Wysocki" Cc: LKML , kernel-janitors@vger.kernel.org From: SF Markus Elfring Subject: [PATCH] PM / clock_ops: Delete an error message for a failed memory allocation in __pm_clk_add() Message-ID: <7665c16b-5f76-731b-abd0-476f8d90dd59@users.sourceforge.net> Date: Thu, 25 May 2017 21:35:24 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:dc9JNH+TNdCa5sN0bkI9iCzph+P1xvKP8n/XD2ad7hDPgbLJlgP wpQg2rHr6yINY5DpQVW/veLEEunIMAS+fun0M9dASEE6WFldq71wNa5kAEjnuWxOstSppML An8sYKbyERzDwzstarjrstGbAJx7AH2KKY09BLONjT7suFMgrGRROQJwjolpqvSQGUfmUHZ GpS+kxE0H4LNKZ20RYC/w== X-UI-Out-Filterresults: notjunk:1;V01:K0:qUhzqzWkPq8=:7lPFuTgH//xhVSWnr3NECc MCtuC6qIn3bbB2M731ddCxEhP84iZP44gHeslcdbYS9wEgMiMMY2mHheP7oIVqkg6Yhh+tSK2 pfk0rSYeYaALD4ljBe2hl/al6J0tLJoYyoWL2+Ti5Q34oyQMTzYKMdtma1/dUsNLTEnkM2LbH CDYjZ36xXDauaYEdrtitYPP0Ygy+naXLye9ltREXw4Ey4lV78j3zx3I2miTrkRVJ9k+F/A8JL 8fzxmDnNhtleznI72HIIbzSlNPoKExA2X2tgH0dvuWh0/7zvVRWUcOdYkjsPBUzMCA5eTOh2N lWtFblTuQ3vM02tMurh4WVLTaJs169resNmVt4f32bNqXDYJfNo1uhIobFhS/n+53CFKiRtL6 5NyzRvKqP0Ade6Traa1OuJZmO5yiYKzV+atuzPYtQk5ukcoIOiNyTBvYKk1voIU/xU2HgIRQB mIzrfsB6ptjZsXywkcvmyiK0vKgEDvgPA/VAw+p2yY/8a0Z0N5EOkO5lPZh2YBo94Fhd0BR/u YKVex2XR5Xf8tJ+VUHgeGs0TeqGxFGebh47WtV2QiP+lUeTzKtqxluylyCsg+43e0NopL1k5T kOEn1M0N96hP7bll7F9f4IqWpiwR8cLLPs7y12mBT4RMrwzLpOouEgSk5tgmWlpQE8OClRpX+ Ah2ndAB9+xWxf3uje+sGJp/kIp1yscRda0fbkcpLcHT6SKiCr7QPxPVVtaWH9MiY/zTj39/wZ 5nH/Wqs2JPHa5bGSA6DCZgkbC+94WtFK9V9r/VCoTYa0rV3n8ylYkteNCcXlkY9lds1UnFKQB A2q3V7p Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Markus Elfring Date: Thu, 25 May 2017 21:28:10 +0200 Omit an extra message for a memory allocation failure in this function. This issue was detected by using the Coccinelle software. Link: http://events.linuxfoundation.org/sites/events/files/slides/LCJ16-Refactor_Strings-WSang_0.pdf Signed-off-by: Markus Elfring --- drivers/base/power/clock_ops.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/base/power/clock_ops.c b/drivers/base/power/clock_ops.c index 8e2e4757adcb..aa25ef4e6e5a 100644 --- a/drivers/base/power/clock_ops.c +++ b/drivers/base/power/clock_ops.c @@ -88,8 +88,6 @@ static int __pm_clk_add(struct device *dev, const char *con_id, if (con_id) { ce->con_id = kstrdup(con_id, GFP_KERNEL); if (!ce->con_id) { - dev_err(dev, - "Not enough memory for clock connection ID.\n"); kfree(ce); return -ENOMEM; } -- 2.13.0