From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbdFTKbb (ORCPT ); Tue, 20 Jun 2017 06:31:31 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:45545 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751083AbdFTKb2 (ORCPT ); Tue, 20 Jun 2017 06:31:28 -0400 X-AuditID: b6c32a2e-f79746d00000129a-ee-5948f97dc79f Subject: Re: [RFT 2/2] pinctrl: samsung: Fix invalid register offset used for Exynos5433 external interrupts To: Krzysztof Kozlowski Cc: Tomasz Figa , Linus Walleij , Kukjin Kim , Marek Szyprowski , Chanwoo Choi , linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, linux-kernel@vger.kernel.org, Donglin Peng , stable@vger.kernel.org From: Sylwester Nawrocki Message-id: <766729e5-b29d-4bf1-0186-3eacbd11f07e@samsung.com> Date: Tue, 20 Jun 2017 12:31:18 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-version: 1.0 In-reply-to: <20170614131828.28683-2-krzk@kernel.org> Content-type: text/plain; charset="utf-8" Content-language: en-GB Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA02Sa0hTYRjHeXcuOxtbvC3TJ7uykFLQEjNPFFIQdaAL0ZeyD9bQw8y2OXac pRBZUVlimg0aI2qJ3SwrN7tZXpgt5wUsoy3FtLSbmuCYaF6K3E7Bvv2e2/t//g8vQ6haqGjm sCGXNxk0OjUtJ580x66KPz7Fpa291hzB+sa/U+zXez6KLR0cIdjOzkdS1jJ7W8I6Br0U67w+ i9h3dVdp1trZIGGrX32UsvaaAcRW1c2izQruue2jlHNUnae5Xu9LmnNWnuAu1lYhLuBYtoc+ IN+UyesO5/GmNamH5Fn2K9uMbbJjtfUWshCNSS8gGQN4Hby95qBFjoQ3fQ/nWM6o8E0EE/7v EjEIIHjTPkn/n7BZblFioRrBreHHZLCgwv0Ihvuyg7wAG6DM30YEOQLHgu/3ZGiAwKUEnK+/ iYIFGidCifviHDOMEqeC/acumCZxDPxxj1JBXoj3Q0X5pdCqSjwffl3uC2nJcDKM+V2hhYi5 93+Ml5MiR8Hr/m4k8nJw3h8lgrqAu6RQM/UtpAV4KTiaCNHMVhgd7SFFXgDDLbX/zhINxUU2 qThbisBz/zQSAyuC3nNlErFrIzS3vKVEtXlQMvNFIgoooeisSmzhwFvqp8X0FijuSBcP50Rw p7GYKkMrbGHebGF+bGF+bGF+7IisQpG8UdBreSHZmJQgaPSC2aBNyMjRO1Doe8UlPEN/7Dtc CDNIrVByQ9vTVJQmT8jXuxAwhDpCqWjl0lTKTE1+AW/KOWgy63jBhRYzpDpKufqud78KazW5 /BGeN/Km/1UJI4suRNb10xnPKkyeXRTeeuZF5TZvyYee/MCnprtDT3vM03JteXxDR/uNnUtP 6U9u2Ozx2Cc/pKzINDYa3PA5cOFBa1fAsyxbS3Pbl1SmfjVOkOSIcdGv9CTjQFSRpVuhM1+u PrpvZqXcvXC34CloTHm/L+a9rxel7o1rSOmw1sdYK9SkkKVJjCNMguYv35ibvloDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jQd2anx6RBhvbmCyuf3nOavF09XVW i/7Hr5ktzp/fwG4x5c9yJotNj6+xWmye/4fR4vKuOWwWM87vY7JYe+Quu8WCjY8YLVbt+sPo wOOxc9Zddo9NqzrZPO5c28PmsXlJvUffllWMHp83yQWwRbnZZKQmpqQWKaTmJeenZOal2yqF hrjpWigp5CXmptoqRej6hgQpKZQl5pQCeUYGaMDBOcA9WEnfLsEtY8F0t4JTnBVb9k5haWD8 wN7FyMkhIWAiMWvKMlYIW0ziwr31bF2MXBxCAqsZJaZsOMUI4TxklNj24TsjSJWwQJ5E59a9 LCC2iICmxPW/38G6mQUmMkusmaoGYgsJbGaU2P+HGcRmEzCU6D3aB9TLwcErYCex4E0OSJhF QFXi39G3YK2iAhESu64fALN5BQQlfky+BzaeU8BU4sPHQ2wgrcwC6hJTpuRCbBKXOHb/JiOE LS+xec1b5gmMgrOQdM9C6JiFpGMWko4FjCyrGLlSC4pz03OLjQqMNjECY3XbYa2AHYxN56IP MQpwMCrx8C547R4pxJpYVlyZe4hRgoNZSYSX56RHpBBvSmJlVWpRfnxRaU5q8SFGU6CHJjJL iSbnA9NIXkm8oYmlkYmBmZmhkYGxmZI474TALxFCAumJJanZqakFqUUwfUwcnFINjOraLdtS 7fV6fnebt/5UPPzxzvyPvE+E3NUmpJsEsb9k/ZKoct924aK19ZdfcEnM177Eb1Ov4P5/buSL 643/d5/e8Pqup6X26xnBC539nrNJv/Pw7v44Ic1lhnzX3+RawXjzUL2cv0JHz33xSLjxxoa9 yWQuP+PuH78uJZ8RK1wqqdmhUT4lWYmlOCPRUIu5qDgRAFiLyKTrAgAA X-MTR: 20000000000000000@CPGS X-CMS-MailID: 20170620103124epcas5p101ab71a61ba77627db126fc24046e7ab X-Msg-Generator: CA X-Sender-IP: 182.195.42.80 X-Local-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G+yCvOyEseyghOyekBtTZW5pb3IgU29mdHdhcmUgRW5naW5lZXI=?= X-Global-Sender: =?UTF-8?B?U3lsd2VzdGVyIE5hd3JvY2tpG1NSUE9MLUtlcm5lbCAoVFAp?= =?UTF-8?B?G1NhbXN1bmcgRWxlY3Ryb25pY3MbU2VuaW9yIFNvZnR3YXJlIEVuZ2luZWVy?= X-Sender-Code: =?UTF-8?B?QzEwG0VIURtDMTBDRDAyQ0QwMjczOTI=?= CMS-TYPE: 105P X-CMS-RootMailID: 20170614131847epcas3p4755a0ad1e25550134ddfcf0db9aff06b X-RootMTR: 20170614131847epcas3p4755a0ad1e25550134ddfcf0db9aff06b References: <20170614131828.28683-1-krzk@kernel.org> <20170614131828.28683-2-krzk@kernel.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/14/2017 03:18 PM, Krzysztof Kozlowski wrote: > When setting the pin function for external interrupts, the driver used > wrong IO memory address base. The pin function register is always under > pctl_base, not the eint_base. > > By updating wrong register, the external interrupts for chosen GPIO > would not work at all and some other GPIO might be configured to wrong > value. > > Platforms other than Exynos5433 should not be affected as eint_base > equals pctl_base in such case. > > Fixes: 8b1bd11c1f8f ("pinctrl: samsung: Add the support the multiple > IORESOURCE_MEM for one pin-bank") > Cc: > Reported-by: Tomasz Figa > Signed-off-by: Krzysztof Kozlowski I've tested this patch by comparing GPFx_CON register values, as nothing seems to be currently using pins from the GPF1...GPF5 banks as external interrupts on TM2, the only board based on Exynos5433. I changed sii8620 interrupt-parent temporarily to &gpf1 and GPF1_CON got configured properly with the patch and improperly without the patch. I guess this can be considered as Tested-by: Sylwester Nawrocki -- Thanks, Sylwester