From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CD0325A35E for ; Tue, 21 Oct 2025 01:58:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761011924; cv=none; b=o9xr7hNdxqIMV2Q9YGwY3LvfYI6YwylJvFdt2lrq3ca3Qw1CDSn+Ib+swJrYfErr7YdsLrjHW8CW2zuhZNUzm0Uv3I1WDwZ0HvdTr70//vAiUIZcDN1CTl+MDBGMtg3dvzZO43DREHeZ9X2kGxTJsOkVqOw6AUhYBi/VqB2KMUs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1761011924; c=relaxed/simple; bh=TaJ6Kpu5C42O4zfV+T1Ms1+yf77uSZazTk3VhrzJq24=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=FxB6zZLZqXtLm9eQNUg4PaGd6tRqXOJbNukLWCNrGwQoZ+KgP87oijlPwEHcRl8r5FXS9lcf9nG9dCGHpv2Q03BMrByO95D0XzDb164c1PwgQxc0FGK2l6wjYaakd1iF3i85Ua9RrP0W9cnVCKbXsclKYqUQHl0G5ON9t8/RxbE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=JXBsHQWP; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="JXBsHQWP" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 59KL0tUP029841 for ; Tue, 21 Oct 2025 01:58:42 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= TGwpn8/U0jGDBsJ9vOkeOjiPiuDIq8W2qVCHqYYf6sc=; b=JXBsHQWP/qTEPR9F aj4n17ekAa9v3b3yCN3CLVOyV9Y3CFau8yYJ5UxGlaWaVCHIzJUZiNECUDH8uvfu NMfAHF7EddZz90C3hfNCc8AQxdeBEKSapbVXxF4TZlUQJifc4T1/edYz/UyUh1q5 DRcydR/YamYHAJfLAjN1BwAgctF90VM8+41EECsk8Nozpv15KDy0lkJ8/1hpOVMZ vdGudTmveBsuKN/2trnGZvx4tU0N2thLNudNnyl4xj3eBse5VjcHYb4juEZPJoEc UpaomhHCr7Tnfi5Qg8pm9w4Uoeqk9iCTeFQUVZdrEjFORLuikPu3z++4sGr48i/m DmFi2Q== Received: from mail-pl1-f197.google.com (mail-pl1-f197.google.com [209.85.214.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 49v2gdxs6m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Tue, 21 Oct 2025 01:58:41 +0000 (GMT) Received: by mail-pl1-f197.google.com with SMTP id d9443c01a7336-286a252bfbfso134374075ad.3 for ; Mon, 20 Oct 2025 18:58:41 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1761011921; x=1761616721; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=TGwpn8/U0jGDBsJ9vOkeOjiPiuDIq8W2qVCHqYYf6sc=; b=QzdaHjskcaKLVYpH+9ULaridWBmWxyWtrvZR9KZMb02dEZhLUf4WKj/rwIvcwM3zdN 0Ntq94XPvzmyMnUQma22nrJHdPfgkDsrbGD3bwZGizMAYqQxNsZ48vb+H7aSVUtmUtMI mUYUDFvibdR0ZWx80qs4AkrapPkWAvwInAXA3yGrR3Y6KGtk9oHUnA5On3ACcMhgwynl 6ou9cINOx5gLCEf70AZ525XJAsFjuuU1aQ5+8HMn4OCfanY9bB9f4+e7MGqIvuM9zDGS gAWmpbGgx1ZOF+iCzYJ2mUveDfear4ek571nUOWLBAPGea2VU3PGHMVHYz0rM84xJViF YMYg== X-Forwarded-Encrypted: i=1; AJvYcCVwQOMI72wDomVtKe7z4wFEwWdYy37wzjIGC+ks/yGyLQh+PiIZeOhjNGZHJB/GWBrFpMjI/NNiLOLYPKc=@vger.kernel.org X-Gm-Message-State: AOJu0YzOacmQT0nbUG9+3uWdRifPJ5WdTTukGHMA+LFycERUt1uByWNW nh3e87pjDqrVX6PaUL45vJJiJMGf4MRO8y6Q1BYvTWfhwnPijapXenoxuuB8L0rnVzMbnOxzukD 0lM5Xv815ACxTkWmVadznQW15hO6x7lKxRLmTWU0hlhrEDSAYxYuLKnrV5wigPoRBJPg= X-Gm-Gg: ASbGncujDgk4Cj8uG8uE8vCXSCZyJy6XAggLmZcuK2unbQvZUvqrTJ4hDJlnrLqOvgW BG7zD+wzFARt7bFMK08FpvgRitIGvtFjn4IIk0blI5IYFq4OhOyTTOO9hUXkJdolRX5cDVVCjwq eGibEpmcp8ORlhqCRkLsJSk/z12ISXvCPoFSRh4RVMTH6P0EoXlorwaw9DyuBVGfrFThmETSbtA Ef1lcaf+K6MA3uF5yjiNUiVjvfKCxeAEhiFePGO5TBr0BGTb5dXj3pUB7filDe55aULYVRUkWaF zt8ipf70Fh0xTIR3E5dYEmfWekkEH05k+vAxdqfIv8Emy03217+FRTLY4z/qx7BeErmm+D3Ssb7 my4jnseSebdoJrJW5D4KD6bBKpqd7AaUZ860pDWnAwMPIlAooJhJdh49XKHqGYVfzviubGaoa X-Received: by 2002:a17:902:eccb:b0:278:9051:8e9c with SMTP id d9443c01a7336-290cb07a023mr215059255ad.42.1761011920710; Mon, 20 Oct 2025 18:58:40 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGTGO8LNhqSw5LRNEv7/Nl+bkPzCeoLUOMnBS6Q0IAq/GhPgb1srkEd6w74xcF3soP78u6rQQ== X-Received: by 2002:a17:902:eccb:b0:278:9051:8e9c with SMTP id d9443c01a7336-290cb07a023mr215058935ad.42.1761011920307; Mon, 20 Oct 2025 18:58:40 -0700 (PDT) Received: from ?IPV6:2405:201:c416:5052:e167:a6da:f5f1:b45? ([2405:201:c416:5052:e167:a6da:f5f1:b45]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-29246ec20a4sm93752155ad.7.2025.10.20.18.58.35 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Oct 2025 18:58:39 -0700 (PDT) Message-ID: <766890b0-099c-42e0-971c-cc94114c0d7a@oss.qualcomm.com> Date: Tue, 21 Oct 2025 07:28:04 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] dt-bindings: interconnect: document the RPMh Network-On-Chip interconnect in Kaanapali SoC To: Eugen Hristev , Konrad Dybcio , Jingyi Wang , Georgi Djakov , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, linux-pm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, aiqun.yu@oss.qualcomm.com, tingwei.zhang@oss.qualcomm.com, trilok.soni@oss.qualcomm.com, yijie.yang@oss.qualcomm.com References: <20250924-knp-interconnect-v1-0-4c822a72141c@oss.qualcomm.com> <20250924-knp-interconnect-v1-1-4c822a72141c@oss.qualcomm.com> <70569fdf-7a3a-495a-b1ca-d35ae1963592@oss.qualcomm.com> Content-Language: en-US From: Raviteja Laggyshetty In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMDE4MDAyMCBTYWx0ZWRfX90o8siZFOob5 f+Re+UAtN8MXBFlSUPfffovdITt0kqtHCTgDgSyOz5t4u3m6afKPX2WYPvhVcFCMDDVYgT5Kfhz Qn+lhXTDa/r8F69L5dNTeU3ZTSiUU0Hh3OZXJt08dw/YH7O8jShNC7o/5Sq8WDFvjUFVIJr4ZIv rz85PeY0peIlYSnzyec7jSJSYqx2a+ZtFk/94XulNolEm4MKmZrGd9qe/otSGWRHx0LrvNYdhYz MtjvjlBs0u/8bbQLpya2Ue3RT+NOMPneUF/AYMRrqlTdqe2zxN1vvyFXjcrntvW+nWeluB2rFre EQcshHX7C1lNQc5zKApwhpODX0DI1So6sJqr7GIxdEucTG5syWPGmOGzHINWKYmIh7fbDvCyD9w hgiCPQiA8hunHtrvm1qcTTr8BTKE6Q== X-Authority-Analysis: v=2.4 cv=KqFAGGWN c=1 sm=1 tr=0 ts=68f6e8d2 cx=c_pps a=cmESyDAEBpBGqyK7t0alAg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=x6icFKpwvdMA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=lx9-Q6l9dX336bKDy7QA:9 a=QEXdDO2ut3YA:10 a=1OuFwYUASf3TG4hYMiVC:22 a=HhbK4dLum7pmb74im6QT:22 X-Proofpoint-GUID: lrbXP3DyB16toV3JbrhX4GYq22O7-75j X-Proofpoint-ORIG-GUID: lrbXP3DyB16toV3JbrhX4GYq22O7-75j X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.80.40 definitions=2025-10-20_07,2025-10-13_01,2025-03-28_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 clxscore=1011 phishscore=0 malwarescore=0 impostorscore=0 lowpriorityscore=0 adultscore=0 priorityscore=1501 spamscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.19.0-2510020000 definitions=main-2510180020 On 9/30/2025 3:27 PM, Eugen Hristev wrote: > > > On 9/30/25 06:06, Raviteja Laggyshetty wrote: >> >> >> On 9/25/2025 6:10 PM, Konrad Dybcio wrote: >>> On 9/25/25 10:57 AM, Eugen Hristev wrote: >>>> >>>> >>>> On 9/25/25 02:02, Jingyi Wang wrote: >>>>> From: Raviteja Laggyshetty >>>>> >>>>> Document the RPMh Network-On-Chip Interconnect of the Kaanapali platform. >>>>> >>>>> Signed-off-by: Raviteja Laggyshetty >>>>> Signed-off-by: Jingyi Wang >>>>> --- >>> >>> [...] >>> >>>>> +properties: >>>>> + compatible: >>>>> + enum: >>>>> + - qcom,kaanapali-aggre-noc >>>> >>>> Hi, >>>> >>>> Does Kaanapali have a single aggre node, or there are several ? >>>> On previous SoC, I see there are two (aggre1 and aggre2). >>>> Also in your driver (second patch), I notice aggre1_noc and aggre2_noc . >>>> It would make sense to accurately describe here the hardware. >>> >>> They're physically separate >>> >> Yes, they are physically separate but the topology treats them as a single noc >> with two slave connections to system noc which you have noticed in the topology file. > > Is it any difference from previous sm8750 where there are two nodes ? > If yes, can you mention the difference and reasoning for merging them > into a single node. > If no, can you reason why the decision to merge them into a single node > this time instead of keeping it consistent ? >This is due to HW design issue. qxm_crypto port is on aggre1_noc and it's qos config is in aggre2_noc. Since aggre1_noc and aggre2_noc are separate devices they can not access intra address space. To access qxm_crypto qos combined agree1_noc, aggre2_noc into aggre_noc. Thanks, Raviteja. >> >> Thanks, >> Raviteja. >> >>> Konrad >