From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013053.outbound.protection.outlook.com [40.107.201.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1053339098E for ; Tue, 3 Mar 2026 06:43:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.53 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520212; cv=fail; b=jfGIZBAKV4qa7W/fW4MJQ+YcvF/wewH/cOAIEaP0gGQIVZ1CJx5UgCoUorLdvR0ATWERQeOQNQhvp59qpJ1B1R9gd7vHYno+C2Null/0rbLOxUGSCx9Nu2IDtScq+CoGsD3nGDv2jKzaEawS9vFPxIf5tvsiPRJJWar+sQn1ATQ= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772520212; c=relaxed/simple; bh=BnEGxV8z1lGzugwSM26TVaAXOw/uS65jjEk1gDcQLBY=; h=Message-ID:Date:MIME-Version:Subject:To:CC:References:From: In-Reply-To:Content-Type; b=KJ3sXna7Mbx4865zIqetCs4rrreizDzWrrIxjGfT9UZeOHmwg20sHkG9XjkaHJ8z9MEYUBAs/5MeKQ4naZT9nllA1QLHtL7LU2REtvhQ1fPJOgbhqk2N63mB8GqzC2UcU0OHpjwvNU3Zg//O8Wx1xMKg01gTSH4SgeIcxR7sOu8= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com; spf=fail smtp.mailfrom=amd.com; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b=MD/v06nG; arc=fail smtp.client-ip=40.107.201.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=amd.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=amd.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=amd.com header.i=@amd.com header.b="MD/v06nG" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CKKBJ96P9gltWkSbIhiPTr2ZjH6RIfW32Kr0bCRrCiJq+JHx/v9iG7jqNYKydlXdtEdAMSKP4PbDyiBXjU76WjjeeIJDXMfgyo7VlPT2EMlCrHWifQpE1yusf+7Li/GMENbIIZD7DEXcpagQYUWYR34n0D4+bIf2Ams9fcep6iNtAfcfTvQdl+xTz+SRMod5WcOhYhXexfrucGd08qzaF5BbPdrsqrxiaCDZ4fOF2fYPU8gv8TboqfC1gKZFGXjc9+/cEECoWnGZTgAxBejLleb9q9Yw34PVdUp3rYgR5YuKAYtBaKlN+nGI7yyaSGTPYW75jBqr1l6e8giymLbrYg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=YYOWXwvJQS01x1XsCQvF5AL8L0Z9B8OO+htx4o7COTY=; b=vFc1q+hob25Q30NuH4BiprrMhQL3Up5DigNYzi7AKUu40RxLaHtOSKNG+xC5UEExOooKHTQT2tGjBXnXvoTeggh+7Nf9D8qCH37XSRJmjg7DVJJfYztmt5s9EzyNWIskP6btT/ggT2xyLEjDb2KYlbxGF8DZxIokUE2atk3ryJYuxgbYcOgAdJW+w+LAk166KIMwueZawyXcW3qP9j6Ez6wlx2MLrp8N+4nZq4C4nKhmNfMbgJVZJyTh3aULVRa8Mv+NXgC0H6hyl43lO30UB9i3M5BLQonWwktqp9z88E5xt7HPUXv2AhEXx079pJ32hAW8Kc/fgDf5CmwEEovZNA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 165.204.84.17) smtp.rcpttodomain=gmail.com smtp.mailfrom=amd.com; dmarc=pass (p=quarantine sp=quarantine pct=100) action=none header.from=amd.com; dkim=none (message not signed); arc=none (0) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=YYOWXwvJQS01x1XsCQvF5AL8L0Z9B8OO+htx4o7COTY=; b=MD/v06nGBvYb5cjQcI8nidAwapemM1bYT5QKCVRPdX8+uBqkOft7+P2siti5L9Xc8l1dX0nIEw+ivUxDr/5Riex6PJ54waX8eoyrmGI1T2Az+MGwxDseAMmj+TSlUNtcslShlCRL+7JyQ6xgNhx4qxZGbMj0jihDNgKCdRJRctM= Received: from PH7P221CA0088.NAMP221.PROD.OUTLOOK.COM (2603:10b6:510:328::20) by MW6PR12MB8760.namprd12.prod.outlook.com (2603:10b6:303:23a::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9654.21; Tue, 3 Mar 2026 06:43:27 +0000 Received: from MW1PEPF00016159.namprd21.prod.outlook.com (2603:10b6:510:328:cafe::54) by PH7P221CA0088.outlook.office365.com (2603:10b6:510:328::20) with Microsoft SMTP Server (version=TLS1_3, cipher=TLS_AES_256_GCM_SHA384) id 15.20.9632.24 via Frontend Transport; Tue, 3 Mar 2026 06:43:21 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 165.204.84.17) smtp.mailfrom=amd.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=amd.com; Received-SPF: Pass (protection.outlook.com: domain of amd.com designates 165.204.84.17 as permitted sender) receiver=protection.outlook.com; client-ip=165.204.84.17; helo=satlexmb07.amd.com; pr=C Received: from satlexmb07.amd.com (165.204.84.17) by MW1PEPF00016159.mail.protection.outlook.com (10.167.249.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.0 via Frontend Transport; Tue, 3 Mar 2026 06:43:26 +0000 Received: from SATLEXMB06.amd.com (10.181.40.147) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.2.2562.17; Tue, 3 Mar 2026 00:43:23 -0600 Received: from satlexmb07.amd.com (10.181.42.216) by SATLEXMB06.amd.com (10.181.40.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.39; Tue, 3 Mar 2026 00:43:23 -0600 Received: from [10.136.33.80] (10.180.168.240) by satlexmb07.amd.com (10.181.42.216) with Microsoft SMTP Server id 15.2.2562.17 via Frontend Transport; Tue, 3 Mar 2026 00:43:20 -0600 Message-ID: <766cb80f-0f38-4258-89e8-a07a6c065d88@amd.com> Date: Tue, 3 Mar 2026 12:13:14 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] sched/proxy_exec: Handle sched_delayed owner in find_proxy_task() To: CC: zhidao su , , "John Stultz" , Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot , Dietmar Eggemann , Steven Rostedt , Ben Segall , "Mel Gorman" , Valentin Schneider References: <20260302101235.3988601-1-soolaugust@gmail.com> <20260303063007.125383-1-soolaugust@gmail.com> Content-Language: en-US From: K Prateek Nayak In-Reply-To: <20260303063007.125383-1-soolaugust@gmail.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: MW1PEPF00016159:EE_|MW6PR12MB8760:EE_ X-MS-Office365-Filtering-Correlation-Id: 7532efb4-edd6-4bb3-7244-08de78f02c5a X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|7416014|82310400026|36860700013|1800799024|7053199007; X-Microsoft-Antispam-Message-Info: XIzky7nx/lj8uwmX61t/Elm66Sp9CqGSCt83xTz4v0lTPt7nEt3UmsII49kLkLpI1XEDRKFz0G0n5/Ov9PlsLKHyQFhm7EpUl6un4o9qeMQoQLOAYF/fETb1NGf2BBl95uQmiwCKRAQ+QtUn8AB9d3zb4YGsOgCm7MI3U44ifCdj+Z4vbQ3B3dU5N2T41Af7LYSNUjpSLrnvzG4D+upOe61uMPnquLfdx5LwfWcSoAxdwm1w18aceAivBeZilKTPI+XwbM6W83vwz01SSAy2u5XJKZ0GBV87tdxs+P4HSbKEHmX3yLvbhu40TqGFVGAm9PvwLn5BoKFio9F3NEDHlgULgYSJoFfcnRrZvrlzBYD0AT36G9PWRDXQjhDqU4JbZM3WUzSR8arI3YJq3igabq0FIsJ/oVodXhj96lpE6RDT9BpNfGCS0sFczSlhWWc3Gz1XrgC4iVFkcGQKbEFeY1NrXcRBNezoLqG5oTEknO3RbSa7RDWxzdS3l/+Xgkh6DdnYtsMICGtLO05C2LhkGyNnpX8EPHKynPCIWrlGpLHotmacI1wcLFsVx7nZzrkF2JRqOTvboL5pDVXDFbz+pgluHNaDjgUB4KNOrkcl58aad3SgQAA5AYDVF0rIGKlhvg62jk9NDXlN+TnRtPhqXD7b1/GtIbXVb7Ft/2PkHxb9SvzR63qDomdXzLwxz9H6ZeKAtIhyeVk2Bw+3zRqwSDTfKE/A4lNnhZHCiHs4VHXe3dZ3kAheorV8g6JZy5cKZ/4K2ZHdigQZbxlAT/Fh8SlBP3Bef91+HdVeMkabQgoStl/muW425Ns99OhBAwh0ZIYd4ow7mSAZkrlvxIxu9A== X-Forefront-Antispam-Report: CIP:165.204.84.17;CTRY:US;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:satlexmb07.amd.com;PTR:InfoDomainNonexistent;CAT:NONE;SFS:(13230040)(376014)(7416014)(82310400026)(36860700013)(1800799024)(7053199007);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: NfKFMJklAWKBW8axy4WjU2/REVb2GxSdPhwtwF5ZkFcn9Ki0izqlMFcdDXsNSFj9usz+dgoQx9C+ECSDguy41HxEyt0+BK2cJHJhlZXxwf9vsvvAnB84YFZJkFYC9cLa6EzamBD9KTmiXLa4rIf7ZQZIHvd3ICLyFDIxC00lf13kBT8nMJ91NPEOH0YBVg6iP5crzzccZCFdM7mgUA111GYm+AOV1PCb1JbzBMcHofa4cwtX+smsY0/zS8Bpm7qYDDrjqypPXIv5To8rw5LM+WZVgMtKoqH7v8n2Kivn3U2zkPy3M3fBYN7Z2xrSR8+vHlkrkiYKVBDQtez2pJpxUCD3vsk7EatL0QqT/tfuo3hg9n79WTRiYOQ7yf8Hv91/utM8vij6VuAfxXVMPx+OuNXCiYPMS+CGtmJHAnO0c1Pl/4ESxv3ujzNmIk6/CQ7N X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Mar 2026 06:43:26.4002 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 7532efb4-edd6-4bb3-7244-08de78f02c5a X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=3dd8961f-e488-4e60-8e11-a82d994e183d;Ip=[165.204.84.17];Helo=[satlexmb07.amd.com] X-MS-Exchange-CrossTenant-AuthSource: MW1PEPF00016159.namprd21.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8760 Hello Zhidao, On 3/3/2026 12:00 PM, soolaugust@gmail.com wrote: > Right. I'll send a v2 that keeps the two checks as separate blocks > (the conceptual distinction is worth preserving for when the blocked- > owner series lands), but uses proxy_deactivate() for both: > > if (!READ_ONCE(owner->on_rq)) { > return proxy_deactivate(rq, donor); > } > if (owner->se.sched_delayed) { > /* > * Owner is in EEVDF deferred-dequeue: still physically on > * the runqueue but has called schedule(). A sched_delayed > * task never has blocked_on set, so the chain cannot be > * followed further. Deactivate the donor for now; proper > * handling will come with the blocked-owner series. > * > * XXX: Don't handle sched_delayed owners yet. > */ > return proxy_deactivate(rq, donor); > } > > The comment replaces the shared "XXX" with per-case rationale, making > it clearer why they are handled differently once proper support lands. > > Does that work, or would you prefer the two conditions be collapsed > back into one? I suppose we can expand on that comment but all of this will go away soon(ish) anyways. Do we need to modify it? I'll let John, Peter answer what they think is best. Personally, I feel the current transient comment is good enough indicating that it'll be handled with the upcoming changes similar to owner on remote CPU. -- Thanks and Regards, Prateek