Re: [PATCH v2 0/3] media: iris: Add support for SM8750 (VPU v3.5)

[Dikshita Agarwal <quic_dikshita@quicinc.com>]

On 8/12/2025 1:29 PM, Krzysztof Kozlowski wrote:
> On 12/08/2025 09:52, Dikshita Agarwal wrote:
>>>
>>> v4l2-compliance report:
>>>
>>> v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t
>>> v4l2-compliance SHA: 4aee01a02792 2023-12-12 21:40:38
>>>
>>
>> Thank you for running the v4l2 compliance tests with your patches. While
>> these tests are helpful for verifying API compliance, they do not cover the
>> actual functional aspects of the new SOC support being added.
>>
>> Please run a decoder use-case using either v4l2-ctl or GStreamer (GST) and
>> add the results in this cover letter.
> You did not provide such details on your submission:
> https://lore.kernel.org/all/20250704-iris-video-encoder-v1-0-b6ce24e273cf@quicinc.com/

I have mentioned in my series that I have used both v4l2-ctl and GStreamer
(GST) for encoder testing, in addition to running v4l2-compliance. That is
what I am asking you to do as well.

Your cover letter only mentions v4l2-compliance, which does not verify the
actual functionality of the driver.

As a maintainer, I believe it is my responsibility to ensure that anyone
enabling support for any SoC with this driver has tested its basic
functionality. Please note, my intention is not to block anyone’s patches.

To clarify, I am not asking you to provide any test reports. If you have
already tested this series with v4l2-ctl or GST, please just mention it in
your cover letter.

Thanks,
Dikshita
> 
> so asking others of this is just unfair and unjustified obstacle. If you
> have technical comments, then share. If you are just making fake
> obstacles to stop some patchset then refrain from commenting.
> 
> Unless you want statement like:
> 
> 
> All patches have been tested with v4l2-compliance, v4l2-ctl and
> Gstreamer on SM8750.
> 
> Then I can give you such statement, just like you did for your patchset:
> 
> All patches have been tested with v4l2-compliance, v4l2-ctl and
> Gstreamer on SM8750.
> 
> Best regards,
> Krzysztof