From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 199E12C3257 for ; Wed, 28 Jan 2026 10:17:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769595480; cv=none; b=jvG+w6GVRDbQ3Zgr5MAkBTUKQaqgaTuHrZmD5Foxd7rZ006Nunvi4dttnpHlbwERwyP6sxbhXBWhNutPsyuqeVz7m9gOx8GggCMkQgug8rnYtyBI2JNKlMfVFQxo5gjGTVOKWgf6gc1LMg7Lf8Fip9b/kwJ3Luc8GlEDZ0F/3mk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1769595480; c=relaxed/simple; bh=O/9goh1xSkb+EelmdQyLMFXz3I6q3HEZ87LSkbwQDO8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=UMWKvw/WrUzR8wy8Dc2rXr+5fhPs7A2fNRj9rokKhmwYCemoZYByS1mo1p+MYPa0pytjm5tKT7/uoOaKfTf/LnG7CXJw8odyELG6kZmPSBoGX4LgfxZgQR/cocSMg+p7k8CbgWKohvYi62Yv5c6SnlufUD68gEBUM/kmG4LhZ1Q= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=YKfkAlOd; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=Pr15GL2i; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="YKfkAlOd"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="Pr15GL2i" Received: from pps.filterd (m0279872.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 60S91svL3879174 for ; Wed, 28 Jan 2026 10:17:58 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= Tf6LbgXp6mx4YhJ03WWvmUBkFvoGm+ZEEuhHUmxDhQ0=; b=YKfkAlOdB4K4dkw/ jQj0bvXGC+96ZvYcX3PmCzj4SDFe8SQ/jvEqUzlYKTZwZvcvlyfdK00EMm1CmGCA klByM14Dab+YvGD1C4W5iXLTS+70AAXqLnLaudSt6LGMq07ubvZbipzOBzgoA0vJ p4wHG/YWAT2HJPWF5OrwlQfuM43No8KwOI+WXS58nh5Fu8BEqp2OWPAaOgldN/aC gphSPvDsV8Co7dl+1STUPlbHTz3ZLrzUl5fypa78TrAG2lFUvdWzKyewI92f1gnH W4V+7aVHWRKpD0tmAkp9u3aVfYbxa5eL7fBZfI6RfLX+5seAAp2wu37ofc7MFkGE Yb99eQ== Received: from mail-qk1-f197.google.com (mail-qk1-f197.google.com [209.85.222.197]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4bybyv10qc-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 28 Jan 2026 10:17:58 +0000 (GMT) Received: by mail-qk1-f197.google.com with SMTP id af79cd13be357-8b2fdf3a190so107857885a.0 for ; Wed, 28 Jan 2026 02:17:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1769595477; x=1770200277; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Tf6LbgXp6mx4YhJ03WWvmUBkFvoGm+ZEEuhHUmxDhQ0=; b=Pr15GL2iVNYwlA71Biu7Bqy16gUDHIAT+vri1sLwewxR/+2jYK05xdb2/KZZOmBj/H TFv96erADr49x8PE/CrLz7vcA45WSh+4GRuPRGMwRXTtvOFjnZXpayfY8b1ruClUYVIy 7zipfZAZk8tWz8lh7stTAZi0bZdhVhhER0g5jKqbEC0zNg8PGqOn/Pdi3+82o8GBogqO L+NLSMWBHkqDBlNATz8S7A9PS3ko2YWjHaX8hE4bdCmMLFakoyuN8cYVK9TicpQUfO+V p0Tp9pcQzl/xvNpLFbdYB0VjgzaeS/Q0prcmE/GY1D7+duh9z8euhnsJ3OteXi8Z8LJx eRSA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1769595477; x=1770200277; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Tf6LbgXp6mx4YhJ03WWvmUBkFvoGm+ZEEuhHUmxDhQ0=; b=lwEvVq+YU3Qdsj6ZLexFCSEtQgzcVV//OXDJrcMeip5D/JI/wwl1RSEchXiEXnrEJp JLQBN/8xVFHA7HERcXSqGP6wSufEm4wDKKb1HUfz9/qZyJOeBNDu1BXaCAGcgmFBBObt 6TYUNFDRbqUYDRTt0A13kapf09czS7GFH75KHCHNH/RoaI1jesUBW/lxKGKOkyIMDye/ KQ4mAL65p5tDY+DWykefBBiD1fv/PyAHtv8MrUDE/9VuBYIe3D7wlQapSg0XPDKT6zw3 nZW5msTAVoYYeSl07IeYIx8sVqg1FNbiIIiBCcNbeAfSvubAs94FodjdcjaVhyjcyRba h7gQ== X-Forwarded-Encrypted: i=1; AJvYcCUYsxyJqwNZ4znsv/qmIwA85p8cnokBk4LxDpf8qKDW3NWBEonra4PLeIvtDn7Y7ZPbrVY67zaE7Q70qek=@vger.kernel.org X-Gm-Message-State: AOJu0Yzri6C5KxoqGgMgnK+/4qav/T9Egeet3DnlbM2f6pU8eupbgJNR zV8JBuneGqZdYk6XlAgxEuBk/o0BB0cgzhjeHqb7bp6y4HRq6MO/c9WovyupmYuGv88cDgALPwY 5MZjmKXnz40ZwO1tSmeZ53DB6ydvdtiie31w4tqAZGR6/m9Fue0+x2Zd7LKP1T2z2Qr0= X-Gm-Gg: AZuq6aKxCOHik86nxGU3m1fsvMK+kXeqezvWOeJ6x0xe0nrjgi+DSIMMSOfoA+G69Ku pz6by3jATsv3RzXg3O2Jbln7WX1aAeza8qL7fn8rox8RkT+TlBYx89FDT+/YrzWv+f9ce7drbgN 4qcxeCDnAp8krG+sSz8L6JcpmsCPiiTj/8yiV6p0/N8rhC90sk7Ud9JUSKw6uC+wEH4BYD16VTS aXN2Wgci2Ws8xW3+PyP0sEG4jfaeDCa9nYjWN5EvpQi53YE0hoN03MlC5D1SBUupbui9zgtn9O6 /qdhI84ec++reSNfXxNE7RCE2sMa1Cu4ysjoIPgZM/pTgUk6rnrahJZFcewJfxq2ZM3jOaSmI6K DDvtGAgkdcA8KdHznsiDkKFuVEpOdJZqk3UcNAVvl/R/J53Veof4MSss7iGOh2bC75lU= X-Received: by 2002:a05:620a:2982:b0:8c7:eb2:1c3a with SMTP id af79cd13be357-8c714b45365mr125364185a.1.1769595477535; Wed, 28 Jan 2026 02:17:57 -0800 (PST) X-Received: by 2002:a05:620a:2982:b0:8c7:eb2:1c3a with SMTP id af79cd13be357-8c714b45365mr125361085a.1.1769595477011; Wed, 28 Jan 2026 02:17:57 -0800 (PST) Received: from [192.168.119.254] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8dbf185214sm111600266b.45.2026.01.28.02.17.52 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 28 Jan 2026 02:17:55 -0800 (PST) Message-ID: <76763847-e5f2-484a-9ff6-dab5906bdaaa@oss.qualcomm.com> Date: Wed, 28 Jan 2026 11:17:44 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 5/8] clk: qcom: camcc-x1p42100: Add support for camera clock controller To: Jagadeesh Kona , Bjorn Andersson , Michael Turquette , Stephen Boyd , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jagadeesh Kona , Bryan O'Donoghue , Konrad Dybcio Cc: Ajit Pandey , Imran Shaik , Taniya Das , linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260128-purwa-videocc-camcc-v1-0-b23de57df5ba@oss.qualcomm.com> <20260128-purwa-videocc-camcc-v1-5-b23de57df5ba@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260128-purwa-videocc-camcc-v1-5-b23de57df5ba@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: J7iIaTgUR98dNTxcozdWGACluFJs17bc X-Authority-Analysis: v=2.4 cv=ZZ4Q98VA c=1 sm=1 tr=0 ts=6979e256 cx=c_pps a=50t2pK5VMbmlHzFWWp8p/g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=vUbySO9Y5rIA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=zb7rluFiWWGZWzxfGAMA:9 a=QEXdDO2ut3YA:10 a=IoWCM6iH3mJn3m4BftBB:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwMTI4MDA4NCBTYWx0ZWRfX7oLTdOwplSqT TgfOla91pR4PJcpHH/qGkPfOukE9bMFufZavhSAu7LcE2EGakcrWLGv9m0QKrfPa+1zkGai6UCt gaMTR6U5pkIMvQlcx6PTTCEx46vKanEEHfsEW457kPge867xQ1elaWmevcJ7hwk9ZrGy1hW+XX7 ZZtBe4A/p/2RXSaWEaPfVxSPH3ygf/V3XJsmU2rzLwssJ6RshKHPYp2KElrgKywFEWQ9/6mFEod PJey4cS07d+6WnnabqxNdsMt8kV7xqaFaoBh0g640F6bqva0zqXqMBR6PTwHtau5QC6lbPn3H83 LgoGoR/Qyd82+4WnjZ0X0QVExyrds2civ+dNeoGjl+tZJa37c5I7ma1xa2g8Nk8GNuymRltNY7t XlU7HykIYAHYCEzvc+VK1yj+PeO50ewFUVP1GSq06khz572VtvH/62YHS/dOIX5f/94HOeqhFLa x57tGnRgb72NhiuQIxQ== X-Proofpoint-ORIG-GUID: J7iIaTgUR98dNTxcozdWGACluFJs17bc X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.51,FMLib:17.12.100.49 definitions=2026-01-28_02,2026-01-27_03,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 adultscore=0 lowpriorityscore=0 malwarescore=0 clxscore=1015 impostorscore=0 suspectscore=0 priorityscore=1501 phishscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2601150000 definitions=main-2601280084 On 1/27/26 8:26 PM, Jagadeesh Kona wrote: > Add support for the camera clock controller for camera clients to > be able to request for camcc clocks on X1P42100 platform. > > Signed-off-by: Jagadeesh Kona > --- [...] > +#include I have mixed feelings. Purwa lacks sfe_0, pll7, pll8, ife_1 clocks and all their supporting infrastructure. All other clocks seem to indeed be common. Perhaps it's not that bad given it's a strict subset and they have a shared DT The driver itself looks OK So Reviewed-by: Konrad Dybcio Konrad