From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31168375F81 for ; Mon, 29 Jun 2026 14:08:10 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782742092; cv=none; b=H2cyI/nlSDuIjFto52PVrOLBl7pa75D+ebn0zmaYje+YYEt+lLY5Rxnu3Fw27w6LldZP6LG/dRMgSipZ8arH6Lr2ai7haxhxL8WJg1IYt1Aqw8zIHwI9aMK6DXjx38v/HjV5ScPXusdDhUVxZdpsJHd7TEix1m2sjZmBdmfuVJU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1782742092; c=relaxed/simple; bh=dURMrnEE+8FNs3YuqCUX3g5zorhiCWR/1suAQkUacBw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=V/7aRNmuzWe69dZGJh/8YhQ7jnnJdhL50BUYSeclu2mytyPyO6n+6ShLtnMcyOBVV4HRBwuZ5p8bgUeJS7G/jmVlNyqPf5Xq4TzC6toR6xiUdqbq5bZOtCAR3lZ713MDeoLu0pW+avWsWQBVfPYDBpsFFWvgIn5WEBP4chuCItA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=mGAf+QEB; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=L8ZqI4hL; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="mGAf+QEB"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="L8ZqI4hL" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65TATBPI2647661 for ; Mon, 29 Jun 2026 14:08:09 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 29BbeCyRbqbccdqjchaSDPUWm7nWe/b0cApw/MAp8LI=; b=mGAf+QEB/iir+kCh P3E5qXLKQFPxq+r4EGx8J9emeMdynqNE2UsDG6rqIYtivg7o4773EPFkD0gxpU7G 6sTK+8uUUaV3Ygy6qCZtPz4rBnMTRJnoD0evLk5zGY20YA3xy66z0+dz57N/OPka Zkbsr74mf5JSjjo3+k/YSoQt2YHdQBuLXN+xnydoU9wfe4cnXd6r07SK5Lu1da7p DvdQxODAGB40uSIltSiCRgRD0+mza3ua+62dbeCzZJXP/vQO221WBBWCZxnhOZEx SLuEXEP575Q7Ud9SnWpDjPtSGuYkgMmFOwnPWhQ2ZTaL8aDnxHJBwicEzP95/vGs n08y2Q== Received: from mail-pg1-f200.google.com (mail-pg1-f200.google.com [209.85.215.200]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4f3kyjhn0e-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 29 Jun 2026 14:08:08 +0000 (GMT) Received: by mail-pg1-f200.google.com with SMTP id 41be03b00d2f7-c8895156101so1490865a12.1 for ; Mon, 29 Jun 2026 07:08:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1782742087; x=1783346887; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=29BbeCyRbqbccdqjchaSDPUWm7nWe/b0cApw/MAp8LI=; b=L8ZqI4hLvIcV7bdg22E7D/94d2ar2yap+6ueBJcn4S7xtS8Bf2w72sdLsXLkR94yJ5 HUm02J8/ed6YmZs9Ac9ME8H9MMg9/nsDUfEhIWx7PUA/rcq0e0d8lI4r9AFKN0uXBjyK D7dQRKfdR5KArqa5hnooAp4O7v0LyUQHboUh7pbmSJExuByf6tUsgnrVCjcbcoBM0EdM X8mNTIWjMG5++RKVWoyXmWcYiLCVFfGn8qln4FegsSme1jy70I0q0dRe3RtPpxIOq6Jp ab8+15DTtv9m3QD1KkVmA6aOc0HC3yNyYK1J8Miv9xw6T3VwvRrF53R0UyATMLEBTNDg jMSQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1782742087; x=1783346887; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=29BbeCyRbqbccdqjchaSDPUWm7nWe/b0cApw/MAp8LI=; b=ZX15KN5moqvZKtg5lSRheR4Zc/GFE35jgmOjrhB/gXTU6d8u2UDj4TB1i7lwVcE0AP l8HnHLvgJe1uwsJZX4aIMuyQDEsHv0S/pVwCmAFF2NmuOphmXEJiSnVPrprQTuCN6dXK 2/u24YInKvkzXoDuhPZetl6KYc6SRNDY+WHRbqCnuYUgX6PYf4urBJQoeYwiJst+0gNE f/7fi20r/ck2OLcH+mHjDV13f7noSq3bUHfTFNQ2v5JRS51zaFjCZMlz9zT9LUY+vsyL 3xKaJf7KQ6BjVTBmFBGCC5RjAwNBVhWAGuCM4UgixV1BQO7WgqrjMtd2BCR7A8T5sTzv Gr0g== X-Forwarded-Encrypted: i=1; AHgh+Rq1V81O43HWh/QwAUQam/Tkmgd+lrTvmyn8912RkNPFumz/Hnb0x6f+nzJUQ0siaJ0wHNUd5Q+0GCqmUb4=@vger.kernel.org X-Gm-Message-State: AOJu0YzXV1U5/Ov6thZH0CPetis3HQ990jrSGqxwbq41rUlFBnUiFBRR SZHTYnqHNO+ycxuDSWdLY6DCES9zii1dlJO22Fqz+hXBCJKxhwp3OIu8xjPR+WaOFQWY8jizGyI 9yT26g2BzuByBOFSOZJfEGE/Uzb6ItaEK9kunWD80fPOc770k6I7BIizhrjRhze2dZHCXoOZQUo U= X-Gm-Gg: AfdE7clziWRw+cHxOuW2yqbnHMwaHFtjXkJn0cM1wITGBiozu6Ic8PZ7TpwOclWoUO0 EPUf3j4gl0XES0QT1/3GdDEvhyCJKvgGhT1VzteRng81eFjOpa8kYaJOpspQTDsukoVbtbW5k9R ErMTuSFAZWgGrdRKXBRNf9MiQ10JKU1RefCnzlXsy7Zm9Ef26k9tHRy1dj8s+fiTi5ySjH+of4n FBFQPiPg7tQDg8M/YUOGw/4sZGWCCUvBsEssMhIi9Qhx6lmLlHJJ8W2qbaegKW37BTTvuRt5rGP p3zNirNqRYCcHSZj9ir8h47abQFaF+GipGhlVlfG0aQX898HacNxJ0BtXN+q57syuHrz+tBxBPm sPLIc99i7osiu3JyuEs+iHDyYDTKKTdY969GFSWi2/YVS9Qgg8CQvmepLoqU1NJ4dWyOW1twL/Q == X-Received: by 2002:a17:90a:d007:b0:36d:8e49:d8 with SMTP id 98e67ed59e1d1-37dfa1cf815mr13778701a91.15.1782742087298; Mon, 29 Jun 2026 07:08:07 -0700 (PDT) X-Received: by 2002:a17:90a:d007:b0:36d:8e49:d8 with SMTP id 98e67ed59e1d1-37dfa1cf815mr13778685a91.15.1782742086832; Mon, 29 Jun 2026 07:08:06 -0700 (PDT) Received: from ?IPV6:2401:4900:1f29:f628:449f:9d99:35eb:4741? ([2401:4900:1f29:f628:449f:9d99:35eb:4741]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-37df3b657b3sm9224552a91.15.2026.06.29.07.08.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 29 Jun 2026 07:08:06 -0700 (PDT) Message-ID: <767b5d6a-ed4c-4cd3-bcbf-44c4f24325af@oss.qualcomm.com> Date: Mon, 29 Jun 2026 19:38:00 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] platform: arm64: qcom-hamoa-ec: Register cooling devices with their name To: Konrad Dybcio , Sibi Sankar , Hans de Goede , =?UTF-8?Q?Ilpo_J=C3=A4rvinen?= , Bryan O'Donoghue , Dmitry Baryshkov , Maya Matuszczyk Cc: linux-arm-msm@vger.kernel.org, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260629-fix_cooling_device_register-v1-1-c6e518b0bbd4@oss.qualcomm.com> Content-Language: en-US From: Anvesh Jain P In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 3d24PTWG3oN5mfFkdVscQPWUhkNWN5l1 X-Proofpoint-ORIG-GUID: 3d24PTWG3oN5mfFkdVscQPWUhkNWN5l1 X-Authority-Analysis: v=2.4 cv=Ftk1OWrq c=1 sm=1 tr=0 ts=6a427c48 cx=c_pps a=oF/VQ+ItUULfLr/lQ2/icg==:117 a=xqWC_Br6kY4A:10 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=VwQbUJbxAAAA:8 a=sTVR4Ors8kAh6zT4N6oA:9 a=QEXdDO2ut3YA:10 a=3WC7DwWrALyhR5TkjVHa:22 X-Proofpoint-Spam-Info: AW1haW4tMjYwNjI5MDExNyBTYWx0ZWRfX7gSKvfYeNxcF WoEMkPGHgV+3GitlUv5/dVdVpAJGBQZJ/MPR042cYimPFMmrBJwbLrsx7zVa86iG4t7mx0c+Sct YnAqenGNiuabvUXRLfnYX3rxBea7Koo= X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjI5MDExNyBTYWx0ZWRfX2GfmHDnbSld+ CrTgiKja3PkZNWTunGKVc18giYEKX2AwyDhgII6aDMFMpcU6LrGruHBwlMOUB6TN7shBvHutAiC hROjKWKFXoiHYoEPLmL+SHkdlrh8PsAotco1tg1vyCcn00YwiRHJNKd5cDmWz3ils2pCvH1vpDg r0eh6fZYPB/szCfP4aRPb98DB1GsNkuTKZblf0/d/TzPXkZYRriTt7fgRJFGFBpsb3kxTCqGVfN +K2uWMMkj4Xs+S+4mEE5u5+IfDGR7ZEJhzr4Tsmyl1QPMksJGFXVPu5+nVF0ORONUKSC0Ax0SUH G03zvbgLs0AIls8tX6KQwMR0MQw1Lcfek+yd+aUgW7IeTTx2nExZ/oQKDG/dDB9z6zDxahqCj5Z 8GtUvlF90/jZgry54whJVvNWjOcE88Et5KcKJbhlcynxmU+5htSr2b61YUHaABlwAyzGKlgeEBy TBeZHLcGYQWK7mnRKWg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-29_03,2026-06-26_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 adultscore=0 suspectscore=0 phishscore=0 priorityscore=1501 malwarescore=0 spamscore=0 clxscore=1015 bulkscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606290117 On 6/29/2026 4:51 PM, Konrad Dybcio wrote: > On 6/29/26 11:16 AM, Anvesh Jain P wrote: >> Each fan is registered as a thermal cooling device using >> devm_thermal_of_cooling_device_register(). When the thermal core gained >> cooling device ID support, the helper's prototype changed: its second >> argument became a 'u32 cdev_id' and its third a 'const char *type', >> replacing the previous 'struct device_node *np'. >> >> The resulting semantic conflict between the EC driver and the reworked >> thermal helper was resolved while merging the drivers-x86 tree into >> linux-next by passing NULL as the 'type' argument, dropping the per-fan >> 'name' string. As a result every fan is registered as a cooling device >> with an empty name. >> >> Pass 'name' as the 'type' argument so the cooling devices are registered >> with their intended "qcom_ec_fan_" names. >> >> Fixes: 5c44f48e91de ("platform: arm64: Add driver for EC found on Qualcomm reference devices") >> Signed-off-by: Anvesh Jain P >> --- >> drivers/platform/arm64/qcom-hamoa-ec.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/platform/arm64/qcom-hamoa-ec.c b/drivers/platform/arm64/qcom-hamoa-ec.c >> index 45829f2786b7..12196d56b60e 100644 >> --- a/drivers/platform/arm64/qcom-hamoa-ec.c >> +++ b/drivers/platform/arm64/qcom-hamoa-ec.c >> @@ -391,7 +391,7 @@ static int qcom_ec_probe(struct i2c_client *client) >> ec_cdev->fan_id = i + 1; >> ec_cdev->parent_dev = dev; >> >> - ec_cdev->cdev = devm_thermal_of_cooling_device_register(dev, 0, NULL, ec_cdev, > > This seems to have been altered to use: > > devm_thermal_of_child_cooling_device_register() > > apparently as part of: > > f31c00c377cc ("Merge tag 'platform-drivers-x86-v7.2-1' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86") > > Konrad You're right, thanks. That merge switched to devm_thermal_of_child_cooling_device_register(dev, NULL, name, ...), which already passes 'name'. The issue no longer exists in current linux-next, so I'll drop this patch. -- Best Regards, Anvesh