mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Reinette Chatre <reinette.chatre@intel.com>
To: "tan.shaopeng@fujitsu.com" <tan.shaopeng@fujitsu.com>
Cc: Fenghua Yu <fenghua.yu@intel.com>, Shuah Khan <shuah@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-kselftest@vger.kernel.org"
	<linux-kselftest@vger.kernel.org>
Subject: Re: [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using kselftest framework
Date: Mon, 6 Dec 2021 07:23:20 -0800	[thread overview]
Message-ID: <768fbe83-91e8-abee-02e8-aa5505f48fdb@intel.com> (raw)
In-Reply-To: <TYAPR01MB63309592B2B82329246319878B6D9@TYAPR01MB6330.jpnprd01.prod.outlook.com>

Hi Shaopeng Tan,

On 12/5/2021 10:57 PM, tan.shaopeng@fujitsu.com wrote:
> I will separate the part about default limited time to a new patch.
> In order to get some opinions about change default limited time,
> I will add a description in the cover letter,
> when posting the next version of this patch.

When you submit the next version, could you please change the order so 
that current patch 3/3 becomes 1/3? If I understand correctly, without 
the SIGTERM fix, the test would just hang if run from the kselftest 
framework. It would be better to have SIGTERM handled before attempting 
to run with the framework to ensure things keep working smoothly.

Thank you very much.

Reinette

  reply	other threads:[~2021-12-06 15:44 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-10  9:33 [PATCH 0/3] selftests/resctrl: Add resctrl_tests into kselftest set Shaopeng Tan
2021-11-10  9:33 ` [PATCH 1/3] selftests/resctrl: Make resctrl_tests run using kselftest framework Shaopeng Tan
2021-11-29 19:27   ` Reinette Chatre
2021-12-01  2:36     ` tan.shaopeng
2021-12-02  0:18       ` Reinette Chatre
2021-12-03  7:21         ` tan.shaopeng
2021-12-03 23:08           ` Reinette Chatre
2021-12-06  6:57             ` tan.shaopeng
2021-12-06 15:23               ` Reinette Chatre [this message]
2021-11-10  9:33 ` [PATCH 2/3] selftests/resctrl: Return KSFT_SKIP(4) if resctrl filessystem is not supported or resctrl is not run as root Shaopeng Tan
2021-11-29 19:27   ` Reinette Chatre
2021-12-01  2:36     ` tan.shaopeng
2021-12-02  0:39       ` Reinette Chatre
2021-11-10  9:33 ` [PATCH 3/3] selftests/resctrl: Kill the child process created by fork() when the SIGTERM signal comes Shaopeng Tan
2021-11-24 11:00 ` [PATCH 0/3] selftests/resctrl: Add resctrl_tests into kselftest set tan.shaopeng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=768fbe83-91e8-abee-02e8-aa5505f48fdb@intel.com \
    --to=reinette.chatre@intel.com \
    --cc=fenghua.yu@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-kselftest@vger.kernel.org \
    --cc=shuah@kernel.org \
    --cc=tan.shaopeng@fujitsu.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®