From: Kamalesh Babulal <kamalesh.babulal@oracle.com>
To: Kai Huang <kai.huang@intel.com>, cgroups@vger.kernel.org
Cc: tj@kernel.org, hannes@cmpxchg.org, lizefan.x@bytedance.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] misc_cgroup: Fix the obsolete comment around 'struct misc_res'
Date: Mon, 24 Jul 2023 19:14:05 +0530 [thread overview]
Message-ID: <7690e7b2-6e7f-6ff1-5249-72f497f82f7e@oracle.com> (raw)
In-Reply-To: <20230724115425.1452383-1-kai.huang@intel.com>
On 7/24/23 17:24, Kai Huang wrote:
> The comment of the 'failed' member of 'struct misc_res' is obsolete
> since commit b03357528fd9 ("misc_cgroup: remove error log to avoid log
> flood"), which removed the 'failed' member from the structure. Remove
> the obsolete comment.
>
> Also add the missing comment for the 'events' field, which should come
> with commit f279294b3293 ("misc_cgroup: introduce misc.events to count
> failures") where the 'events' member was added.
This has been fixed by:
https://lore.kernel.org/lkml/20230718090834.1829191-1-kamalesh.babulal@oracle.com/
>
> Signed-off-by: Kai Huang <kai.huang@intel.com>
> ---
> include/linux/misc_cgroup.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/misc_cgroup.h b/include/linux/misc_cgroup.h
> index c238207d1615..41aa213a1125 100644
> --- a/include/linux/misc_cgroup.h
> +++ b/include/linux/misc_cgroup.h
> @@ -31,7 +31,7 @@ struct misc_cg;
> * struct misc_res: Per cgroup per misc type resource
> * @max: Maximum limit on the resource.
> * @usage: Current usage of the resource.
> - * @failed: True if charged failed for the resource in a cgroup.
> + * @events: Charge failure event counter of the resource.
> */
> struct misc_res {
> unsigned long max;
>
> base-commit: 3f01e9fed8454dcd89727016c3e5b2fbb8f8e50c
--
Thanks,
Kamalesh
next prev parent reply other threads:[~2023-07-24 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-24 11:54 Kai Huang
2023-07-24 13:44 ` Kamalesh Babulal [this message]
2023-07-24 22:17 ` Huang, Kai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7690e7b2-6e7f-6ff1-5249-72f497f82f7e@oracle.com \
--to=kamalesh.babulal@oracle.com \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=kai.huang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizefan.x@bytedance.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®