From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Rosen Penev <rosenp@gmail.com>, netdev@vger.kernel.org
Cc: Felix Fietkau <nbd@nbd.name>, Sean Wang <sean.wang@mediatek.com>,
Mark Lee <Mark-MC.Lee@mediatek.com>,
Lorenzo Bianconi <lorenzo@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora.com>,
"open list:ARM/Mediatek SoC support"
<linux-kernel@vger.kernel.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-arm-kernel@lists.infradead.org>,
"moderated list:ARM/Mediatek SoC support"
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH] net: mtk_eth_soc: use ethtool_puts
Date: Fri, 11 Oct 2024 22:17:59 +0200 [thread overview]
Message-ID: <769f3405-9905-4a26-ba8a-baf30e591f54@engleder-embedded.com> (raw)
In-Reply-To: <20241011200225.7403-1-rosenp@gmail.com>
On 11.10.24 22:02, Rosen Penev wrote:
> Allows simplifying get_strings and avoids manual pointer manipulation.
>
> Tested on Belkin RT1800.
>
> Signed-off-by: Rosen Penev <rosenp@gmail.com>
> ---
> drivers/net/ethernet/mediatek/mtk_eth_soc.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/net/ethernet/mediatek/mtk_eth_soc.c b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> index 9aaaaa2a27dc..6d93f64f8748 100644
> --- a/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> +++ b/drivers/net/ethernet/mediatek/mtk_eth_soc.c
> @@ -4328,10 +4328,8 @@ static void mtk_get_strings(struct net_device *dev, u32 stringset, u8 *data)
> case ETH_SS_STATS: {
> struct mtk_mac *mac = netdev_priv(dev);
>
> - for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++) {
> - memcpy(data, mtk_ethtool_stats[i].str, ETH_GSTRING_LEN);
> - data += ETH_GSTRING_LEN;
> - }
> + for (i = 0; i < ARRAY_SIZE(mtk_ethtool_stats); i++)
> + ethtool_puts(&data, mtk_ethtool_stats[i].str);
Reviewed-by: Gerhard Engleder <gerhard@engleder-embedded.com>
next prev parent reply other threads:[~2024-10-11 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-11 20:02 Rosen Penev
2024-10-11 20:17 ` Gerhard Engleder [this message]
2024-10-15 1:10 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=769f3405-9905-4a26-ba8a-baf30e591f54@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=Mark-MC.Lee@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=lorenzo@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=rosenp@gmail.com \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®