mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jonathan Brassow <jbrassow@redhat.com>
To: device-mapper development <dm-devel@redhat.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [dm-devel] [PATCH -next] dm: dm-log-userspace depends on NET
Date: Fri, 19 Jun 2009 13:31:39 -0500	[thread overview]
Message-ID: <76DA7CFF-D6C7-44C3-BEC6-B7FDC6577B74@redhat.com> (raw)
In-Reply-To: <4A3BCD0D.3010801@oracle.com>

Thanks, I've pulled this into my patch.

  brassow

On Jun 19, 2009, at 12:38 PM, Randy Dunlap wrote:

> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> DM_LOG_USERSPACE selects CONNECTOR, but when NET is not enabled,  
> this is
> useless and the build fails, so make DM_LOG_USERSPACE depend on NET.
>
> ERROR: "netlink_has_listeners" [drivers/connector/cn.ko] undefined!
> ERROR: "proc_net_fops_create" [drivers/connector/cn.ko] undefined!
> ERROR: "netlink_kernel_create" [drivers/connector/cn.ko] undefined!
> ERROR: "proc_net_remove" [drivers/connector/cn.ko] undefined!
> ERROR: "netlink_kernel_release" [drivers/connector/cn.ko] undefined!
> ERROR: "init_net" [drivers/connector/cn.ko] undefined!
> ERROR: "__alloc_skb" [drivers/connector/cn.ko] undefined!
> ERROR: "netlink_broadcast" [drivers/connector/cn.ko] undefined!
> ERROR: "kfree_skb" [drivers/connector/cn.ko] undefined!
> ERROR: "skb_put" [drivers/connector/cn.ko] undefined!
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> Cc: Jonathan Brassow <dm-devel@redhat.com>
> Cc: dm-devel@redhat.com
> ---
> drivers/md/Kconfig |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- linux-next-20090619.orig/drivers/md/Kconfig
> +++ linux-next-20090619/drivers/md/Kconfig
> @@ -233,7 +233,7 @@ config DM_MIRROR
>
> config DM_LOG_USERSPACE
> 	tristate "Mirror userspace logging (EXPERIMENTAL)"
> -	depends on DM_MIRROR && EXPERIMENTAL
> +	depends on DM_MIRROR && EXPERIMENTAL && NET
> 	select CONNECTOR
> 	---help---
> 	  The userspace logging module provides a mechanism for
>
>
>
> -- 
> ~Randy
> LPC 2009, Sept. 23-25, Portland, Oregon
> http://linuxplumbersconf.org/2009/
>
> --
> dm-devel mailing list
> dm-devel@redhat.com
> https://www.redhat.com/mailman/listinfo/dm-devel


  reply	other threads:[~2009-06-19 18:34 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-19  7:26 linux-next: Tree for June 19 Stephen Rothwell
2009-06-19 13:44 ` Nico -telmich- Schottelius
2009-06-19 17:38 ` [PATCH -next] dm: dm-log-userspace depends on NET Randy Dunlap
2009-06-19 18:31   ` Jonathan Brassow [this message]
2009-06-19 18:24 ` [PATCH -next] dm: fix dm-log-userspace printk format Randy Dunlap
2009-06-19 18:32   ` [dm-devel] " Jonathan Brassow
2009-06-20  4:16 ` linux-next: Tree for June 19 Len Brown
2009-06-20  5:04   ` Stephen Rothwell
2009-06-20  5:12     ` Stephen Rothwell
2009-06-20 18:27     ` Len Brown
2009-06-21 15:54       ` Stephen Rothwell
2009-06-29  5:25         ` Stephen Rothwell
2009-06-29  7:14         ` Ingo Molnar
2009-06-29  7:30           ` Stephen Rothwell
2009-06-23  6:34       ` Len Brown
2009-06-23  8:54         ` Stephen Rothwell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76DA7CFF-D6C7-44C3-BEC6-B7FDC6577B74@redhat.com \
    --to=jbrassow@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=dm-devel@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®