From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 036ECE7D26C for ; Tue, 26 Sep 2023 09:24:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234157AbjIZJYJ (ORCPT ); Tue, 26 Sep 2023 05:24:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39186 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233738AbjIZJYF (ORCPT ); Tue, 26 Sep 2023 05:24:05 -0400 Received: from madras.collabora.co.uk (madras.collabora.co.uk [46.235.227.172]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id F01D211D for ; Tue, 26 Sep 2023 02:23:58 -0700 (PDT) Received: from [192.168.1.100] (2-237-20-237.ip236.fastwebnet.it [2.237.20.237]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) (Authenticated sender: kholk11) by madras.collabora.co.uk (Postfix) with ESMTPSA id 658506607314; Tue, 26 Sep 2023 10:23:57 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=collabora.com; s=mail; t=1695720237; bh=ssfuBNR2PiLxi4TiFV2ZqSR5SVdNJLkRo9oKlebvEQw=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=cW7c5jDhuls+mD3trL29q7HBQecBadZb/c5mpADXdcWpqI8ThH4gxcTynR9pfijsn k8uzNX3PnxUosg3jnhKiIeavFp0n0rvvh5cbh1hOV4LQKjSphvtWRXE4hth75i/BHD 0SM54hofqzMoZ+qawxCSI8q7r+B6oRWSCwQOcnJiDUAEcX4abp7AL/8J1qYXJ2mg9q aL2KIZnALoJcI+CU8KwJRUVGSNCLd+BgsjlR9U2d6/vT3PpzPI2RexgfVNu/SnZJ9I inQkm1TB+za1aXFbUlggJRz1b7uU7I0/Sh27IDbfAm8tPy3/CK9uo33J5PgN33w8Iw 8zoZS46BiX1fw== Message-ID: <76a36e77-ac58-c156-131c-0c471565502a@collabora.com> Date: Tue, 26 Sep 2023 11:23:55 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.15.0 Subject: Re: [PATCH 14/40] soc/mediatek: mtk-devapc: Convert to platform remove callback returning void Content-Language: en-US To: =?UTF-8?Q?Uwe_Kleine-K=c3=b6nig?= , Matthias Brugger Cc: linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, kernel@pengutronix.de References: <20230925095532.1984344-1-u.kleine-koenig@pengutronix.de> <20230925095532.1984344-15-u.kleine-koenig@pengutronix.de> From: AngeloGioacchino Del Regno In-Reply-To: <20230925095532.1984344-15-u.kleine-koenig@pengutronix.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Il 25/09/23 11:55, Uwe Kleine-König ha scritto: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new() which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > Trivially convert this driver from always returning zero in the remove > callback to the void returning variant. > > Signed-off-by: Uwe Kleine-König Reviewed-by: AngeloGioacchino Del Regno