From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754781AbcFTNzR (ORCPT ); Mon, 20 Jun 2016 09:55:17 -0400 Received: from mail-bn1on0096.outbound.protection.outlook.com ([157.56.110.96]:33304 "EHLO na01-bn1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S932625AbcFTNyU (ORCPT ); Mon, 20 Jun 2016 09:54:20 -0400 Authentication-Results: spf=pass (sender IP is 63.163.107.225) smtp.mailfrom=sandisk.com; vger.kernel.org; dkim=none (message not signed) header.d=none;vger.kernel.org; dmarc=bestguesspass action=none header.from=sandisk.com; X-AuditID: ac160c71-a17ff70000000efe-db-5767f47e8696 Subject: Re: [PATCH] scsi: libfc: fix seconds_since_last_reset calculation To: Arnd Bergmann , Vasu Dev , "James E.J. Bottomley" , "Martin K. Petersen" References: <20160617154737.633440-1-arnd@arndb.de> CC: , , , From: Bart Van Assche Message-ID: <76a47d73-26e2-5a9f-7a03-21c72ca613ca@sandisk.com> Date: Mon, 20 Jun 2016 15:54:06 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160617154737.633440-1-arnd@arndb.de> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42JZI8azSLfpS3q4Qc96Dou/k46xW9xYtIzJ YtXEPIvLu+awWXRf38Fmsfz4PyaLrav+sFtc6VrJ5MDh8fvXJEaPxXteMnk8OLSZxeP2v8fM Hp1P1jN7fHx6i8Xj8ya5APYoLpuU1JzMstQifbsEroxbR00KmpgrrjbPYGpgPMrUxcjBISFg IrFgeWoXIxeHkMBcJokb3++ydzFyAjk7GCWaL+qC2CA1+67fY4coWsoocfjZTDaQhLCAl8Th jjtsIAkRgZWMEitWbWaF6DaWeH/6MzPIBmaBColVb8EGsQkYSXx7P5MFxOYVsJO4eaAHbBmL gKrE8g3bwGxRgQiJ3l9LoGoEJU7OfAJmcwIdsWruVyaIkfYSD7aWgYSZBeQltr+dwwxygoTA VVaJ140zmCFOUJc4uWQ+0wRG4VlIRs1CaJ+FpH0BI/MqRrHczJzi3PTUAkMTveLEvJTM4my9 5PzcTYyQOCrcwfj6tvchRgEORiUeXouzaeFCrIllxZW5hxglOJiVRHhrP6aHC/GmJFZWpRbl xxeV5qQWH2KU5mBREue9GP0xTEggPbEkNTs1tSC1CCbLxMEp1cBoKvogeuuHH2o77h9jePv/ qf2Ww+ExX808Yw5071+VtLND8GU2J0Pgre/+LOLvJp25ta5sR/FS8aQP1ddnukSs69U2ZVEO Y/Q4Lj85W73S53nvkwnJNw9sXD5h6jWmEoO0fYtm7A8K3FWzZrvHFs907tO5v1wmMJqtirGf 1PJnfat95Lb9Skl1SizFGYmGWsxFxYkAmI8B458CAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmplluLIzCtJLcpLzFFi42Lh2siRotv6NT3c4P9ibou/k46xW9xYtIzJ YtXEPIvLu+awWXRf38Fmsfz4PyaLrav+sFtc6VrJ5MDh8fvXJEaPxXteMnk8OLSZxeP2v8fM Hp1P1jN7fHx6i8Xj8ya5APYoLpuU1JzMstQifbsEroxbR00KmpgrrjbPYGpgPMrUxcjJISFg IrHv+j12EFtIYDGjxP6VOSC2sICXxOGOO2xdjFwcIgIrGSWuLd/OBlFkLPH+9GdmEJtZoECi YUoX2CA2ASOJb+9nsoDYvAJ2EjcP9IANZRFQlVi+YRuYLSoQIdH7awlUjaDEyZlPwGxOoCNW zf3KBDHTVuLO3N1Q8+Ultr+dwzyBkW8WkpZZSMpmISlbwMi8ilEsNzOnODc9s8DQSK84MS8l szhbLzk/dxMjOKA5o3YwXp9ofoiRiYNTqoExVVHhAQ9v4sIdUfxfS3L+O57n63cPDN/w0IVr wbTFxSGW853OmOsmb9spZl3XJX6G16bnjrHVl++nS6y3OMWc2isvvsLb9jurrFPKGzXDSXMO Mcv42eS92B3XMOVQ8Yp3OcG5q3l7sv+pWJ5vX9rFuP1Bp4FmaZxhBItazMu5hdsXh9dPO6rE UpyRaKjFXFScCADLQelOGAIAAA== X-EOPAttributedMessage: 0 X-Forefront-Antispam-Report: CIP:63.163.107.225;IPV:NLI;CTRY:US;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(438002)(377454003)(199003)(24454002)(189002)(6806005)(86362001)(87936001)(33646002)(23746002)(2906002)(64126003)(4001350100001)(50986999)(68736007)(76176999)(54356999)(4326007)(50466002)(356003)(11100500001)(189998001)(53416004)(97736004)(5001770100001)(106466001)(7846002)(36756003)(2950100001)(92566002)(31686004)(5003600100002)(77096005)(31696002)(69596002)(81166006)(8936002)(2270400002)(8676002)(81156014)(586003)(47776003)(83506001)(65956001)(65806001)(230700001)(65826006);DIR:OUT;SFP:1101;SCL:1;SRVR:DM2PR02MB527;H:milsmgep14.sandisk.com;FPR:;SPF:Pass;PTR:InfoDomainNonexistent;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;BY2FFO11OLC003;1:2LlZ0q6Daj5b7sjU6Wy+XGv5Ln6t5fS8YcnufsHflbb1ekkzbuHl1PREk+96goxlPvkNQQdcQdCc/rSSfaMBbYXmkxkcmZbaqBpiKNNb9E4RQw3gssz905XULNT5eC8lGkOOuO1lktyXsp0JlQ7YmmGtuIt0GnonwICgzPOZFMaW+r51A9kxT+7XW8Y9hlL9/o3d9CITD3S7SAAugXB0DHQmLh0SvNczmOF49KnkG2IViM5FddqgEszq7VYNDZhkPVESGcGoc6LQqQn6Dipm5axTKpbxGQuz0dMQF1aiYp2XFkrj0w3sEfDVbLj/g+xfFF7Ybfw5lvpURjGLGk2w4AK/dRtR5u1eoqLaGlmzIchC35tfVomhj7m4uGmzmmd4MC54NjlM6j/oeggQASvha/Nt9J9VY64dVgUdQ5nQJe18pAl3C1AbtQncUmsj9VMQyhTVKpdBFjxPyiSpz+G+Qq77Pfc1DpZIUgIcXeWxpLH37fRsNEHQRCtnt9gIbaPY X-MS-Office365-Filtering-Correlation-Id: 89e08335-9189-4906-55f6-08d399125ed6 X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB527;2:l85FE2I9pbtVVAkhcWvWDnJLHPqA4+gz2JvjdER4GhTdt2XEfZIHw90QqIosCRyywRZtee5wes+OPY3t9lJ9b8g8oSz7ZWzchVRy1aMIifvUc/2VgTppyQHGHY/x4EM/nai6Ly/Ed2nawnrc+SbFVn5IoCJFZyLUh9mJ91e+ALw1JJgb8GzuLXAW3S7S4XZC;3:LhVILRyuf4sVx7FV5Oh/cpXgaJDvZ8/QqA46nehj3YatEFO3nqev9fUj0sGIgRSokAtM02AWbqPTe+A4kG2Fj/iqvoiYJLSyizMOq7uk9R09CkOcw7F50llfCFjiCmymtF/+KSlCbQCeEwnD0xFwrnILR26KMJpcFYZOduCDjSg/wg46/kuO6PiOmtdO/H3oN5+i7c7ssFixerZG016J93jTNOpFEXq9a2gdHRBI+pj9C4scr2xMTKs5pIgCfQ05JeQlwH563jP1skPeDaSnFQ==;25:SNoztIOIF3PUlXdNtDgTrnTwmbhwp8pemRlqFjxWWb1oCwtpV/LJLIPH5rTWhgg5et9SNc6n4ttxfIjwstCU6/xrN9R5g8S3UmOawVjgJCx3EibRR2tIEit7sUEATvIFJv79jTySJ/INn/w+OWN3/hd3DEdz4oEbJ0oWhf/Slh7yqKSWk6JjGFlwOksYNZCnZDEhcZrYFNdPMKgSQFyocUqAg3K0O5GYcFDiDu8npwu2BVGd93ejDCOMSiiG+jvecS3Yh92zaPMb2MbmQK/DPBF30mjoZojpp7ZBBNDshrMgMJEKeapgzhJdA1wUi7CN6XvUZ/R8cHQNBtQpKNXSI803jYuocxqq3qLg3G3/3dUd0E0CFhsZZw/T/xbQvrFMkveCVrZZWIs/qSjJaQc012t1g6MLP7U7UWy/yhMvMMo= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(8251501002);SRVR:DM2PR02MB527; X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB527;20:e6aL3/+3ljzWTc2X4A443woXhNaRkMK+txe1bSylw/lHpIrI5fp5eKYujfRViFgb04EYHAQG2E3neVRpxPUMimOyMcMqDpOLvIj713Lpj1RanGJSko7as4LMdBpta20csqkTLif397sdegzoOeFPOgLwz2fzuJzJ6fZ/w03yBlfJkV8kdKejsdQnOBz1DNLvmWmMzpLAQGFPT9aZsuioDZx1nsoClBmQ+Eh6Zg0nQDBOJqylJK9KJxEbP7eher++Vg4U4M+loHSriQSHIlh6u8UUxdM+3dDrBFgR2IsyomFLrFep3r9G9XoRBQko/G1KwKqlimT2qZTk2PHcgS5zqZkisbWuQDqU2ON00LdNjPEHHI185N6vzt+xJjcf/Ncm/6SbKqmzxmQDK3/XxvRaRZ0aMAXzEFmecCII/CX9HcDRMIilSKGG2A+EcYL1v2aGfWi5NAaDaWwvvdWXO2f3F8cYE946t4GakZiN9gS2v2OtyZ6nwhsDJbxKpZyO9mXQ;4:lHTThPAddSmFpfoLMTtIKsI6MT19dHqPQoDxxItyvxr8io1pVKoJ8zSyLB46OOdjnprdT8K1oTRX684YSCeWOth3BekDgVuoiQguoKBVP3IHS+FuQX79baBNywG9AEXD2AWtks0L0a9CS6JRVqiV5RnhBt9zmfHEJOCuDRiBQdYB7GVq5zIjHKzKutx8yZXnx8U2BMeNWrhX3CTr/2EaLyEnFRGa7aNJKFX5VLvf/RmS1yHQpu6LSt1Cabn0+nFUiS78e2S48wqH/8OMeqyoJkAeajT1hPK3by1Nf/3o0LmAvXwNULMM/pRV3W9m6h2hKsp4DXN8gxseFOaKs8E9pQRBUIKCq1H9lf3eusBtaoKJJNZCUXNd9qzXe8arlZgZX4IYvhlVL/Ph0ecQKdc35tFeyOBkeRgCs4JVl6umiQc= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(2401047)(13016025)(13018025)(5005006)(8121501046)(10201501046)(3002001)(6055026);SRVR:DM2PR02MB527;BCL:0;PCL:0;RULEID:;SRVR:DM2PR02MB527; X-Forefront-PRVS: 09796A1B83 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1;DM2PR02MB527;23:na5tGtD4bl+vxaA3RYHEKJXgL/5wdLQiQNyjsq?= =?Windows-1252?Q?1a0iX8LEwm2AmQhSmUqi/g/WBVKTNbvOTBQf990wLKnS4QxsghAPpStu?= =?Windows-1252?Q?hVR7sRud8vhS4frCtwpO59nZ1cz57BRIKD51LURKItyg6WP6ZgscFiJv?= =?Windows-1252?Q?od/q6rnRw4xmY2YvY/gq4QeG/KZC4LAsGmvA7gLfxFoT0cZ/qTPd05nl?= =?Windows-1252?Q?QN8sYi3TZbc+3WtzIjHL+BujoreDcOGuTf5leW++f7rLhu8ubOk6EJTi?= =?Windows-1252?Q?wrSq8OTOZ1UjCutGSzuPErUUT/cK+6PpPbFyzWJVzIskPjlPQ/F0dfgV?= =?Windows-1252?Q?WbzpOoImImsl1DcYn3rkUTcBUugYSBzruDG9QuNbGjTDZb2hXaw2gwTn?= =?Windows-1252?Q?GYGvIlbHJaATtFRiLuJBk6Q1vxBdUzWD1zqWCIuRFM7LOv5E2kMKf3DO?= =?Windows-1252?Q?JMii4g+X6bL4Tpev/r1PggHDxJzORvB7aXkPvyFbJ6TrDt12LHXla+qj?= =?Windows-1252?Q?2KBU1hAGfQhmY1HeT+ZEE4T3qGiRTA6Loql7gOZF1z21zUPfiPFGvGSv?= =?Windows-1252?Q?kj4hk0cOjHHlUzGBADsl+/jVRmFGXgCDrWrJthL7CYKof0XbbMdK5nFr?= =?Windows-1252?Q?iuDcnq4/yD3lZuughbRplGSpGa7lD088qgjXzF/zwQXe+qcUBmCIvU3d?= =?Windows-1252?Q?vpTHow78Pbtk7rmRbdTjjvYazTOdDiyVQ1XpD5eVSmaYsKPSFMowd23U?= =?Windows-1252?Q?ZURZkTfLStw287R3+XV0BvnMQGD9L3V+V5/p3PhFZBpNoELDQPgNsBTO?= =?Windows-1252?Q?FcCixOslep6s/zi7qtMATGgMpAEqJOsXNAXAXCRpN8s8uJJPw7nCxUo8?= =?Windows-1252?Q?M4dWlNGDQSm/9Cb0iF0kwde18GB0071Zzo9gUCPEzVH3zOINOJDRA9ES?= =?Windows-1252?Q?jpN26SU6iGwQ8PcE2KDYnWnZbRjNpazfHUmOL20oAfURhl00bg6sMcFy?= =?Windows-1252?Q?ufBQEBLAEaHFMRRw4ynwTCQdbys/Ae/YsYyQ49loRr8B+dYt4XU2JVrd?= =?Windows-1252?Q?e5fynBRrbJEhJtGBLrWKvJNNk0gBTIGYCUK8y5gGhxoYsDKmZKCFDwE2?= =?Windows-1252?Q?Mik9ww+iGJqaZFaulz5a6gSbnfl5Jt3i/F8kSWX6x6Wt++rVOmmJJuSh?= =?Windows-1252?Q?HZZByRMpvGFjfLgM6t2eOMrB0/HQj4ohU+kvCDppC2GVvZCk8b/SbIIo?= =?Windows-1252?Q?Cg365dln+ko9zxfzr0ubhwFdgPFLZymVTfiErxHS0mu6lMy5nSpXV/G9?= =?Windows-1252?Q?gM?= X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB527;6:QYjhCxlK/fpg5tyh0SIzyCi8/Jsb+bjj5IjyD5jgOnhvCL1wmOg7VaWDX21lPa5TLYlXQkuqBITeSl/QExnPSzkc95+iByZ7LqjuWGKU3RgBTAAKC/pTnm8vRvZhVzzdD2RSFZ4jTNOdTMf3a5xvQUtS82ummBfwXgV2Lrn+n7Wwue6edVW3Ps8kiEOT0glgjFi9NqOO/qNnZPHPIOsrLlfxfKAg4PIjNM/weeQzl2TOiYThQKGZ5RtxHpWQxOV8XZcJcrTKptqAn7BYbAz2CfW2589xncRhgycs52q7z1Lh7Bmn2Y6kvnV22fMGx12Y+gpXsZPcrbyRTzFlszxEMg==;5:H9v/MpP2ewZJntzJDgzfo1VJdrqiSig+5krRcwsUqF3Apk43L3w56+XgM6OJmP4HjblFmC2GWMOXitXVTimbXszIIbitTXAJWz63eAdx9PdqCz3vDxO7bbxR2PXssDJQwHkXizR6FmnxdrI6JBJzyQ==;24:sTwmVdW2TkFzqOiZn6XMmIA3aUIXt0a49s8drZTNjWz/gERRO3eO0Lf80jOS4ZWOQQ5s+zGSMqXc+E2l8jaEPqz8QAIGlFTV9EfCU9GYN2U=;7:KPZV3gj/0eOCizxXwgY4y2Bw/vSjdMPehzwxeL8kMiyvjX7ZsjsuFo/ut29NkjydeWjJ/5hpnWEShFu8YUCk9lF2nsIrqrcN/FTRL4XMDxtgLMkuHCZU+aXfpij/RJkpcGBXq1HiqaUgMkPNCYCCDt52CvGBYQ4+0tfmsovobPoVGW//DDVPwgM8t3W6hbE5YD2iineZ6UY6IYoP26EcsL6OJ3FtMHSMSMyHqU623oxWrFf9f/E1/ZDUq7YyFy+K SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DM2PR02MB527;20:YvEcYcuJvCFCL3VUh7cRhaCfkSBOQIRWAn7LHHs3tcth/duC4m+GjsAE6ZsncIGINVsAHwXzjZeGaFsCoeuFxEDh3+D6ZdZvGryQqmBpOiXqG7HRNCsEKk+tRpYd9FfuP40HbSjMwRvgX+ayJsFwtX8R1a34YSOpr5CYtR5GhIj2x//MJ7y8cpF3h6EYAB3pP30zEXHzZnO37X/ddCcdsEnEtDXmUQVdS90MWW1w91IVMmgtoEBY8J34+R4dkyIK X-OriginatorOrg: sandisk.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2016 13:54:16.8313 (UTC) X-MS-Exchange-CrossTenant-Id: fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=fcd9ea9c-ae8c-460c-ab3c-3db42d7ac64d;Ip=[63.163.107.225];Helo=[milsmgep14.sandisk.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM2PR02MB527 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 06/17/2016 05:47 PM, Arnd Bergmann wrote: > - jiffies_to_timespec(jiffies, &v0); > - jiffies_to_timespec(lport->boot_time, &v1); > - fc_stats->seconds_since_last_reset = (v0.tv_sec - v1.tv_sec); > + fc_stats->seconds_since_last_reset = (lport->boot_time - jiffies) / HZ; Does this patch introduce a 64-bit division? There might still be 32-bit users of this code. Bart.