From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DAD41C48BD1 for ; Thu, 10 Jun 2021 21:12:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF92D61263 for ; Thu, 10 Jun 2021 21:12:25 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230484AbhFJVOQ (ORCPT ); Thu, 10 Jun 2021 17:14:16 -0400 Received: from youngberry.canonical.com ([91.189.89.112]:36201 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229963AbhFJVOO (ORCPT ); Thu, 10 Jun 2021 17:14:14 -0400 Received: from mail-wr1-f72.google.com ([209.85.221.72]) by youngberry.canonical.com with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.93) (envelope-from ) id 1lrRyK-0006On-G6 for linux-kernel@vger.kernel.org; Thu, 10 Jun 2021 21:12:16 +0000 Received: by mail-wr1-f72.google.com with SMTP id t14-20020adfe44e0000b029011851efa802so1538623wrm.11 for ; Thu, 10 Jun 2021 14:12:16 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=DYrEI1CPfZmySk6cY9J0ohXCN4+Mz5LA/y5DlhALlNg=; b=CoaDc3Lq70cQt7+BKrCEc11TWFFd8YVG/iyj9nfRSpqV2088kf3v8meaUv/8KEoJrt aIckCPoBZItdDAcPopHcGB+tfGEFpeMjYPUgWbbc6itWf5HkAYgqoXibaZ8RyFJ6VyCF AltXnym2y6iMrgGGF8aA4VNFd1LyGMcGDrmf8DtjLCXcvOdCIazKOvMGMzxqBYYXh8sV BQKHq7VQZYTEuvbm2PnZr0Pjkp0emLxmF6A3LH6TfJCaWouJH3LWCp4mLIQP7a5b8tWB 6vEcyhdsRJdh1rVE82+aCFl0WiBhmIe7HEzH+Hje+yVUAVRN6VRmDv5jSiCZGLbPSCsS EzHQ== X-Gm-Message-State: AOAM532lQbKSCfeBeu4tCwWYC/NUt21ollRo9UWlaXsyZV8uoEwZktRV 36pH6h4rNsjnH/lRqBoQCQl7fP2O7pZEqZ7jA/4zIVC6OgEUsgis5tHR4CYfv+frARlq+3DRf3D TamFmI9Ty9VhvtS4d4DyIn4GvmLdzYVffW/VR5qTIvQ== X-Received: by 2002:a5d:64c7:: with SMTP id f7mr419984wri.36.1623359536226; Thu, 10 Jun 2021 14:12:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx688A9cV+dEt1NvDmIjm1lap6cMqZBXZgUyNwhXCx9GAk5LyRDHaiwPttV7/4KtyMfj0W9sQ== X-Received: by 2002:a5d:64c7:: with SMTP id f7mr419956wri.36.1623359535971; Thu, 10 Jun 2021 14:12:15 -0700 (PDT) Received: from [192.168.1.115] (xdsl-188-155-177-222.adslplus.ch. [188.155.177.222]) by smtp.gmail.com with ESMTPSA id t66sm4005724wma.41.2021.06.10.14.12.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 10 Jun 2021 14:12:13 -0700 (PDT) Subject: Re: [PATCH v23 08/18] dt-binding: memory: pl353-smc: Enhance the description of the reg property To: Miquel Raynal , Rob Herring Cc: Richard Weinberger , Vignesh Raghavendra , Tudor Ambarus , linux-mtd@lists.infradead.org, devicetree@vger.kernel.org, Michal Simek , Naga Sureshkumar Relli , Amit Kumar Mahapatra , Thomas Petazzoni , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, helmut.grohne@intenta.de, Srinivas Goud , Siva Durga Prasad Paladugu References: <20210610082040.2075611-1-miquel.raynal@bootlin.com> <20210610082040.2075611-9-miquel.raynal@bootlin.com> <20210610155345.GA1873816@robh.at.kernel.org> <20210610180107.1cc889f3@xps13> From: Krzysztof Kozlowski Message-ID: <76a94eb1-170a-307d-e1ce-1080a7af6a0a@canonical.com> Date: Thu, 10 Jun 2021 23:12:12 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: <20210610180107.1cc889f3@xps13> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/06/2021 18:01, Miquel Raynal wrote: > Hi Rob, Krzysztof, > > Rob Herring wrote on Thu, 10 Jun 2021 10:53:45 -0500: > >> On Thu, Jun 10, 2021 at 10:20:30AM +0200, Miquel Raynal wrote: >>> The SMC bus controller features several register sets. The one pointed >>> by the reg property is for the SMC configuration (impacts the >>> sub-controllers configuration), while the others are meant to be used to >>> send regular cycles on the memory bus (eg. CMD, ADDR, DATA for a NAND >>> device). Detail this a little bit for the sake of clarity. >>> >>> Signed-off-by: Miquel Raynal >>> --- >>> .../devicetree/bindings/memory-controllers/pl353-smc.txt | 3 ++- >>> 1 file changed, 2 insertions(+), 1 deletion(-) >>> >>> diff --git a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>> index ecd46856f139..ba6a5426f62b 100644 >>> --- a/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>> +++ b/Documentation/devicetree/bindings/memory-controllers/pl353-smc.txt >>> @@ -5,7 +5,8 @@ of memory interfaces: NAND and memory mapped interfaces (such as SRAM or NOR). >>> >>> Required properties: >>> - compatible : Should be "arm,pl353-smc-r2p1", "arm,primecell". >>> -- reg : Controller registers map and length. >>> +- reg : SMC controller and sub-controllers configuration >>> + registers. >> >> I think you could just drop this patch. Otherwise, this doesn't match >> what's now in the yaml file. > > Fine. > > Krzysztof, if it's still time you can just take patch 9 which Rob > just acked and forget about this one. I think we'll be good. Otherwise > that will be for the next MW ;) I skipped this one but took dtschema (9/18) so it should be in tomorrow's linux-next. Best regards, Krzysztof