Re: [PATCH] kernel: cpu: hotplug: constify attribute_group structures.

[Arvind Yadav <arvind.yadav.cs@gmail.com>]

Hi Sebastian,


On Monday 10 July 2017 12:44 PM, Sebastian Andrzej Siewior wrote:
> On 2017-06-29 17:40:47 [+0530], Arvind Yadav wrote:
>> attribute_groups are not supposed to change at runtime. All functions
>> working with attribute_groups provided by <linux/sysfs.h> work with const
>> attribute_group. So mark the non-const structs as const.
>>
>> File size before:
>>     text	   data	    bss	    dec	    hex	filename
>>    12582	  15361	     20	  27963	   6d3b	kernel/cpu.o
>>
>> File size After adding 'const':
>>     text	   data	    bss	    dec	    hex	filename
>>    12710	  15265	     20	  27995	   6d5b	kernel/cpu.o
> While there does not seem to be anything wrong with it, why did the file
> grow after the patch was applied?
Yes, You are right. I have added few more changes for some experiment.
Which is increasing size of file. Sorry for that, Correct comparison
is this.
File size before:
    text       data        bss        dec        hex    filename
   12909      15361         20      28290       6e82    kernel/cpu.o

File size After adding 'const':
    text       data        bss        dec        hex    filename
   12973      15297         20      28290       6e82    kernel/cpu.o

I will send updated patch.
>> Signed-off-by: Arvind Yadav <arvind.yadav.cs@gmail.com>
> Sebastian
Thanks
~arvind