From: "Christian König" <christian.koenig@amd.com>
To: Dave Airlie <airlied@gmail.com>
Cc: mikhail.v.gavrilov@gmail.com, dri-devel@lists.freedesktop.org,
amd-gfx@lists.freedesktop.org, peterz@infradead.org,
jpoimboe@kernel.org, llvm@lists.linux.dev,
oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
Thomas Zimmermann <tzimmermann@suse.de>,
Maxime Ripard <mripard@kernel.org>,
Simona Vetter <simona@ffwll.ch>
Subject: Re: [PATCH] drm/drm_exec: avoid indirect goto
Date: Tue, 7 Jul 2026 13:59:33 +0200 [thread overview]
Message-ID: <76b6a6c3-f1c7-4e44-957a-3e9cf143aa28@amd.com> (raw)
In-Reply-To: <CAPM=9tz38o_p--FGjgkcDCV43jwmbx_zYDyc8fyHKBteiHDRrQ@mail.gmail.com>
On 7/7/26 13:43, Dave Airlie wrote:
> On Tue, 7 Jul 2026 at 19:11, Christian König <christian.koenig@amd.com> wrote:
>>
>> Adding a few more people to comment and review.
>>
>> Thanks Mike for the pointers, going to add them to the patch before pushing it to drm-misc-fixes.
>>
>> @Thomas, Maxime, Simona, Dave can anybody give me an rb or comment?
>
> I don't like it, but I also don't think the thing it replaces was
> spectacular, so until we can figure out a nicer way let's go with it,
Yeah agree. C is just lacking the functionality to cleanly do this.
> Like I was wondering if putting the label in a macro would make it
> more explainable, but I don't think it would help much.
I was playing with that idea as well, but then decided against it for the simple reason that a __label__ can eventually contain multiple labels unrelated to each other.
>
> Reviewed-by: Dave Airlie <airlied@redhat.com>
Thanks,
Christian.
>
> Dave.
prev parent reply other threads:[~2026-07-07 11:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-04 8:41 Christian König
2026-07-04 11:32 ` Mikhail Gavrilov
2026-07-07 9:11 ` Christian König
2026-07-07 11:43 ` Dave Airlie
2026-07-07 11:59 ` Christian König [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76b6a6c3-f1c7-4e44-957a-3e9cf143aa28@amd.com \
--to=christian.koenig@amd.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=mikhail.v.gavrilov@gmail.com \
--cc=mripard@kernel.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=simona@ffwll.ch \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®