From: Bart Van Assche <bvanassche@acm.org>
To: "Rupesh Majhi" <zoone.rupert@gmail.com>,
"Andy Shevchenko" <andy@kernel.org>,
"David Lechner" <dlechner@baylibre.com>,
"Jonathan Cameron" <jic23@kernel.org>,
"Nuno Sá" <nuno.sa@analog.com>
Cc: linux-arm-msm@vger.kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org, Marco Elver <elver@google.com>,
Jishnu Prakash <jishnu.prakash@oss.qualcomm.com>
Subject: Re: [PATCH v3] iio: adc: qcom-spmi-adc5-gen3: fix lock annotations on mutex helpers
Date: Sun, 25 Oct 2026 13:10:26 -0700 [thread overview]
Message-ID: <76bbebb4-7337-486d-8f21-a39bcb6dca93@acm.org> (raw)
In-Reply-To: <20261025191510.22261-1-zoone.rupert@gmail.com>
On 10/25/26 12:15 PM, Rupesh Majhi wrote:
> Found by building with CONTEXT_ANALYSIS_qcom-spmi-adc5-gen3.o=y
Please include the CONTEXT_ANALYSIS_qcom-spmi-adc5-gen3.o=y change in
your patch.
> diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> index c68c6c5f6aca..6a3cabedf4e8 100644
> --- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> +++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
> @@ -663,7 +663,7 @@ static int adc5_gen3_add_aux_tm_device(struct adc5_chip *adc)
> }
>
> void adc5_gen3_mutex_lock(struct device *dev)
> - __acquires(&adc->lock)
> + __context_unsafe(/* returns with adc->lock held */)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev->parent);
> struct adc5_chip *adc = iio_priv(indio_dev);
> @@ -673,7 +673,7 @@ void adc5_gen3_mutex_lock(struct device *dev)
> EXPORT_SYMBOL_NS_GPL(adc5_gen3_mutex_lock, "QCOM_SPMI_ADC5_GEN3");
>
> void adc5_gen3_mutex_unlock(struct device *dev)
> - __releases(&adc->lock)
> + __context_unsafe(/* releases adc->lock */)
> {
> struct iio_dev *indio_dev = dev_get_drvdata(dev->parent);
> struct adc5_chip *adc = iio_priv(indio_dev);
>
> base-commit: c9dbe2a47f635465c9985b7af74d2ae310e98125
Please consider replacing the above with the patch below:
diff --git a/drivers/iio/adc/qcom-spmi-adc5-gen3.c
b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
index c68c6c5f6aca..09013c6e44a0 100644
--- a/drivers/iio/adc/qcom-spmi-adc5-gen3.c
+++ b/drivers/iio/adc/qcom-spmi-adc5-gen3.c
@@ -663,7 +663,7 @@ static int adc5_gen3_add_aux_tm_device(struct
adc5_chip *adc)
}
void adc5_gen3_mutex_lock(struct device *dev)
- __acquires(&adc->lock)
+ __acquires(&((struct adc5_chip
*)iio_priv(dev_get_drvdata(dev->parent)))->lock)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev->parent);
struct adc5_chip *adc = iio_priv(indio_dev);
@@ -673,7 +673,7 @@ void adc5_gen3_mutex_lock(struct device *dev)
EXPORT_SYMBOL_NS_GPL(adc5_gen3_mutex_lock, "QCOM_SPMI_ADC5_GEN3");
void adc5_gen3_mutex_unlock(struct device *dev)
- __releases(&adc->lock)
+ __releases(&((struct adc5_chip
*)iio_priv(dev_get_drvdata(dev->parent)))->lock)
{
struct iio_dev *indio_dev = dev_get_drvdata(dev->parent);
struct adc5_chip *adc = iio_priv(indio_dev);
Thanks,
Bart.
next prev parent reply other threads:[~2026-10-25 20:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-25 19:15 Rupesh Majhi
2026-10-25 20:10 ` Bart Van Assche [this message]
2026-10-25 21:59 ` Jonathan Cameron
2026-10-26 0:27 ` Bart Van Assche
2026-10-26 8:13 ` Rupesh Majhi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76bbebb4-7337-486d-8f21-a39bcb6dca93@acm.org \
--to=bvanassche@acm.org \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=elver@google.com \
--cc=jic23@kernel.org \
--cc=jishnu.prakash@oss.qualcomm.com \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nuno.sa@analog.com \
--cc=zoone.rupert@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®