From: "Chuck Lever" <chucklever@gmail.com>
To: "Andrew Morton" <akpm@osdl.org>
Cc: "Trond Myklebust" <Trond.Myklebust@netapp.com>,
"Linus Torvalds" <torvalds@osdl.org>,
nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [NFS] [PATCH 07/11] NFS: fix minor bug in new NFS symlink code
Date: Fri, 20 Oct 2006 00:57:49 -0400 [thread overview]
Message-ID: <76bd70e30610192157q3c2252b4s62e7bf985b4b487d@mail.gmail.com> (raw)
In-Reply-To: <20061019212541.b2adc4b2.akpm@osdl.org>
On 10/20/06, Andrew Morton <akpm@osdl.org> wrote:
> On Thu, 19 Oct 2006 13:04:32 -0400
> Trond Myklebust <Trond.Myklebust@netapp.com> wrote:
>
> > diff --git a/fs/nfs/dir.c b/fs/nfs/dir.c
> > index 58d4405..c86a1ea 100644
> > --- a/fs/nfs/dir.c
> > +++ b/fs/nfs/dir.c
> > @@ -1519,8 +1519,8 @@ static int nfs_symlink(struct inode *dir
> > pagevec_init(&lru_pvec, 0);
> > if (!add_to_page_cache(page, dentry->d_inode->i_mapping, 0,
> > GFP_KERNEL)) {
> > - if (!pagevec_add(&lru_pvec, page))
> > - __pagevec_lru_add(&lru_pvec);
> > + pagevec_add(&lru_pvec, page);
> > + pagevec_lru_add(&lru_pvec);
> > SetPageUptodate(page);
> > unlock_page(page);
> > } else
>
> One could export add_to_page_cache_lru() to modules..
I assumed there was probably a good reason that this had not already been done.
--
"We who cut mere stones must always be envisioning cathedrals"
-- Quarry worker's creed
next prev parent reply other threads:[~2006-10-20 4:57 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-19 17:04 [PATCH 01/11] NFSv4: Fix thinko in fs/nfs/super.c Trond Myklebust
2006-10-19 17:04 ` [PATCH 08/11] NFS: __nfs_revalidate_inode() can use "inode" before checking it is non-NULL Trond Myklebust
2006-10-19 17:04 ` [PATCH 04/11] nfs4: initialize cl_ipaddr Trond Myklebust
2006-10-19 17:04 ` [PATCH 07/11] NFS: fix minor bug in new NFS symlink code Trond Myklebust
2006-10-20 4:25 ` Andrew Morton
2006-10-20 4:57 ` Chuck Lever [this message]
2006-10-19 17:04 ` [PATCH 05/11] NFS: Fix NFSv4 callback regression Trond Myklebust
2006-10-19 17:04 ` [PATCH 11/11] SUNRPC: fix a typo Trond Myklebust
2006-10-19 17:04 ` [PATCH 03/11] NFS: Fix error handling in nfs_direct_write_result() Trond Myklebust
2006-10-19 17:04 ` [PATCH 02/11] NFS: Fix oops in nfs_cancel_commit_list Trond Myklebust
2006-10-19 17:04 ` [PATCH 10/11] SUNRPC: fix race in in-kernel RPC portmapper client Trond Myklebust
2006-10-19 17:04 ` [PATCH 06/11] NFS: Deal with failure of invalidate_inode_pages2() Trond Myklebust
2006-10-19 17:04 ` [PATCH 09/11] NFS: remove unused check in nfs4_open_revalidate Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76bd70e30610192157q3c2252b4s62e7bf985b4b487d@mail.gmail.com \
--to=chucklever@gmail.com \
--cc=Trond.Myklebust@netapp.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®