From: "Arnd Bergmann" <arnd@arndb.de>
To: "Naresh Kamboju" <naresh.kamboju@linaro.org>,
linux-next <linux-next@vger.kernel.org>,
"open list" <linux-kernel@vger.kernel.org>,
linux-mips@vger.kernel.org, lkft-triage@lists.linaro.org,
"Linus Walleij" <linus.walleij@linaro.org>,
"Andy Shevchenko" <andriy.shevchenko@linux.intel.com>
Cc: "Thomas Bogendoerfer" <tsbogend@alpha.franken.de>,
"Anders Roxell" <anders.roxell@linaro.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Phil Mathieu-Daudé" <philmd@linaro.org>
Subject: Re: next: arch/mips/ar7/gpio.c:19:33: error: field 'chip' has incomplete type
Date: Tue, 07 Mar 2023 19:46:26 +0100 [thread overview]
Message-ID: <76be6056-2057-4199-9dd2-52d28bbb37e8@app.fastmail.com> (raw)
In-Reply-To: <CA+G9fYvX8W6R6FtxZbCmdeKhSikmdD9Tten8U5qXX4cG3+-1VQ@mail.gmail.com>
On Tue, Mar 7, 2023, at 18:10, Naresh Kamboju wrote:
> Following build regression found while building mips ar7_defconfig
> on Linux next-20230307 tag.
>
> Reported-by: Linux Kernel Functional Testing <lkft@linaro.org>
>
> Please find the build log and details below.
>
> build log:
> --------
> arch/mips/ar7/gpio.c:19:33: error: field 'chip' has incomplete type
> 19 | struct gpio_chip chip;
It sounds like a result of 21d9526d13b5 ("gpiolib: Make the
legacy <linux/gpio.h> consumer-only"). I haven't tried it,
but I think this should fix it, unless there is another bug:
--- a/arch/mips/ar7/gpio.c
+++ b/arch/mips/ar7/gpio.c
@@ -7,7 +7,7 @@
#include <linux/init.h>
#include <linux/export.h>
-#include <linux/gpio.h>
+#include <linux/gpio/driver.h>
#include <asm/mach-ar7/ar7.h>
Arnd
next prev parent reply other threads:[~2023-03-07 19:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-07 17:10 Naresh Kamboju
2023-03-07 18:46 ` Arnd Bergmann [this message]
2023-03-08 13:00 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76be6056-2057-4199-9dd2-52d28bbb37e8@app.fastmail.com \
--to=arnd@arndb.de \
--cc=anders.roxell@linaro.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=jiaxun.yang@flygoat.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=lkft-triage@lists.linaro.org \
--cc=naresh.kamboju@linaro.org \
--cc=philmd@linaro.org \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®