From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id ABB174749D5 for ; Tue, 4 Aug 2026 18:52:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869545; cv=none; b=QeN+uEvZuuweFVXVOVBjHM9h9fnfSa+jC8/2h26WHfqo2EM8SPbK2/xvuRS2HlQzTtXwILUw5fP2djkXvjB68Ng7TtPXemb4Se0ikheZiYPk9sxs3VrNyH7AelHn8odBu/iP0tqvAA2buIqb2ZYz8YjrKagmt6AURFYJi01F/kM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785869545; c=relaxed/simple; bh=qplbsh/mSXiKomLy1bCLaoHsZycFdQMuX3h8VoKxnpc=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=LqCCB5jSYmdgL8NzrRHDLpkbTPax8HknrERGs/YIjSQkN2dFksGRGFuNbd4ObSvSHkjknpMzWnij4U0jgkQylUVLvQRxV1Dcigf+X9UjYlgkJhhWv3SGb50ga7QLDQ644kZsA9KNxrVOLKknoMPsoLPQTvjVZF3gqVH122P3zCY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=ovAkk72E; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=dTcRwynD; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="ovAkk72E"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="dTcRwynD" Received: from pps.filterd (m0279873.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 674Ffhm8071216 for ; Tue, 4 Aug 2026 18:52:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= YtP2L62OBcnos1NyatTDhxKiVMhFH9/cdtH1RA7Q+Js=; b=ovAkk72EHYo/90hU T2pZh4UCjmwOPBXq/jEDdFzONs5oBoPsDyf+tRP6MVGxkHK2oosn2Dj6c6Zp0IN0 yDkJZ2SaO05kXBs8r3HAp0cPpmW6tT31Evco7l2usYJqaZzC/wypt1evByg2mjFF xYZ/w5gMtmNI42ByiUJjuTtUU1xONCTVymnnxwXKeBmh/uV88/63phP9CQSLh9vg J25aULN9xUbUopCi6l7ZgSoxhtimVFtSLxUxK7zTzrPOPV2iMj8y5w316C2hBdtX +YtLm1K1K28uBkuM4AMsmsgjH6O8B35E7v2dPt5fp6SE3G1qrSjvlhY4LIhmL3RU x4+jkA== Received: from mail-pg1-f199.google.com (mail-pg1-f199.google.com [209.85.215.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fujwsgy3b-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Tue, 04 Aug 2026 18:52:22 +0000 (GMT) Received: by mail-pg1-f199.google.com with SMTP id 41be03b00d2f7-cb48f41343aso1028257a12.1 for ; Tue, 04 Aug 2026 11:52:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1785869541; x=1786474341; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=YtP2L62OBcnos1NyatTDhxKiVMhFH9/cdtH1RA7Q+Js=; b=dTcRwynDKVf3fQW1XSZ4z6rr4LM3WglXYDLX/hrtj/uNJ7YgNwrAMgW1gIj5btgm1V V/EgUY8EInG7Ocr5EZXqxV607eIJpQWCbUlgWblIZ3Rmf4/8OmCwJg5SNyWSv0efk0RS SjWUpXbEsWqRtCFm1phHEX0LiTfjhjCQI9m9C4J2p+ngjMF0U4GD+HmgdEmp1D2nXtQc 6fD7nxOpvmLngKlXGzitdsXTpS/A/sglA8gp+CI/U+rKBiKcwQ0/jdCZXS7lJBzcv5jw JJcou3RaJA5xV09uT7Li562lOGHH3K1GQa/H0swYYShjNaJfvBRyeK7yvwWxyIfojSwS 3ydQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785869541; x=1786474341; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=YtP2L62OBcnos1NyatTDhxKiVMhFH9/cdtH1RA7Q+Js=; b=qASYvosQdxTim7d4wijUlN0fjhgXcQ/05k6P891oqp7KuXADTBLkblhtZo0F9HAEnu iKHFXR5k5q4XKXIQ1g21lpe8gS0uSdQ+cKB09YyiNhg+OLjnWvrlTm01f+0w3ZrXnKAm aLJlJ0MUZrRf9gjfp2s4PQGNA9sYNwpQ91ui5FMdXGhCiIb7Eo0cpisv0WvrHJft9euj 1wzRx9IXy96Eppt80uYkWFJMKwb05UWgYx81OZIIrHuDrBtd8yCLEk1SYx/0o034h3KS Eoo3WW6mK80ZFDdFS0wYtRqVFDpfibXhgZ1FpO8qmdSnnpibTEkHlCNTwmBwMkni8WK2 Sorg== X-Forwarded-Encrypted: i=1; AHgh+RpjU/ozVXhO3ZUAVor7TMfVmH0mkzOamFGukgClRlk5Fmvx2Xi8CjRfG0w2UWQ5qbSM4P0rV4Fge7WXPkQ=@vger.kernel.org X-Gm-Message-State: AOJu0YyXT2kecCxtl67j41vm+RTQCD9k9nI0xx/XCebEqot4T10NGr25 cXbtSvcfyYlUNTj7NT2RdGSgaPrTa9secQHaAdA6i2QZZDAHLT9mn6ki18DInog7o2Pozl9MrGW EDueVwDvNws7RFCbu1UYgtkq67IAhKv6UnIgDSyk6NHxHL1Ypc9DLy/nrU30NtMSjBA0= X-Gm-Gg: AR+sD13zWDr3rVeQx7bDGoLhcYzLK/SU3eysZWp5FcL5mSyXe1+tJv9CBWU/7J0JQyI 6zfOT4q3DmsPI1WEE3nj6/m4pfRdxrndOfjGndcpkX8ukPmqdUm2QsnbGwlaMuF6uvnbV3XAG7x P+vozGMULwI77n0VC4RotAZ9IlQVHlizTGpV5QFLmmSdrRGYe1jnCkKDp9AZwnzG88P3ly2c9Db eQ9JJmQKLVXUZ60thyqnw/as+Jx9u8DWjE/z+HoBfefk/0/7aJPzOz7qNcEVk1X5jOAFTDXuxRS XZzTk38+Jklzz3IyTPirZfsd9Ht7SSfx1wtsfrI8X7hFs2L2pCIu64SdlgGPbNU25e7q1FKWq01 2PN/FQhKB2pmZxUA8h+6FJXYckkCI/3KKrw== X-Received: by 2002:a05:6a21:9991:b0:3a2:ed4a:5d7e with SMTP id adf61e73a8af0-3cb6c9c1887mr5739252637.22.1785869541517; Tue, 04 Aug 2026 11:52:21 -0700 (PDT) X-Received: by 2002:a05:6a21:9991:b0:3a2:ed4a:5d7e with SMTP id adf61e73a8af0-3cb6c9c1887mr5739208637.22.1785869541078; Tue, 04 Aug 2026 11:52:21 -0700 (PDT) Received: from [192.168.1.8] ([106.222.234.41]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-31586447d52sm6700712eec.12.2026.08.04.11.52.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 04 Aug 2026 11:52:20 -0700 (PDT) Message-ID: <76c03e2b-649b-4316-9c3d-4ce5d27a86e5@oss.qualcomm.com> Date: Wed, 5 Aug 2026 00:22:15 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH V3 10/14] i3c: master: Add helper to query bus wakeup requirements To: Adrian Hunter , alexandre.belloni@bootlin.com Cc: Frank.Li@nxp.com, akhilrajeev@nvidia.com, rafael@kernel.org, linux-i3c@lists.infradead.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-pm@vger.kernel.org References: <20260804133810.184905-1-adrian.hunter@intel.com> <20260804133810.184905-11-adrian.hunter@intel.com> Content-Language: en-US From: Mukesh Savaliya In-Reply-To: <20260804133810.184905-11-adrian.hunter@intel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-GUID: 3yBtazrtLyGyttVfWwIi9ecFiGqTElt4 X-Proofpoint-ORIG-GUID: 3yBtazrtLyGyttVfWwIi9ecFiGqTElt4 X-Proofpoint-Spam-Info: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfXw32ZB6DXHLeB jqsFeIFyX8ACr4h0ewuEINgpT2fP0pxevUTRPpHlttTqepTQ9izM4iZkByUWR+OlLleS3N4yPxV NIoNzOW1cf6ptUOdx1q2HeBm6Rf6Snw= X-Authority-Analysis: v=2.4 cv=Lu6iDHdc c=1 sm=1 tr=0 ts=6a7234e6 cx=c_pps a=Oh5Dbbf/trHjhBongsHeRQ==:117 a=/lQgZcjXNA7ZrIsIl4Cfeg==:17 a=IkcTkHD0fZMA:10 a=Sv0fKeRqtYgA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=rJkE3RaqiGZ5pbrm-msn:22 a=y7ZiA1EjnykWbA9aLYYA:9 a=QEXdDO2ut3YA:10 a=_Vgx9l1VpLgwpw_dHYaR:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwODA0MDE1MiBTYWx0ZWRfXya1dgamDGqb3 BnRKJCaohvDiLmBPwD7vC5LmncVyfnHABwt2u5NI+nEpUNB8+zgqGp2hB4zjVQLkIcPI7CVgpj4 ZFMZyyH/zjIpWNh/VFx93wKFH739++M75CC5rq0ftVGWDYMAUE/SCA/T+0qzgBVcVtwS1PaLrLC 6IpGAahVbKYsspXZY5O7dcrPHEOUZa+NWXHu5AEIyAXuxLlTAxjITqGcJZt5HrxQ1Xcp0jD9D+R 2SRjk79Z+mbKJOcnns6EG5CGy6cFz/WQpTuHLLpOfTCgkrxzz1KL1np6Ec5zk35r9Vb3nJALYkQ h8PRieTQru4Fu9Vhz4IP88m4R5Ms7kuyzP8cW3wuUlJNU4qCxQVXtogigvwoIPZyYC0rqgZtk5P CmGo8mcPGGXeN1r14cWicjkJ56V3zVHqbK3ifEVL0T3VU59Rt+rjBmR1SwMSZUP9ck0ImU/NcIj bl+ZaowXNSgX+Hldlog== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1176,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-08-04_03,2026-08-04_01,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 spamscore=0 priorityscore=1501 clxscore=1015 bulkscore=0 lowpriorityscore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2608040152 On 8/4/2026 7:08 PM, Adrian Hunter wrote: [...] > diff --git a/drivers/i3c/master.c b/drivers/i3c/master.c > index 8c9e62e6f146..baf4769f0512 100644 > --- a/drivers/i3c/master.c > +++ b/drivers/i3c/master.c > @@ -2150,6 +2150,41 @@ static void i3c_master_reg_work_fn(struct work_struct *work) > i3c_master_register_new_i3c_devs(master); > } > > +/** > + * i3c_master_any_wakeup_enabled() - check if any device can wake the system > + * @master: I3C master controller > + * > + * Iterate over devices on the bus and return true if any device has > + * system wakeup enabled and IBI enabled. > + * > + * Whether a device is enabled for system wakeup is user space policy, > + * settable at any time through the device's power/wakeup sysfs attribute, > + * so the answer is only stable once user space is frozen. Call this from > + * a system suspend callback. > + * > + * Return: true if any device may wake the system via IBI, false otherwise. > + */ > +bool i3c_master_any_wakeup_enabled(struct i3c_master_controller *master) wanted to suggest if this function name suits ?i3c_master_has_wakeup_enabled_devs() > +{ > + struct i3c_dev_desc *desc; > + bool wakeup = false; > + > + i3c_bus_normaluse_lock(&master->bus); > + i3c_bus_for_each_i3cdev(&master->bus, desc) { > + if (!desc->dev || desc == master->this || !device_may_wakeup(&desc->dev->dev)) > + continue; > + guard(mutex)(&desc->ibi_lock); > + if (desc->ibi && desc->ibi->enabled) { > + wakeup = true; > + break; > + } > + } > + i3c_bus_normaluse_unlock(&master->bus); > + > + return wakeup; > +} > +EXPORT_SYMBOL_GPL(i3c_master_any_wakeup_enabled);\[...] [...]