From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AB85A37AA99 for ; Fri, 10 Jul 2026 08:50:20 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783673422; cv=none; b=iwdHp1p49jQLzOT0ggBZjuDZhqIn77Kpgh/H3iWOT+tzComMAgXDyzyow+ohe50PqgETkIRFhfsRMUKlIsqJYxjl/xM9iUOt9PlusBeTKrrze6a8xrIgcwXdkRhg1OOzddoLjwpObTK+a1tCQaRk3Be3pY5C7HKqw+a3QQyMWiw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1783673422; c=relaxed/simple; bh=9bWhbND8DyvzDCbaHug3rOhbSdj9QX9W+6SjaKd08CE=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=dcjVzot6lyaKW0WJ8AAaXCCJ7VMEzg6KNVwsUG4FJxUjG0iBkF1EhdA/mPuIUbiVJbQXH0Vlaem6tl1ZxXcbt+UKzx66riWQFxNBuAsF7aXXkjnF3ICVJsSgYptWecCMtiwP9MdRbE7L4jlSjoXcx5R8v9LrRSdcGxvvmZYbQDc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=Xg42b0g9; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=c/iO/vHA; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="Xg42b0g9"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="c/iO/vHA" Received: from pps.filterd (m0279871.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 66A7eFr5190692 for ; Fri, 10 Jul 2026 08:50:19 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= 0vPVQ1ErU/pGixkPNw1WBsE9kjQFwY0ce2USBSASEqE=; b=Xg42b0g9MUSCQ9s9 qurkfwSTMG6N35ozQPKaN5u+nbzys08f8XsFv4NIhisNMtn7IcSV0gUsuyb1v13A /gtHNuvVFUSE50JwppjGYTR0czD3xR0F3WnsuT64VgQvZUahdJNCf14Q39IJLLBm htVWmPmThcCn302tmihCRcdtCYhyl8q244e4BBMfDw78RwVgyOB/HH4/Qw7HmelH LVtzEIAzW8OgqQxMOGXsQyH8dzdGQJh5ocqJMvg2od/JmyA+H0o24kFPgau22FYd h9lp10hZTxXxxPEgOwj8sDJmK3+TZlRzdZdDZGmqqhsyTUyh8CG+hFZcgv1hj+Q+ coGAWA== Received: from mail-pl1-f199.google.com (mail-pl1-f199.google.com [209.85.214.199]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4fas6n122h-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Fri, 10 Jul 2026 08:50:19 +0000 (GMT) Received: by mail-pl1-f199.google.com with SMTP id d9443c01a7336-2caa9a3cf7aso18191495ad.0 for ; Fri, 10 Jul 2026 01:50:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1783673418; x=1784278218; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=0vPVQ1ErU/pGixkPNw1WBsE9kjQFwY0ce2USBSASEqE=; b=c/iO/vHAVgCEb5G5jTabEI4RFw+qXN79sMwjNVY3wbQ7+7cdBFGWLCt3Y06SCJ4w7Y SpnVSCR5v/xz4Jxc+JVbNZ+lV+avlNTL3+Feb74k7Cpt1SAxim78RHt634Oca14RoRc0 zZ30kQ8xf8U1gPXi0zpdIN8COm4MhMJa8vYJRUWXJT7J0/ZKQhSeGiGhaUL+M3Hf9cr7 p43PI6T63eeGPLxMP4+BpP1mWODflncBz19Ikifv39AZufRjF7UPh/07IJqKi6Fv6ILm ZVK26cJdCH3+51YbSpE1be4sZLf6xO2Wr0QxFTbp40LM2MZTkAwaSupPmA4ifbxktOP1 HGxg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1783673418; x=1784278218; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=0vPVQ1ErU/pGixkPNw1WBsE9kjQFwY0ce2USBSASEqE=; b=PFT0kkl1TT5JIHLeweb6RofY0hQmFGYrIZXo51aORcsB71SbbChcd27PH80H5mdPEs /U+QzS7bvWDGU9ITDhWRHGqYE6VKL3ELZlkziRuHItk4mGMxw4Wb75BF6Ca0FiG0Ut+D vcNfezwk++p6YWEbKTep9YVcGrN+9MCMdJ6ClGHWTeIwpiq24prgTmefQBNtw95Ss5Cb dKy2KIroshfyrotBl73s9VZQfu66xqFk3KxoUTyaKgnk4r/sM4oF6Voz+0gjBMDFM2HK jI80CC/1GiWROFbJXPjDJezsn6OD9gTbYPRwuYUZMY6CghsWUFov/f6YKOelqeJO0hP/ h2/Q== X-Forwarded-Encrypted: i=1; AHgh+RpQ8wqCN4PF5AinKHBQFsTQXhxegAOvd5ljwdIrG/xMTj8YxfrhDAed2oUnTwL/aKN4B+ib/BNMpybIl+A=@vger.kernel.org X-Gm-Message-State: AOJu0Yzply/XGfUt5Zadc36ZxKxDRrr5/sQyrsZdvFmXko+oFzYjj8yl x7tW8LDKFYl/TEKjDdaoUFhEKPHCpTaIaDsReme8TTLey1x2oRXZessO2zHQiJxDABHjI7ugjxy i0OxBLWNLozTqEzpDqLei/NGvGu9bFibt9kz9tki3rU+wiysK8k0fByddO5HqA6mFeK9X5NXdry 4= X-Gm-Gg: AfdE7cmRBD82e2P2Z+hp1oYUkE8i6wRElDXUdXrfeON4vAHMxGvlPYYB8+cCBiigTPa X/skHB7QWkLc5ucuYLEt/UUUoKsOxXmIt11DqtOTRWuG9uXSmmu8gCqiI0KDrltaIccT9HshPVi j9GBJ7WIQMlgEPjsEwVarONNcRmZnQybMn00cWkrUHHHERuZhyrOwLymGppj/tDhoVNs6eXI8An 8/BTENqrxrozvknycHQHVvjvedrHJd6LuOqyNdggTNySrUn230dXrV/n/0kX38NtWqDfiBu8Ztm MXRHXzfjiUYq1djMadJRxUUQs0qaCVbm+Nu40kRewbuze87yjBHfVbBWDYvSPIOJB8VPYIR5Jx5 5cv4kJXnTGzf0KQIZU4H8G43n+JYHE51sokIC5tIsEFE/ X-Received: by 2002:a05:6a21:6115:b0:3bf:aa54:4cbc with SMTP id adf61e73a8af0-3c0f0b6fda4mr3080654637.26.1783673418505; Fri, 10 Jul 2026 01:50:18 -0700 (PDT) X-Received: by 2002:a05:6a21:6115:b0:3bf:aa54:4cbc with SMTP id adf61e73a8af0-3c0f0b6fda4mr3080616637.26.1783673418002; Fri, 10 Jul 2026 01:50:18 -0700 (PDT) Received: from [10.217.219.87] ([202.46.22.19]) by smtp.gmail.com with ESMTPSA id a92af1059eb24-13b6593c76dsm38642648c88.3.2026.07.10.01.50.13 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 10 Jul 2026 01:50:17 -0700 (PDT) Message-ID: <76c5567a-cc93-422c-a18f-a32dcb101428@oss.qualcomm.com> Date: Fri, 10 Jul 2026 14:20:11 +0530 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2] i2c: spacemit: fix spurious IRQ handling returning IRQ_HANDLED To: Pei Xiao Cc: andi.shyti@kernel.org, linux-i2c@vger.kernel.org, linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, spacemit@lists.linux.dev, troy.mitchell@linux.spacemit.com References: Content-Language: en-US From: Mukesh Savaliya In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNzEwMDA4NSBTYWx0ZWRfX5C606wHlH6Mz 2EXQhldjwwTurQjAULCIXljSmMk2yva4iYpmsOx6r5Ic7J6P6MYee9IynKK5vOsZTKtfP2jb7Gg ZbVclGeQ1OQ/p0BPYMxhlsRLgp0O5dk= X-Authority-Analysis: v=2.4 cv=DYgnbPtW c=1 sm=1 tr=0 ts=6a50b24b cx=c_pps a=JL+w9abYAAE89/QcEU+0QA==:117 a=fChuTYTh2wq5r3m49p7fHw==:17 a=IkcTkHD0fZMA:10 a=RAioF0-LDSMA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=3WHJM1ZQz_JShphwDgj5:22 a=fdZnArvSVwIb3KS3I78A:9 a=QEXdDO2ut3YA:10 a=324X-CrmTo6CU4MGRt3R:22 X-Proofpoint-ORIG-GUID: pogQN9J-pg3hetap14yDaXf3gBB5p_X_ X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNzEwMDA4NSBTYWx0ZWRfX7Vw/3SXrmcfQ Nfq4/tnjISZxFezNWzIq2fUU//6im5XnZeDi6hpaPFr6vITiNjl81mTr1OvKoMTMTb8N3Mk3vke lNKyJGMo6/zxVxhN3rRBjVFt4r53aw17QaE4Ue8O1VYqCslBE/wuZFoOK0v4LQCpw0/9p+keCIj X06uFCwUp+CX2zUn4FpF0QYsTbNwc68euOgbRXtJ9PablZdL/eemQCOqFeBd7eTEuzYWH8Kau15 O1qA2tzaG7hO+xRgxOhv3ltqCSRLSTsSft2fU6Xoosxi6JDkTsTgV5AbZ7TwGXfKKP2jcEsayIO /xtkWQYW6NgrY0rI+nAH4Me8n0YwweykrrHOa+wAVTTn/tcPQPUVL7ZJbDKLzXKKzAz2FinQqqd 8mm8ezFesWKErto0s0EnsY8almE6RTr4gJG1eODrsGA2nHryMmMNjlGp3hx8n9RP/PMK/3/a+eD AwhoiBX5eD9lGyojCfA== X-Proofpoint-GUID: pogQN9J-pg3hetap14yDaXf3gBB5p_X_ X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.134,FMLib:17.12.100.49 definitions=2026-07-10_02,2026-07-09_04,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 lowpriorityscore=0 adultscore=0 suspectscore=0 bulkscore=0 clxscore=1015 phishscore=0 malwarescore=0 spamscore=0 impostorscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2607100085 On 7/10/2026 12:51 PM, Pei Xiao wrote: > When the interrupt status register reads zero, the handler should > return IRQ_NONE instead of IRQ_HANDLED. What the return value > actually feeds into is the spurious interrupt accounting in > note_interrupt(): falsely claiming IRQ_HANDLED defeats the "irq XX: note_interrupt() ? You mean to say No interrupt OR invalid interrupt here ? I could not understand function name. > nobody cared" detection, so a stuck interrupt source would never be > caught. > > Fixes: 5ea558473fa3 ("i2c: spacemit: add support for SpacemiT K1 SoC") > Signed-off-by: Pei Xiao > --- > changlog in v2: > modify gitlog for Modify the incorrect Git commit message to match the reason for the modification. > --- > drivers/i2c/busses/i2c-k1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/i2c/busses/i2c-k1.c b/drivers/i2c/busses/i2c-k1.c > index c2d090f6ba80..487f23fde725 100644 > --- a/drivers/i2c/busses/i2c-k1.c > +++ b/drivers/i2c/busses/i2c-k1.c > @@ -728,7 +728,7 @@ static irqreturn_t spacemit_i2c_irq_handler(int irq, void *devid) > > status = readl(i2c->base + SPACEMIT_ISR); > if (!status) > - return IRQ_HANDLED; > + return IRQ_NONE; > > i2c->status = status; >