mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Dafna Hirschfeld <dafna.hirschfeld@collabora.com>
Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org,
	mchehab@kernel.org, helen.koike@collabora.com,
	hverkuil@xs4all.nl, laurent.pinchart@ideasonboard.com,
	andrealmeid@collabora.com, dafna3 <dafna3@gmail.com>,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH v3 1/2] media: vimc: Collapse component structure into a single monolithic driver
Date: Tue, 3 Sep 2019 06:55:21 -0600	[thread overview]
Message-ID: <76c8489f-4c6f-27df-ce28-a7ce3e8b3843@linuxfoundation.org> (raw)
In-Reply-To: <09c3ddad7122efb23201dff6e11aaf7455c748ea.camel@collabora.com>

On 9/3/19 6:50 AM, Dafna Hirschfeld wrote:
> Hi,
> Thank you for working on the patchset.
> 
> Since there is only one module now, the section in the vimc Documentation
> regarding module params should be changed:
> 
> In the file Documentation/media/v4l-drivers/vimc.rst
> The following text should be removed:
> 
> ```
> You should pass
> those arguments to each subdevice, not to the vimc module. For example::
> 
>          vimc_subdevice.param=value
> ```
> 
> (no inline comments)
> 

Thanks Dafna. Yes Documentation needs updates for other reasons and
the module params is on my list as well to fix.

thanks,
-- Shuah

  reply	other threads:[~2019-09-03 12:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-08-20 21:18 [PATCH v3 0/2] Collapse vimc into " Shuah Khan
2019-08-20 21:18 ` [PATCH v3 1/2] media: vimc: Collapse component structure into a " Shuah Khan
2019-08-27 16:16   ` Dafna Hirschfeld
2019-08-27 18:11     ` Shuah Khan
2019-08-27 16:55   ` Laurent Pinchart
2019-08-27 18:17     ` Shuah Khan
2019-09-03 12:50   ` Dafna Hirschfeld
2019-09-03 12:55     ` Shuah Khan [this message]
2019-08-20 21:18 ` [PATCH v3 2/2] media: vimc: Fix gpf in rmmod path when stream is active Shuah Khan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76c8489f-4c6f-27df-ce28-a7ce3e8b3843@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=andrealmeid@collabora.com \
    --cc=dafna.hirschfeld@collabora.com \
    --cc=dafna3@gmail.com \
    --cc=helen.koike@collabora.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome