From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.2 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8072CC4160E for ; Tue, 2 Mar 2021 15:28:37 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 53F4964F2D for ; Tue, 2 Mar 2021 15:28:37 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1578610AbhCBPZ4 (ORCPT ); Tue, 2 Mar 2021 10:25:56 -0500 Received: from cmccmta1.chinamobile.com ([221.176.66.79]:51243 "EHLO cmccmta1.chinamobile.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347855AbhCBNCo (ORCPT ); Tue, 2 Mar 2021 08:02:44 -0500 Received: from spf.mail.chinamobile.com (unknown[172.16.121.17]) by rmmx-syy-dmz-app04-12004 (RichMail) with SMTP id 2ee4603e35c7631-91cc2; Tue, 02 Mar 2021 20:55:37 +0800 (CST) X-RM-TRANSID: 2ee4603e35c7631-91cc2 X-RM-TagInfo: emlType=0 X-RM-SPAM-FLAG: 00000000 Received: from [192.168.21.77] (unknown[10.42.68.12]) by rmsmtp-syy-appsvr09-12009 (RichMail) with SMTP id 2ee9603e35c7299-1c3fb; Tue, 02 Mar 2021 20:55:37 +0800 (CST) X-RM-TRANSID: 2ee9603e35c7299-1c3fb Subject: Re: [PATCH] ASoC: codec: Omit superfluous error message injz4760_codec_probe() To: Paul Cercueil Cc: broonie@kernel.org, lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org References: <20210302121148.28328-1-tangbin@cmss.chinamobile.com> From: tangbin Message-ID: <76c87931-094e-0804-9405-ad4841fae2d3@cmss.chinamobile.com> Date: Tue, 2 Mar 2021 20:55:25 +0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Paul: On 2021/3/2 20:23, Paul Cercueil wrote: > Hi Tang, > > Le mar. 2 mars 2021 à 20:11, Tang Bin a > écrit : >> The function devm_platform_ioremap_resource has already contained error >> message, so remove the redundant dev_err here. >> >> Signed-off-by: Tang Bin >> --- >>  sound/soc/codecs/jz4760.c | 1 - >>  1 file changed, 1 deletion(-) >> >> diff --git a/sound/soc/codecs/jz4760.c b/sound/soc/codecs/jz4760.c >> index e8f28ccc145a..c2d8a107f159 100644 >> --- a/sound/soc/codecs/jz4760.c >> +++ b/sound/soc/codecs/jz4760.c >> @@ -843,7 +843,6 @@ static int jz4760_codec_probe(struct >> platform_device *pdev) >>      codec->base = devm_platform_ioremap_resource(pdev, 0); >>      if (IS_ERR(codec->base)) { >>          ret = PTR_ERR(codec->base); >> -        dev_err(dev, "Failed to ioremap mmio memory: %d\n", ret); >>          return ret; >>      } > > Indeed, you are right. > > I guess you do this instead: > > if (IS_ERR(codec->base)) >    return PTR_ERR(codec->base); Yes, I would have written it in your ways, but considered the variable "ret", I gave up, and just deleted dev_err(). Thanks Tang Bin