From: Markus Elfring <Markus.Elfring@web.de>
To: Sahil Chandna <chandna.sahil@gmail.com>, linux-mm@kvack.org
Cc: LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Axel Rasmussen <axelrasmussen@google.com>,
Chengming Zhou <chengming.zhou@linux.dev>,
David Hildenbrand <david@redhat.com>,
Johannes Weiner <hannes@cmpxchg.org>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Michal Hocko <mhocko@suse.com>, Mike Rapoport <rppt@kernel.org>,
Nhat Pham <nphamcs@gmail.com>,
Qi Zheng <zhengqi.arch@bytedance.com>,
Shakeel Butt <shakeel.butt@linux.dev>,
Suren Baghdasaryan <surenb@google.com>,
Vlastimil Babka <vbabka@suse.cz>, Wei Xu <weixugc@google.com>,
Yosry Ahmed <yosry.ahmed@linux.dev>,
Yuanchu Xie <yuanchu@google.com>
Subject: Re: [PATCH 2/3] mm/vmscan: use %pe to print PTR_ERR() values
Date: Tue, 18 Nov 2025 14:15:38 +0100 [thread overview]
Message-ID: <76cfa66f-2254-465d-8977-28915ed5cbc1@web.de> (raw)
In-Reply-To: <94ba6ef88d97eb1a5e20eeab9f913be8fdc46fd5.1763227530.git.chandna.sahil@gmail.com>
…
> +++ b/mm/vmscan.c
> @@ -7500,8 +7500,8 @@ void __meminit kswapd_run(int nid)
> pgdat->kswapd = kthread_create_on_node(kswapd, pgdat, nid, "kswapd%d", nid);
> if (IS_ERR(pgdat->kswapd)) {
…
> + pr_err("Failed to start kswapd on node %d,ret=%pe\n",
> + nid, pgdat->kswapd);
> BUG_ON(system_state < SYSTEM_RUNNING);
…
I propose to adjust the indentation for the passed parameters.
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/coding-style.rst?h=v6.18-rc6#n110
Regards,
Markus
next prev parent reply other threads:[~2025-11-18 13:16 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-18 6:08 [PATCH 0/3] mm: Coccinelle-driven cleanups across memory management code Sahil Chandna
2025-11-18 6:08 ` [PATCH 1/3] mm/pagewalk: use min() macro instead of manual ternary Sahil Chandna
2025-11-18 10:19 ` Markus Elfring
2025-11-18 10:45 ` David Laight
2025-11-18 15:18 ` Matthew Wilcox
2025-11-18 16:56 ` David Laight
2025-11-18 6:08 ` [PATCH 2/3] mm/vmscan: use %pe to print PTR_ERR() values Sahil Chandna
2025-11-18 13:15 ` Markus Elfring [this message]
2025-11-19 1:52 ` SeongJae Park
2025-11-18 6:08 ` [PATCH 3/3] mm/zswap: " Sahil Chandna
2025-11-18 13:20 ` Markus Elfring
2025-11-18 15:11 ` Matthew Wilcox
2025-11-18 19:28 ` Markus Elfring
2025-11-18 15:46 ` Yosry Ahmed
2025-11-19 1:50 ` SeongJae Park
2025-11-19 12:50 ` Nhat Pham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76cfa66f-2254-465d-8977-28915ed5cbc1@web.de \
--to=markus.elfring@web.de \
--cc=Liam.Howlett@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=axelrasmussen@google.com \
--cc=chandna.sahil@gmail.com \
--cc=chengming.zhou@linux.dev \
--cc=david@redhat.com \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=mhocko@suse.com \
--cc=nphamcs@gmail.com \
--cc=rppt@kernel.org \
--cc=shakeel.butt@linux.dev \
--cc=surenb@google.com \
--cc=vbabka@suse.cz \
--cc=weixugc@google.com \
--cc=yosry.ahmed@linux.dev \
--cc=yuanchu@google.com \
--cc=zhengqi.arch@bytedance.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®