From: Andrew Lunn <andrew@lunn.ch>
To: Danielle Ratson <danieller@nvidia.com>
Cc: Simon Horman <horms@kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"kuba@kernel.org" <kuba@kernel.org>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"yuehaibing@huawei.com" <yuehaibing@huawei.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Petr Machata <petrm@nvidia.com>
Subject: Re: [PATCH net-next v2 2/2] net: ethtool: Add support for writing firmware blocks using EPL payload
Date: Wed, 11 Sep 2024 19:38:18 +0200 [thread overview]
Message-ID: <76d49fe4-e2b4-43c4-83f9-07796f47ae1d@lunn.ch> (raw)
In-Reply-To: <DM6PR12MB4516864A308D5BDFF0021129D89B2@DM6PR12MB4516.namprd12.prod.outlook.com>
> Hi Andrew,
>
> In both cases we transfer the same size of data, which corresponds to the size of the firmware image, to the module.
> Moreover, in both cases the same size of data is passing on the wire, which depends on the wire obligations.
>
> But, instead of running #n "0103h: Write FW Block LPL" commands (see section 9.7.4 in CMIS 5.2) with up to 128 bytes, we are running #n/16 "0104h: Write FW Block EPL" commands (see section 9.7.5 in CMIS 5.2) with up to 2048 bytes.
> That means that instead of processing #n commands and sending back to the core the status for each one, we do it for only #n/16.
O.K, thanks.
> The standard does not say anything about the I2C layer, but the
> speedup doesn’t lie in that.
What does your hardware do? Can it do 2048 byte I2C bus transfers? Or
is it getting chopped up into smaller chunks?
Thanks
Andrew
next prev parent reply other threads:[~2024-09-11 17:38 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-10 9:02 [PATCH net-next v2 0/2] ethtool: Add support for writing firmware Danielle Ratson
2024-09-10 9:02 ` [PATCH net-next v2 1/2] net: ethtool: Add new parameters and a function to support EPL Danielle Ratson
2024-09-11 7:32 ` Simon Horman
2024-09-10 9:02 ` [PATCH net-next v2 2/2] net: ethtool: Add support for writing firmware blocks using EPL payload Danielle Ratson
2024-09-11 7:32 ` Simon Horman
2024-09-11 12:26 ` Andrew Lunn
2024-09-11 15:41 ` Danielle Ratson
2024-09-11 17:38 ` Andrew Lunn [this message]
2024-09-13 7:29 ` Danielle Ratson
2024-09-15 17:17 ` [PATCH net-next v2 0/2] ethtool: Add support for writing firmware Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76d49fe4-e2b4-43c4-83f9-07796f47ae1d@lunn.ch \
--to=andrew@lunn.ch \
--cc=danieller@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=petrm@nvidia.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®