From: Yevgeny Kliteynik <kliteyn@nvidia.com>
To: Paolo Abeni <pabeni@redhat.com>,
netdev-bot+sashiko@kernel.org, tariqt@nvidia.com
Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@kernel.org,
kuba@kernel.org, netdev@vger.kernel.org, acassen@corp.free.fr,
valex@nvidia.com, erezsh@nvidia.com, gal@nvidia.com,
igozlan@nvidia.com, kees@kernel.org, kees+treewide@kernel.org,
leon@kernel.org, linux-kernel@vger.kernel.org,
linux-rdma@vger.kernel.org, mbloch@nvidia.com, moshe@nvidia.com,
prathameshdeshpande7@gmail.com, saeedm@nvidia.com,
william@theesfeld.net
Subject: Re: [PATCH net 3/3] net/mlx5: DR, Fix out-of-bounds write when sync to HW fails
Date: Mon, 16 Nov 2026 02:36:26 +0200 [thread overview]
Message-ID: <76da7f8a-7735-436c-9ee1-1198d7e98255@nvidia.com> (raw)
In-Reply-To: <9775ba1b-6bc0-4e2d-abaa-42d732f274ab@nvidia.com>
On 05-Nov-26 17:02, Yevgeny Kliteynik wrote:
> On 27-Oct-26 10:56, Paolo Abeni wrote:
>> On 10/23/26 12:52, netdev-bot+sashiko@kernel.org wrote:
>>> - [Medium] After a single SYNC_STEERING failure the pool latches into a
>>> permanent error state while allocation stays open, so device SW ICM…
>>
>> This one looks legit.
>>
>> /P
>>
>
> Agree.
>
> Actually, there should be two aspects to this fix.
> First part is as you commented - stop serving new chunks once the pool
> is in error state. Second part is allow for some transient sync failures.
>
> I'll issue v2 that handles both: a failed sync no longer disables the pool
> right away. hot_chunks_arr has spare room, the hot chunks stay queued, and the
> following frees keep retrying the sync. Only if the sync keeps failing until
> the spare room is used up does the pool go into an error state.
After some more digging, there is no point in complicating this fix.
I don't expect to see "transient" sync failures, so increasing memory
footprint just to prepare for sync failures is not a good tradeoff.
The v2 will contain just the suggested fix - once the poll is in error
state, the chunks will not be allocated/freed.
> -- YK
next prev parent reply other threads:[~2026-11-16 0:36 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 7:49 [PATCH net 0/3] net/mlx5: Fix HWS and DR steering memory safety bugs Tariq Toukan
2026-10-21 7:49 ` [PATCH net 1/3] net/mlx5: HWS, Handle NULL in vport destination action creation Tariq Toukan
2026-10-21 7:49 ` [PATCH net 2/3] net/mlx5: HWS, Fix heap buffer overflow in insert header action Tariq Toukan
2026-10-23 10:52 ` netdev-bot+sashiko
2026-10-21 7:49 ` [PATCH net 3/3] net/mlx5: DR, Fix out-of-bounds write when sync to HW fails Tariq Toukan
2026-10-23 10:52 ` netdev-bot+sashiko
2026-10-27 8:56 ` Paolo Abeni
2026-11-05 15:02 ` Yevgeny Kliteynik
2026-11-16 0:36 ` Yevgeny Kliteynik [this message]
2026-10-21 7:53 ` [PATCH net 0/3] net/mlx5: Fix HWS and DR steering memory safety bugs netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76da7f8a-7735-436c-9ee1-1198d7e98255@nvidia.com \
--to=kliteyn@nvidia.com \
--cc=acassen@corp.free.fr \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@kernel.org \
--cc=erezsh@nvidia.com \
--cc=gal@nvidia.com \
--cc=igozlan@nvidia.com \
--cc=kees+treewide@kernel.org \
--cc=kees@kernel.org \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=mbloch@nvidia.com \
--cc=moshe@nvidia.com \
--cc=netdev-bot+sashiko@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=prathameshdeshpande7@gmail.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=valex@nvidia.com \
--cc=william@theesfeld.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®