From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0A8ADC7618F for ; Tue, 16 Jul 2019 18:02:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D7B2C206C2 for ; Tue, 16 Jul 2019 18:02:33 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=nvidia.com header.i=@nvidia.com header.b="I7GAV+Li" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388297AbfGPSCc (ORCPT ); Tue, 16 Jul 2019 14:02:32 -0400 Received: from hqemgate15.nvidia.com ([216.228.121.64]:12886 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728137AbfGPSCc (ORCPT ); Tue, 16 Jul 2019 14:02:32 -0400 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Tue, 16 Jul 2019 11:02:37 -0700 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Tue, 16 Jul 2019 11:02:31 -0700 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Tue, 16 Jul 2019 11:02:31 -0700 Received: from [10.110.48.28] (172.20.13.39) by HQMAIL107.nvidia.com (172.20.187.13) with Microsoft SMTP Server (TLS) id 15.0.1473.3; Tue, 16 Jul 2019 18:02:30 +0000 Subject: Re: [PATCH] staging: kpc2000: whitespace and line length cleanup To: Greg Kroah-Hartman , CC: Dan Carpenter , , Vandana BN , Geordan Neukum , Bharath Vedartham , LKML , =?UTF-8?Q?Simon_Sandstr=c3=b6m?= References: <20190715212123.432-1-jhubbard@nvidia.com> <20190715212123.432-2-jhubbard@nvidia.com> <20190716083653.GB26457@kroah.com> X-Nvconfidentiality: public From: John Hubbard Message-ID: <76dbf8b5-6819-46d6-3e88-6efd3e65c10f@nvidia.com> Date: Tue, 16 Jul 2019 11:02:30 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <20190716083653.GB26457@kroah.com> X-Originating-IP: [172.20.13.39] X-ClientProxiedBy: HQMAIL106.nvidia.com (172.18.146.12) To HQMAIL107.nvidia.com (172.20.187.13) Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1563300157; bh=5fT2Sa0tylwiO7vAH/6/Aymz36jmgXXUwd3MqBCptko=; h=X-PGP-Universal:Subject:To:CC:References:X-Nvconfidentiality:From: Message-ID:Date:User-Agent:MIME-Version:In-Reply-To: X-Originating-IP:X-ClientProxiedBy:Content-Type:Content-Language: Content-Transfer-Encoding; b=I7GAV+LixPo0fAlyKVKc68DeJz8F8xuarg+JJYGejm6DEBJUGFQ1gz7cv+HNyfMlW MwPeoLK74ZW6kKLHrdAmmiBn1H++2nwSrJX9cJz5mGQWW7e0Qyhy3ttDRCwYYSi0SA qS7vlZJN0+ebY7E40ExOdDZP1v+MDlPALhjntfXH7UILezDbzeHvhWGvZFWX6aolht ri5QM8xDV0xujSWuApj7Sz/abbMCORSM0R0Ern8zGGqN+YpexQZwQEbPHj3asJSkNR r3PljX2ATEArr4keLaz9K/mTTMF894eJjFLVQsB6aK2YNvT1UJcVnBBERV45JqT7u1 t+WY1+CWPa+Qw== Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 7/16/19 1:36 AM, Greg Kroah-Hartman wrote: > On Mon, Jul 15, 2019 at 02:21:23PM -0700, john.hubbard@gmail.com wrote: >> From: John Hubbard ... >> drivers/staging/kpc2000/kpc2000_i2c.c | 189 +++++++++++------ >> drivers/staging/kpc2000/kpc2000_spi.c | 116 +++++----- >> drivers/staging/kpc2000/kpc_dma/dma.c | 109 ++++++---- >> drivers/staging/kpc2000/kpc_dma/fileops.c | 199 +++++++++++------- >> .../staging/kpc2000/kpc_dma/kpc_dma_driver.c | 113 +++++----- >> .../staging/kpc2000/kpc_dma/kpc_dma_driver.h | 156 +++++++------- >> 6 files changed, 509 insertions(+), 373 deletions(-) > > THat's way too many different types of changes to do all at once, and > some of these are making the code look worse, not better. > > There's a reason we don't run lindent :) Yes, I am seeing that very clearly now. :) > > If you want to do one-type-of-fix-per-patch, I'll gladly take these, > otherwise, I recommend leaving this for those people learning how to do > development to do. > OK, I'm going to pretend that I'm not one of those people, despite recent hard evidence to the contrary here. haha. Anyway, this does present a nice set of things for new developers to get started on. So I'll leave it as is. thanks, -- John Hubbard NVIDIA