From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753414AbdECO0W (ORCPT ); Wed, 3 May 2017 10:26:22 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:54383 "EHLO mail-out.m-online.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752772AbdECO0Q (ORCPT ); Wed, 3 May 2017 10:26:16 -0400 X-Auth-Info: 8lDnGdueMC8lZCW8leVVFtR1aYjDx+13THOD8ebInS8= Subject: Re: [PATCH] ARM: dts: imx6sx-sdb: Remove cpufreq OPP override To: Shawn Guo References: <89cc7192100bdc9ce546bf6000446e629457ebc1.1493138693.git.leonard.crestez@nxp.com> <1493141004.3557.8.camel@nxp.com> <20170503135715.GG18578@dragon> Cc: Leonard Crestez , Fabio Estevam , Sascha Hauer , Peter Chen , Anson Huang , "linux-pm@vger.kernel.org" , Viresh Kumar , "Rafael J. Wysocki" , linux-kernel , Fabio Estevam , "linux-arm-kernel@lists.infradead.org" , Christoph Fritz From: Marek Vasut Message-ID: <76e22a7e-590f-00ee-04f8-87604303eaad@denx.de> Date: Wed, 3 May 2017 16:26:05 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170503135715.GG18578@dragon> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/03/2017 03:57 PM, Shawn Guo wrote: > On Tue, Apr 25, 2017 at 07:28:06PM +0200, Marek Vasut wrote: >> On 04/25/2017 07:23 PM, Leonard Crestez wrote: >>> Anyway, that version also sets the supply for reg_arm and reg_soc. It >>> is not necessary for fixing the crash I'm seeing but is good because it >>> will result in the minimum voltage on VDD_ARM_SOC_IN rather than a fix >>> 1375mv. I tested Marek's patch and it works fine on my rev B board >>> (which otherwise fails to boot upstream). >> >> Oh that's nice , thanks ! I don't have SDB and I hacked it up after a >> brief discussion with Fabio without even compile-testing it, thus RFC. >> Glad to hear it works and thanks for testing it ! Can you add a formal >> Tested-by please ? > > Hi Marek, Hi Shawn, > Thanks for your patch. But I prefer Leonard's version because: 1) it > has a better commit log; 2) it sticks to one-patch-does-one-thing > policy. Well I'd prefer this patch because 1) It has T-B 2) It actually fixes a problem with the voltage rails such that the DVFS works without leaving the system in unstable or dead state. You do need the second part of my patch if you drop the OPP hackery, without it the power framework cannot correctly configure the core voltages, so the patch from Leonard makes things worse. > But I'm going to wait for a while to get Peter's comment discussed, > before I actually apply Leonard's patch. > > Shawn > -- Best regards, Marek Vasut