From: Florian Fainelli <f.fainelli@gmail.com>
To: Oleksij Rempel <o.rempel@pengutronix.de>,
Woojung Huh <woojung.huh@microchip.com>,
UNGLinuxDriver@microchip.com, Andrew Lunn <andrew@lunn.ch>,
Vivien Didelot <vivien.didelot@gmail.com>,
Vladimir Oltean <olteanv@gmail.com>,
"David S. Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>
Cc: Michael Grzeschik <m.grzeschik@pengutronix.de>,
kernel@pengutronix.de, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org,
Russell King <linux@armlinux.org.uk>
Subject: Re: [PATCH net-next v7 3/9] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct
Date: Mon, 26 Apr 2021 11:32:10 -0700 [thread overview]
Message-ID: <76e38640-32d1-38a9-6c8f-64769f1ceb6b@gmail.com> (raw)
In-Reply-To: <20210426131911.25976-4-o.rempel@pengutronix.de>
On 4/26/21 6:19 AM, Oleksij Rempel wrote:
> From: Michael Grzeschik <m.grzeschik@pengutronix.de>
>
> In order to get this driver used with other switches the functions need
> to use different offsets and register shifts. This patch changes the
> direct use of the register defines to register description structures,
> which can be set depending on the chips register layout.
>
> Signed-off-by: Michael Grzeschik <m.grzeschik@pengutronix.de>
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
The changes look fine, however ther are 32-bit build errors with this
specific patch:
https://patchwork.kernel.org/project/netdevbpf/patch/20210426131911.25976-4-o.rempel@pengutronix.de/
https://patchwork.hopto.org/static/nipa/473275/12224263/build_32bit/stderr
--
Florian
next prev parent reply other threads:[~2021-04-26 18:32 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 13:19 [PATCH net-next v7 0/9] microchip: add support for ksz88x3 driver family Oleksij Rempel
2021-04-26 13:19 ` [PATCH net-next v7 1/9] net: dsa: microchip: ksz8795: change drivers prefix to be generic Oleksij Rempel
2021-04-26 18:29 ` Florian Fainelli
2021-04-26 13:19 ` [PATCH net-next v7 2/9] net: dsa: microchip: ksz8795: move cpu_select_interface to extra function Oleksij Rempel
2021-04-26 18:30 ` Florian Fainelli
2021-04-26 13:19 ` [PATCH net-next v7 3/9] net: dsa: microchip: ksz8795: move register offsets and shifts to separate struct Oleksij Rempel
2021-04-26 18:32 ` Florian Fainelli [this message]
2021-04-26 13:19 ` [PATCH net-next v7 4/9] net: dsa: microchip: ksz8795: add support for ksz88xx chips Oleksij Rempel
2021-04-26 13:19 ` [PATCH net-next v7 5/9] net: dsa: microchip: Add Microchip KSZ8863 SPI based driver support Oleksij Rempel
2021-04-26 13:19 ` [PATCH net-next v7 6/9] dt-bindings: net: dsa: document additional Microchip KSZ8863/8873 switch Oleksij Rempel
2021-04-26 13:19 ` [PATCH net-next v7 7/9] net: phy: Add support for microchip SMI0 MDIO bus Oleksij Rempel
2021-04-26 18:23 ` Florian Fainelli
2021-04-26 13:19 ` [PATCH net-next v7 8/9] net: dsa: microchip: Add Microchip KSZ8863 SMI based driver support Oleksij Rempel
2021-04-26 13:19 ` [PATCH net-next v7 9/9] dt-bindings: net: mdio-gpio: add compatible for microchip,mdio-smi0 Oleksij Rempel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=76e38640-32d1-38a9-6c8f-64769f1ceb6b@gmail.com \
--to=f.fainelli@gmail.com \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=m.grzeschik@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=olteanv@gmail.com \
--cc=vivien.didelot@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®