From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout-p-101.mailbox.org (mout-p-101.mailbox.org [80.241.56.151]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A6C74383C9D for ; Wed, 4 Mar 2026 09:35:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=80.241.56.151 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616905; cv=none; b=j8FeCDqXT5ytITx+RCXjXfeVxdeplvGzqqCCHRaEKgpF0ZbPal4C+gN2P/GpDOUqzUgPY90bP2eg+YjHT/UjhoSpyTF2L4MTot7H7AOxpURoNxjBkVQhPTYqdlHPhl36bAGhW96cJSwOzAjhA6xNo991YnPJ0BmLDmwUPPVWvrk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1772616905; c=relaxed/simple; bh=4Oe9401DBCvKIiHFYmHlgLHvDPTLC3JVcl6jLL9T73Y=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=QcNH+3GxJ5Ahgs/soimkJvuSz2N7zEyTEtK3Y/heHauGILO3zA4E5UjfQVsoS27FU5NfhHgP9IEohbcoFRVeJBaN9y6iVfLIpZ0hjzhW/50tAcdVv+a181qIFDYYcKnJ+zdw8dSlgqWTTK6gSwdE7uUFeVMcQlABPLeCuEqDGK0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org; spf=pass smtp.mailfrom=mailbox.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b=MzUI3pks; arc=none smtp.client-ip=80.241.56.151 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=mailbox.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=mailbox.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="MzUI3pks" Received: from smtp1.mailbox.org (smtp1.mailbox.org [10.196.197.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4fQnZM6RTyz9thg; Wed, 4 Mar 2026 10:34:51 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1772616892; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=4Oe9401DBCvKIiHFYmHlgLHvDPTLC3JVcl6jLL9T73Y=; b=MzUI3pksF3PsvYUOVG83Ri+Jkq5sy2Ll+XWkXTyPsugd8O/9u19EAF2/hq4gW14GDofskP +bqBlG/SL+vn13uny7pkewlIneohrgutJFTUv8pNwwDjt01Pl8F6hViJD0GbT5X5vW7DyJ DI9TZ2Marz5rfUwnNflyHbqgHxD6GIDqTicNiAsV9iL+Nf6PgnSLaclB4F3CKzUiOReKLz QYVIg8Y/r2db4j6eKyF5c/I5NdFifhORY71dxtMT/q+58lZDY5IIBHTFfwB3UJMSKh6T+C Qs7SmWHkRRmvzS67uhwaF9mtjPxPPXes98c8ExnDfZMPt19A8PCx7vpdV/ICSQ== Message-ID: <76e69151fe679658d8816dcce1011cea20633252.camel@mailbox.org> Subject: Re: [PATCH v3] drm/scheduler: fix kernel-doc warning for drm_sched_job_done() From: Philipp Stanner Reply-To: phasta@kernel.org To: Yujie Liu , Christian =?ISO-8859-1?Q?K=F6nig?= , Alex Deucher , Philipp Stanner , amd-gfx@lists.freedesktop.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 04 Mar 2026 10:34:48 +0100 In-Reply-To: <20260227082452.1802922-1-yujie.liu@intel.com> References: <20260227082452.1802922-1-yujie.liu@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MBO-RS-ID: fb8c6319aac857a1eb0 X-MBO-RS-META: r7jswgrmditj5fjfw6ez3hixr65d8cz8 On Fri, 2026-02-27 at 16:24 +0800, Yujie Liu wrote: > Warning: drivers/gpu/drm/scheduler/sched_main.c:367 function parameter 'r= esult' not described in 'drm_sched_job_done' >=20 > Fixes: 539f9ee4b52a ("drm/scheduler: properly forward fence errors") > Signed-off-by: Yujie Liu Pushed to drm-misc-fixes. Thank you P. PS: for the future, scripts/get_maintainer provides a list of all recipents a patch should go to (two maintainers were missing). And a sentence or two in commit messages to describe what is being done are desirable. I added them for now, so no big deal. Just as a tip for the future :] > --- > Changes in v2: > - Split from the original patch set > =C2=A0 https://lore.kernel.org/all/20260226030038.1182961-1-yujie.liu@int= el.com/ > - Rebase onto latest drm-tip >=20 > Changes in v3: > - Change "errno" to uppercase "ERRNO" (suggested by Philipp) >=20 > =C2=A0drivers/gpu/drm/scheduler/sched_main.c | 1 + > =C2=A01 file changed, 1 insertion(+) >=20 > diff --git a/drivers/gpu/drm/scheduler/sched_main.c b/drivers/gpu/drm/sch= eduler/sched_main.c > index e6ee35406165..2d5cb21a05b6 100644 > --- a/drivers/gpu/drm/scheduler/sched_main.c > +++ b/drivers/gpu/drm/scheduler/sched_main.c > @@ -361,6 +361,7 @@ static void drm_sched_run_free_queue(struct drm_gpu_s= cheduler *sched) > =C2=A0/** > =C2=A0 * drm_sched_job_done - complete a job > =C2=A0 * @s_job: pointer to the job which is done > + * @result: 0 on success, -ERRNO on error > =C2=A0 * > =C2=A0 * Finish the job's fence and resubmit the work items. > =C2=A0 */