From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2CA373932E7 for ; Sat, 16 May 2026 23:09:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778972976; cv=none; b=DhOG2qh0yjS7lNBFi222qtKssmAd9iWhgnZrln+Xe+qa6kKGl4QOOlDbAPjWzp5b50Snwom38h65Jm7ojoLJnJfVQYHp78ZfFx+90VP+gyMqJOZl9tf6zsBiZCakSEHlEYl2WivpdnIQf2q/nlExFbUPly6pQ0tg3Kyf90+gHec= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778972976; c=relaxed/simple; bh=jM9P4tLfIF8MeGuI1VXJ2SJvpBLazhgAXkZYS1qSi8c=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=eBb6ZxtdHZJi10eHxr6AlrXedE39Q0RzYbXkH8eotsyVRSLHedGa/kTB6LFNIWrkobM5UhHjRaJPaD7EjQqqcHtYlCFB5YXpqvhASWRs2ars+TAYtzpWOuB06pCkTwLbXgzdZ8DIQ4ohngKnUvNtXIKwTa8ngwu+q3PIcSoqBAU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ib4Sy1l3; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ib4Sy1l3" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-837b39eb078so738157b3a.2 for ; Sat, 16 May 2026 16:09:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778972974; x=1779577774; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to; bh=cBfXIYldpHcgRD4I6rHdSNL+xKkkUEyUH1UQFq6ffjw=; b=ib4Sy1l3y56lF59UbtcoepMWSFCgwGd5FprrZ0DwixOW2ZqT5Ie4QUAerChYZ/+OSI AB1ATs7kweM/v0JrUExCRvIdEFMO0FaEiwo8N2l70l+3lqAy16vjhj/RpKcTmh3f65jy DZs7YPniMnC6L9wS7MOPIzHc8mdZyYUvtTIBWGd0odtpjxRoxziNPwydctHfYhPyDA8k siDJMZD43eE8DK3P7CysN5/ogIAf6iH0ZQEXURAAXbFWfpz6lMLR/vwk9qC97HeUJrIT V9IIBpqKoGdiBCzv23ppwsjkDLDsoN/p1mfSrPBS1OhwU7QKnX3XF7NrM3RSKUEiYRk1 msJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778972974; x=1779577774; h=content-transfer-encoding:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=cBfXIYldpHcgRD4I6rHdSNL+xKkkUEyUH1UQFq6ffjw=; b=blC1qYULPHsSg6ix2Zh6iASi0QppGyuj88tuCFTibB30qNByhY39s0wX0zSk8Cj2h+ uaOrpPq7cpqLR3Cji5cK1aQVEXY7Cnqn6ZpSo3a67BqXlYG+Xma7LwlwvVna1gWkQ00P gm7+rxKR2ss3k/Zsex1mseybQ5KwINXtKw4Q7Qw45e2fbgKhxSRjN4wYQDhbpvT+heDP aUfigeo4EMLeIzp2G178xIzKL5Ye75+by7PabA/lwftNOIFdr4TItaAjLGbtGFYDrirk 9akt+dRjRClO5/j4BjjVcECUn6BD7YCfQ0bnI5Ou7sihmnSuZHtVAFhkFV/NRIhajTmh tKcg== X-Forwarded-Encrypted: i=1; AFNElJ/kZoSnkR/PL3wj/dkruRp/u1rYxkFi4M/yiQlK6Homo0RpwF9oyYgDZmyDdY4TYAHFVsbZwM7UzfB0P3o=@vger.kernel.org X-Gm-Message-State: AOJu0YxVKXndvujxftPq6k63ISmRMdeVoJZrErzAAZuKfA7c66NKFol+ T7NCbse1ncV5d1nrwE34QfrwzmfObO16UPaYXHVyacXpShtkiBc5TuWtThimba89 X-Gm-Gg: Acq92OHq7bxJrImHKWxWupHwnNYdm46Rk/t5+FQds71l8obOwlzsa0t+JcRpxFd6MoU QGnDtBix8Wuq0EB1c2zmQkHPRiTncINlX3KzVBtpVTFJHg0IbTxOTkwNeavh3ZIUa3YfkXJGeG5 dGH1xNRKrD2ti8yoP4SrfD3e9B5TAEuJKxzA6dumq7XWnbXUTsDejX0RMrV5YbamTpWwloZS/3Y LQH6OESZ1QeWCruq89u7OwZZkXZoPmd+9Mcoe0LRukcojzbOuTHcUvF7VCr5Veig4Wk8BCT83oE Kk/pcAK5/6RiB5/bIYyv/G+B9IJ5yWB5DkkKKHL5XNj3dgeQmES8f07sgyNsnnIkW0ulJTkjhXi Ks8Ll3ZeHLXJ87nnKbEQQUT/kL90kqpzzI0Zq5RdnJKy2zPduZXyfQ/IgleMK423GRWQZqwvrGa NJu0pU/raHzahiOlmEd6jIYRzAOuA/4RDA/xBeLyNJjrDJxPodT05uyJAnCVyvS/ePvCuKBeAV X-Received: by 2002:a05:6a00:390f:b0:838:af72:fb2f with SMTP id d2e1a72fcca58-83f33aec2a5mr10161094b3a.6.1778972974432; Sat, 16 May 2026 16:09:34 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-83f2875f0fbsm8978388b3a.57.2026.05.16.16.09.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 16 May 2026 16:09:33 -0700 (PDT) Sender: Guenter Roeck Message-ID: <76f0d9d4-b7c1-4aa4-87ab-6de26f200e4c@roeck-us.net> Date: Sat, 16 May 2026 16:09:31 -0700 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/2] soc: bcm2835: raspberrypi-firmware: Add voltage domain IDs To: Shubham Chakraborty , Florian Fainelli , Jonathan Corbet Cc: Shuah Khan , Broadcom internal kernel review list , Ray Jui , Scott Branden , linux-hwmon@vger.kernel.org, linux-doc@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20260516164407.25255-1-chakrabortyshubham66@gmail.com> <20260516191555.17978-1-chakrabortyshubham66@gmail.com> <20260516191555.17978-2-chakrabortyshubham66@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20260516191555.17978-2-chakrabortyshubham66@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/16/26 12:15, Shubham Chakraborty wrote: > Add firmware voltage domain identifiers for the Raspberry Pi > mailbox property interface. > > These IDs are used by firmware clients to query voltage rails > through the RPI_FIRMWARE_GET_VOLTAGE property. > > Signed-off-by: Shubham Chakraborty > --- > include/soc/bcm2835/raspberrypi-firmware.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/soc/bcm2835/raspberrypi-firmware.h b/include/soc/bcm2835/raspberrypi-firmware.h > index e1f87fbfe554..fd2e051ce05b 100644 > --- a/include/soc/bcm2835/raspberrypi-firmware.h > +++ b/include/soc/bcm2835/raspberrypi-firmware.h > @@ -156,6 +156,14 @@ enum rpi_firmware_clk_id { > RPI_FIRMWARE_NUM_CLK_ID, > }; > > +enum rpi_firmware_volt_id { > + RPI_FIRMWARE_VOLT_ID_RESERVED = 0, Is that needed ? > + RPI_FIRMWARE_VOLT_ID_CORE = 1, > + RPI_FIRMWARE_VOLT_ID_SDRAM_C = 2, > + RPI_FIRMWARE_VOLT_ID_SDRAM_I = 3, > + RPI_FIRMWARE_VOLT_ID_SDRAM_P = 4, Regarding Sashiko's feedback: I don't know where it got the information from, but a web search suggests that it has a point; RPI_FIRMWARE_VOLT_ID_SDRAM_I and RPI_FIRMWARE_VOLT_ID_SDRAM_P appear to be swapped. If that is not the case, please provide evidence. Thanks, Guenter