mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Luca Weiss <luca@lucaweiss.eu>
To: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
	~postmarketos/upstreaming@lists.sr.ht,
	phone-devel@vger.kernel.org,
	Loic Poulain <loic.poulain@oss.qualcomm.com>,
	Robert Foss <rfoss@kernel.org>,
	Andi Shyti <andi.shyti@kernel.org>, Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Bartosz Golaszewski <brgl@bgdev.pl>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>
Cc: linux-arm-msm@vger.kernel.org, linux-i2c@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible
Date: Wed, 29 Oct 2025 21:41:57 +0100	[thread overview]
Message-ID: <76f108e7-2ec6-4edd-8640-a82fc99f7dbc@lucaweiss.eu> (raw)
In-Reply-To: <48a217db-b85a-411c-81f2-3106b60da86f@oss.qualcomm.com>

Hi Konrad,

On 29-10-2025 10:36, Konrad Dybcio wrote:
> On 10/28/25 5:40 PM, Luca Weiss wrote:
>> Add the msm8953 CCI device string compatible.
>>
>> Signed-off-by: Luca Weiss <luca@lucaweiss.eu>
>> ---
>>   Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml | 2 ++
>>   1 file changed, 2 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> index 9bc99d736343..ef8f5fe3a8e1 100644
>> --- a/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> +++ b/Documentation/devicetree/bindings/i2c/qcom,i2c-cci.yaml
>> @@ -15,6 +15,7 @@ properties:
>>       oneOf:
>>         - enum:
>>             - qcom,msm8226-cci
>> +          - qcom,msm8953-cci
>>             - qcom,msm8974-cci
>>             - qcom,msm8996-cci
>>   
>> @@ -146,6 +147,7 @@ allOf:
>>               - contains:
>>                   enum:
>>                     - qcom,msm8916-cci
>> +                  - qcom,msm8953-cci
>>   
>>               - const: qcom,msm8996-cci
> 
> Sorry for only bringing it up now - could you check whether
> all the clocks that you defined are actually necessary?
> 
> It may be that you can do without CAMSS_AHB_CLK and/or
> TOP_AHB_CLK

Removing either GCC_CAMSS_AHB_CLK or GCC_CAMSS_TOP_AHB_CLK from dts 
leads to an instant reboot during bootup - presumably during cci (or 
eeprom) probe.

Regards
Luca

> 
> Konrad


  parent reply	other threads:[~2025-10-29 20:42 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-28 16:40 [PATCH v2 0/7] Camera I2C (CCI) enablement on MSM8953 and Fairphone 3 Luca Weiss
2025-10-28 16:40 ` [PATCH v2 1/7] dt-bindings: i2c: qcom-cci: Document msm8953 compatible Luca Weiss
2025-10-29  6:34   ` Krzysztof Kozlowski
2025-10-29  9:36   ` Konrad Dybcio
2025-10-29 18:03     ` Andi Shyti
2025-10-29 20:41     ` Luca Weiss [this message]
2025-10-30  9:18       ` Konrad Dybcio
2025-10-30 12:26   ` Andi Shyti
2025-10-28 16:40 ` [PATCH v2 2/7] i2c: qcom-cci: Add " Luca Weiss
2025-11-04 18:25   ` Luca Weiss
2025-12-06  3:56   ` Luca Weiss
2025-12-08 11:34     ` Wolfram Sang
2025-12-06  4:12   ` Dmitry Baryshkov
2025-10-28 16:40 ` [PATCH v2 3/7] dt-bindings: eeprom: at24: Add compatible for Belling BL24S64 Luca Weiss
2025-10-29  6:32   ` Krzysztof Kozlowski
2025-10-28 16:40 ` [PATCH v2 4/7] arm64: dts: qcom: msm8953: Re-sort tlmm pinctrl states Luca Weiss
2025-10-28 16:40 ` [PATCH v2 5/7] arm64: dts: qcom: msm8953: Add CCI nodes Luca Weiss
2025-10-28 16:40 ` [PATCH v2 6/7] arm64: dts: qcom: sdm632-fairphone-fp3: Add camera fixed regulators Luca Weiss
2025-10-28 16:40 ` [PATCH v2 7/7] arm64: dts: qcom: sdm632-fairphone-fp3: Enable CCI and add EEPROM Luca Weiss
2025-10-29 10:41 ` (subset) [PATCH v2 0/7] Camera I2C (CCI) enablement on MSM8953 and Fairphone 3 Bartosz Golaszewski
2026-01-21  2:35 ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=76f108e7-2ec6-4edd-8640-a82fc99f7dbc@lucaweiss.eu \
    --to=luca@lucaweiss.eu \
    --cc=andersson@kernel.org \
    --cc=andi.shyti@kernel.org \
    --cc=brgl@bgdev.pl \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=konrad.dybcio@oss.qualcomm.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loic.poulain@oss.qualcomm.com \
    --cc=phone-devel@vger.kernel.org \
    --cc=rfoss@kernel.org \
    --cc=robh@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®