From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0a-0031df01.pphosted.com (mx0a-0031df01.pphosted.com [205.220.168.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 32F51313E23 for ; Mon, 22 Dec 2025 09:44:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.168.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766396695; cv=none; b=s8aqKUDJO3MsVa3OsdiC0qQs9nXw84YGf0C/arKaZXqjxOeHVhSbnwF+A/XVgC2lVUxaTbM+B3e7x8/HlI5lCF5fE3V84u1+EysbvpRS1L4VcfnuLersm8kEMjxYgRy3BPc62SXam/u9uD1F8GqmhQ8Nns9YpERDe6KN04rBdnc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1766396695; c=relaxed/simple; bh=gDeZuqsY/mX4JbrVYw75BFZuw+PuUzU/ico42hhVLSw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=Xh+CULA9R4GQPcnzcX5O1XQjPcR/3/gOzvkvMugbQRNQvQciISzgGALPQ+pGSJt3KVOnba1DMVeYwH/j6/qEGpPj0R7ybi5zPfDbquV55phAxCwV6J9HlCZkCTJjzagtF5o9A4FDKHSyUIVNNto/hcfNRnmQ7CUahQjPT8amsfE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=MqdMhbHw; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=VQR3m7Ke; arc=none smtp.client-ip=205.220.168.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="MqdMhbHw"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="VQR3m7Ke" Received: from pps.filterd (m0279865.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 5BM8DjQ93877629 for ; Mon, 22 Dec 2025 09:44:53 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= B+AccpGqqHKllmisBF66RiETa2U03BGY3xkaEIHS4m4=; b=MqdMhbHwNJ9aXyzx UbdszCFY4nclcAoKxJYjiZ/lPp5u21/7AkhlaxK5Uk5Tc7g9MdQLJ35agie5CgAm t5HJAFoyjZ3QeW7TjvweZ3L/poeIu0q8CROuRcEJ1GSJryxOYoZOaN4Hi6g7sgZi b1U4XPkooX2fM6BWk5aeiZhsZuVeIUnWOZdViSQBvtoXU8hRaN20xAQTQLto/u4N 3A0N8CGU/twObug4ijdeWOj/oEgB44DMBG+fDntc9oPOpVrv3OJinA/dCfPkoJVk LypJLoQNSjDjZpMoVdCUk3os6otcZkygbA3bF5CA/XjzeX1oG2EIASFXN1tg/rfF ZW5X5w== Received: from mail-qv1-f71.google.com (mail-qv1-f71.google.com [209.85.219.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4b5mrtchve-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Mon, 22 Dec 2025 09:44:53 +0000 (GMT) Received: by mail-qv1-f71.google.com with SMTP id 6a1803df08f44-8887c61412bso13481896d6.1 for ; Mon, 22 Dec 2025 01:44:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1766396692; x=1767001492; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=B+AccpGqqHKllmisBF66RiETa2U03BGY3xkaEIHS4m4=; b=VQR3m7KeROPlsi/DaJg3Yu8xIaLKoGHlB1vHvzgP9cFUKBxxZ676vrcF8t1bqzrs3a VSKM70N0dfN7Ov3Twv+6+loGm1tz6qK+LNTDhQbZFfTMY2M5+0G2G1sMNtZ85EFA59vo mjve8GsGYpFINb8b9BeqZuxe2CTcMbFBwNjTlxBaiPmFVsiwv+Ht5oP6vaDNDQdyWliF fLgNrTtvmV12pWp4jU8k12nltUILP9DwuyWkFP2bFkZxjGHeexYeyJdqHDXqSs36dQUY zObQ8yeDTxBqHJDCiEVuXIsvSglkJpYu0ES7hydg7sxP2+w2GB3gv7iPxkHGp2cdy8Nc ZBCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1766396692; x=1767001492; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=B+AccpGqqHKllmisBF66RiETa2U03BGY3xkaEIHS4m4=; b=KS3mXN5WsaiXGkvl1LvRNWx5Ejk+NsEltyBUigUsW//Ch40CCJe+WZy/+MNlIwLFFH ZvLKgwfIlml/0dxZNSqBOWG53ZNrSf868EyLuYol8orjHiZew/3RANj+8yJCjc+hD1/x D/CbBgfmCEMtsgCCGk34MlrI+02fIe/XnFCQgNMGgLPWar1hqdD+leFKK6dgHV4NB7nC yQS5XLCLRcoMEA2R+FO8GcgfiBxVWK35V9xKRPoUHHeKsqLkHBQmDHyLxE3FFgurPsIx gC9itlghByBzs2AL8SDV6m3dBhGqcA84eSdRKHijLS6bVKUrQH3MiaWtxjRBTfDPD7Uu vD9g== X-Forwarded-Encrypted: i=1; AJvYcCUo8yL7aiQizqs9peGU+7tvvQA+InKEyoYFh1UI+BiHWszXFH70kKR4S7FFdYC8rfnk+bTDlWIL3isseQ4=@vger.kernel.org X-Gm-Message-State: AOJu0YxCZCC+cC5Z9aFw/8cKA9II7r/8QIWKs/awiesPMcxuhJf0s+is FP7gXVkfhF5Eisj/R3vD0Z3T0F+VXPImTSftqwPcaapopyDVsEBepKBQuNROEcZ5OBSH92WRdep hqWWkpLY8jWXiqINfJ7LQfQ47OOa7I21Q/WR5kUnh9tG2JAl1HQDnCCTe9Yp5bHJSPvhI7J4IpE c= X-Gm-Gg: AY/fxX68MGAU1LVCOeAUqiTGlG7MYmmHRW9B1o0ZzvyCqL9NUFZRHcoe6NyuQSeCA7C w0BQUGnqJbaiQdaf4MCtE6DLmkLM8SL2cJYrfgBV5Lekrn9iCf4iPep7wa+L2Zth3Hb0v7ApaSX DmlgULLz4Caitocy3RTuvuZ7in40MzymcQd1mKVZzS8lE99Cq0THcFXTfBzFAlTlis0qeM8Bv9o 684GVbt47OObQuK9WOi+WTQjEpbT28JcGuA1HDbvdoQrbyJK9779UX42drTfNP3/Q+DIBOx9HMH D26EJ+ocBW8aZYNpUlHUQ6p7xUeKMNH+7NiApEh0q1cEItAm5JjR03L0pFO9GWnJoyy4QgYs1SF jDONHpNrSmtUEGDBhU4zgxNdUQkXUjt/PPel+V4HOX4xqma28nMA17QNequE3nyRI8w== X-Received: by 2002:a05:622a:11d4:b0:4f3:616c:dbed with SMTP id d75a77b69052e-4f4abbc85d9mr119886641cf.0.1766396692398; Mon, 22 Dec 2025 01:44:52 -0800 (PST) X-Google-Smtp-Source: AGHT+IGciiC9QJQfTbMMl50jGBWxbytT1LIvE/yMa+ImnNP8FDTauhEpA+iM44pnGXH17N1WmOVHMg== X-Received: by 2002:a05:622a:11d4:b0:4f3:616c:dbed with SMTP id d75a77b69052e-4f4abbc85d9mr119886491cf.0.1766396691967; Mon, 22 Dec 2025 01:44:51 -0800 (PST) Received: from [192.168.119.72] (078088045245.garwolin.vectranet.pl. [78.88.45.245]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b8037f512e3sm1033516266b.67.2025.12.22.01.44.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 22 Dec 2025 01:44:51 -0800 (PST) Message-ID: <76fcf840-e0ce-4647-bff7-4d2f6ac09777@oss.qualcomm.com> Date: Mon, 22 Dec 2025 10:44:49 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] arm64: dts: qcom: monaco: add QCrypto node To: Abhinaba Rakshit , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20251222-enable-qualcomm-crypto-engine-for-monaco-v1-1-06741d6ea66a@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20251222-enable-qualcomm-crypto-engine-for-monaco-v1-1-06741d6ea66a@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-ORIG-GUID: Rwn3EmBADZg2oNxXBDEZ9dH7q0ZHNaK2 X-Proofpoint-GUID: Rwn3EmBADZg2oNxXBDEZ9dH7q0ZHNaK2 X-Authority-Analysis: v=2.4 cv=CeEFJbrl c=1 sm=1 tr=0 ts=69491315 cx=c_pps a=UgVkIMxJMSkC9lv97toC5g==:117 a=FpWmc02/iXfjRdCD7H54yg==:17 a=IkcTkHD0fZMA:10 a=wP3pNCr1ah4A:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=EUspDBNiAAAA:8 a=_OpZ_5cEmvcoVn8VV1UA:9 a=QEXdDO2ut3YA:10 a=1HOtulTD9v-eNWfpl4qZ:22 X-Proofpoint-Spam-Details-Enc: AW1haW4tMjUxMjIyMDA4NyBTYWx0ZWRfX3dWnutJzdEcZ 5KOTO6ULkON1OUVAuMls5kFbh9mDUEwjPZeErRDrvQGFDlpLfcyVS/mxsJWYSjZkHugP9k8vvVw j68nzIRQBjQFRhMqzTGRE19jCfVf0vA8lCIvM1rtYZCxTzE6+ppoxVh9RJiMngZLQNwPs94UxdC 6KrERsIt+Wy8IqbfoTklQF4J8Nmr9MRnwKv0aWKtE6TghXCwS56RXqokQzY/leJhLH9A0ZITFdx DvSfK1TRbtTuRkvggdIcgLk/rkMjRI6w63ev/VQji+QAhTvpAozPxfXLCY4T7TZYzzokPHENFqa hROfg1zUT1nHX5XP7gt6rA2NdT2ApPzqXZN3RRySf0w/dzIXexGIQh9csSVptmHKeGJGdlzadxY gOpZrDv0O2yoPK1fynTyhcKaWmrAxIjyY7kGOf6vaLQaa+2dAJ2ODhfdjS13BVNxIDljomVU0Oa s82eSber+ALuHKr5EIg== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1121,Hydra:6.1.9,FMLib:17.12.100.49 definitions=2025-12-21_05,2025-12-19_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 impostorscore=0 lowpriorityscore=0 priorityscore=1501 phishscore=0 bulkscore=0 adultscore=0 spamscore=0 clxscore=1015 malwarescore=0 suspectscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2512120000 definitions=main-2512220087 On 12/22/25 8:30 AM, Abhinaba Rakshit wrote: > Add Qualcomm Crypto Engine device node for Monaco platform. > Bindings and Crypto DMA nodes for the same platform is already > present in the tree. > > QCE and Crypto DMA nodes patch was applied as part of the > commit a86d84409947 ("arm64: dts: qcom: qcs8300: add QCrypto nodes"), > however was reverted due to compatible string being miss-matched > against schema. > > Resubmitting the enablement of QCE device node for monaco platform > with compatible-string being aligned with qcom-qce schema. > > Signed-off-by: Abhinaba Rakshit > --- > arch/arm64/boot/dts/qcom/monaco.dtsi | 12 ++++++++++++ > 1 file changed, 12 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/monaco.dtsi b/arch/arm64/boot/dts/qcom/monaco.dtsi > index 816fa2af8a9a663b8ad176f93d2f18284a08c3d1..dd0b9ea27fe1cdfbf6aba07e98183871be7ee889 100644 > --- a/arch/arm64/boot/dts/qcom/monaco.dtsi > +++ b/arch/arm64/boot/dts/qcom/monaco.dtsi > @@ -2350,6 +2350,18 @@ ice: crypto@1d88000 { > clocks = <&gcc GCC_UFS_PHY_ICE_CORE_CLK>; > }; > > + crypto: crypto@1dfa000 { > + compatible = "qcom,qcs8300-qce", "qcom,sm8150-qce", "qcom,qce"; > + reg = <0x0 0x01dfa000 0x0 0x6000>; > + dmas = <&cryptobam 4>, <&cryptobam 5>; > + dma-names = "rx", "tx"; > + iommus = <&apps_smmu 0x480 0x00>, "0x00" makes no sense - "0x0" is the concise way to write it and "0x0000" would be pedantic with the width of the SMR mask field in mind. Please switch to the former Konrad