From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 9E9CF349AF0 for ; Wed, 19 Nov 2025 10:27:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763548063; cv=none; b=CABf9VUUb9rov5UsSsyVYskKuAnW4Ianct4abjf9qOJvra4Op24rPNg1z97h7qkYu6Ew9GqtugSrAF4nRCoJpoOpkfSoQtel1/MPTJ4UeOWw/FpH6B+ez1x+O3M8KX88rY5/IOKgP9iQ2Ef9KltO/T+saZ1rQ7kTAx+U0ntxdvQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1763548063; c=relaxed/simple; bh=ctOhoXzCrNGir2BqjHZ0QJ1bVseg/hdCu75raDnkXMY=; h=Content-Type:Mime-Version:Subject:From:In-Reply-To:Date:Cc: Message-Id:References:To; b=TXHz0njnH4Rtu54HTYvmOxs/u/Czdj7bsm4yEFdmqAoRPoNrdhkcspVL4cfX9mwXcCbMp/v00zlDDKqK3mll1A3gKl6uq9rRarecvJ1MXktusfYn8nC2OzkwDcEJ0W156u/YPjPRdk5huA/2iYSyJuNsFN4hfNcKG1USycF2lXk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AzcmxNeW; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AzcmxNeW" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-b72cbc24637so1112070066b.0 for ; Wed, 19 Nov 2025 02:27:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1763548060; x=1764152860; darn=vger.kernel.org; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=S+nM8TwEn3pAM+Wkbq5/nAzbOqWOMItS7/Y6FbwZo48=; b=AzcmxNeW6cMIWdkomRTGUwmHoqgeVsyx78C/B+/79yBxCes78M8ocdBdCSNvPlfwWv NAVteqx2AJk/SxU4jeCaHfw4JJ2nS4kxGj4QKKb+tB7OJDkGwXSDRBFlPT0DriMCUlcd J9bTERv289FlR6sPg5/kU39+9xShHUJgarDAwGGnL/VAFQFsc3oLfLfzY9Tr0BXx8DIa HFLLN7P6Tiv1+/XLNFYlQn7BaB04STUykoWolLzWr8BGCNNlse/HIcyzg0ks2ZFQSS1t 4j8U3n4Wwjrz5xZIhqAAoP9sz7ookfMSKcnOUOPNWVCY0W84ft/QqsowGMatOo8vxjVS JjEg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1763548060; x=1764152860; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=S+nM8TwEn3pAM+Wkbq5/nAzbOqWOMItS7/Y6FbwZo48=; b=qPf7Z2OQvp/CViPQK9n5+Nb13IYDOSnY+kx0SfrGSDwBw9mBftmBnUHPYTlOH73VrA hThF1qx7DirBU3m1GoUeg35pk1IQvvmiT5O9Lspv2JZwSYcOEGSpdNELxht3jjAvWRpo 2JNdIoutZIfYISKjwXxoLbZdT955/0t56O5F4cChi7Cv34webS3LQoqrOcKopFR73ivx 5h3JPSwtB7FJA6xGwdRCL86tsrK0YHYp/i0U/PODGImodPGS08SRdISbA1z6V5/KyXgP 51gVbYPi/FXdfYyKax3UuQdOIa5BVIaQ0z4eLbJzV4OVzlcLwycAwEDfKPgPcpBw65Tp 0WZA== X-Forwarded-Encrypted: i=1; AJvYcCWI0TQNg8+lLD/Eb60FjUP3YHg7teOwOrCQanpB/jk00wdP9EgtgX3ro+yyZD4aIiW6MOJIo6s19EB/CoQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yz03QlzyIh9iLV5IYbJQFZGkdEiV17GVysFAkfLvPd548Kb29ZJ OabEinxZdqb2h4me9RqhZErKFuKbJM9JiS2J/KBcBt07jqHEf/Cswg5B X-Gm-Gg: ASbGnctqu2V6PVMW0L2IcCcrIWgJkJHstezVvcJRVLV6y1Uk3FhV/uJwtFFNxDlAc19 YfDnOJAqkF+Yxcs47QXqYfcGh1HLBWF+q3rBKbHtMOkLMCmVj7ftf54M4KhXEERppGmHO6JXp3j ee6uArONzQ6pBpWkkb9DfGO/fD5jOKvZ/vVT/nGqDcjgNN3oZKPO2lxCxOiBHCBO+1tdXad7ojr y4vGXArnk5kSsNHagvECl71FAWdMGRxUM0wiMoE/O4GUNzG6/LFcsdbvsBjyrUwrse+TBYK7XCS r2xFmv454Re+yKejbPT5Mp/WskSCmtnPD6pgyJ1vxCz2WdYDkoaN2VM3Xdr9J44i/RpehLmyEwa IKBmAPCWkbqGa3jZzbzrChJB0kpoaczxO+d0uDt5gjQUlPqdeqatJWYIrTngUYoHLQkJ6QqlyOM XktnuNnfSljjgVYePBN3b2cZsK8ujD4Na3xhHUVCrgivWjEoo2sTEz4Joe14TwPXSIDRn4NAAD0 84= X-Google-Smtp-Source: AGHT+IFcsP/JWu7DWWlBu/BkWNRt0LIFSuLh7i2sy3UQ2gmA3tYApcSpm1bJdautTGMK/vyZo0UGug== X-Received: by 2002:a17:907:7e93:b0:b73:9368:ad44 with SMTP id a640c23a62f3a-b739368aff0mr1299146866b.16.1763548059649; Wed, 19 Nov 2025 02:27:39 -0800 (PST) Received: from smtpclient.apple (89-66-237-154.dynamic.play.pl. [89.66.237.154]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-b734fad4635sm1588133966b.26.2025.11.19.02.27.37 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 19 Nov 2025 02:27:39 -0800 (PST) Content-Type: text/plain; charset=utf-8 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Subject: Re: [PATCH 01/11] dt-bindings: display: meson-dw-hdmi: Add compatible for S4 HDMI controller From: Piotr Oniszczuk In-Reply-To: <8c3b9fa4-326e-4791-8154-07b268faa132@amlogic.com> Date: Wed, 19 Nov 2025 11:27:26 +0100 Cc: ao.xu@amlogic.com, Neil Armstrong , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , dri-devel@lists.freedesktop.org, linux-amlogic@lists.infradead.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Content-Transfer-Encoding: quoted-printable Message-Id: <7703796D-35D4-4AD2-B7F8-B75D2BE0F7AD@gmail.com> References: <20250110-drm-s4-v1-0-cbc2d5edaae8@amlogic.com> <20250110-drm-s4-v1-1-cbc2d5edaae8@amlogic.com> <3AC316FA-A633-4B6C-81BA-CCCA290E7F03@gmail.com> <8c3b9fa4-326e-4791-8154-07b268faa132@amlogic.com> To: Chuan Liu X-Mailer: Apple Mail (2.3826.700.81) Pls see inline > Wiadomo=C5=9B=C4=87 napisana przez Chuan Liu w = dniu 19 lis 2025, o godz. 03:57: >=20 > Hi Piotr, >=20 >=20 > On 11/18/2025 10:50 PM, Piotr Oniszczuk wrote: >> [You don't often get email from piotr.oniszczuk@gmail.com. Learn why = this is important at https://aka.ms/LearnAboutSenderIdentification ] >> [ EXTERNAL EMAIL ] >> Ao, >> Is there any chance to get this s4 drm hdmi series for current 6.18? >> (i tried backport this series to 6.18 but have some issues with = reparent vpu_0_sel to sysclk_b_sel) >=20 > Why do we need to reparent vpu_0_sel to sysclk_b_sel? is there any > background here? Well - it looks it is because bug.... Martin Blumenstingl had perfect eye and catch typo in patch = https://lore.kernel.org/all/20250110-drm-s4-v1-11-cbc2d5edaae8@amlogic.com= /: By replacing: assigned-clock-parents =3D <&clkc_periphs CLKID_FCLK_DIV3>, <0>, /* Do Nothing */ <&clkc_periphs CLKID_VPU_0>, <&clkc_periphs CLKID_FCLK_DIV4>, <0>, /* Do Nothing */ <&clkc_periphs CLKID_VAPB_0>; with: assigned-clock-parents =3D <&clkc_pll CLKID_FCLK_DIV3>, <0>, /* Do Nothing */ <&clkc_periphs CLKID_VPU_0>, <&clkc_pll CLKID_FCLK_DIV4>, <0>, /* Do Nothing */ <&clkc_periphs CLKID_VAPB_0>; dmesg is like this https://termbin.com/6020 So i'm getting hdmi working - but only when device boots _without_ = connected hdmi at boot (and connected later) If hdmi is connected at boot - boot hangs at: 0.341676] meson-dw-hdmi fe300000.hdmi-tx: Detected HDMI TX = controller v2.01a with HDCP (meson_dw_hdmi_phy) [ 0.342750] meson-dw-hdmi fe300000.hdmi-tx: registered DesignWare = HDMI I2C bus driver [ 0.343660] meson-drm ff000000.vpu: bound fe300000.hdmi-tx (ops = meson_dw_hdmi_ops) [ 0.344832] [drm] Initialized meson 1.0.0 for ff000000.vpu on minor 0 FYI: It is after applying = https://patchwork.kernel.org/project/linux-amlogic/cover/20250110-drm-s4-v= 1-0-cbc2d5edaae8@amlogic.com/ on mainline 6.18 (with some my adjustments = on this series required by changes in 6.18).=20 For VPU clk changes see = https://github.com/warpme/minimyth2/blob/master/script/kernel/linux-6.18/f= iles/0312-drm-meson-add-vpu-clk-setting-for-S4.patch=20 It is 6.18 adaptation of = https://patchwork.kernel.org/project/linux-amlogic/patch/20250110-drm-s4-v= 1-9-cbc2d5edaae8@amlogic.com/ As kernel hangs - i have limited caps to drill where root cause is.=20 =20 Maybe above hang is reason of my backports or missing any pre-req = required to get s4 drm working? Anyway - it will be good to test with updated to 6.18 series of Add DRM = support for Amlogic S4 (plus info about any pre-req required to get s4 = drm working) =20 =20 >=20 > The vpu_clk on S4 doesn't support sysclk_b_sel as one of its > selectable clock sources, so this reparent operation will definitely > fail. This has nothing to do with the kernel version. >=20 >>> Wiadomo=C5=9B=C4=87 napisana przez Ao Xu via B4 Relay = w dniu 10 sty 2025, o godz. = 06:39: >>>=20 >>> From: Ao Xu >>>=20 >>> Add devicetree document for S4 HDMI controller >>>=20 >>> Signed-off-by: Ao Xu >>> --- >>> Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml = | 1 + >>> 1 file changed, 1 insertion(+) >>>=20 >>> diff --git = a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml = b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml >>> index = 84d68b8cfccc86fd87a6a0fd2b70af12e51eb8a4..6e0a8369eee915fab55af24d450a6c40= e08def38 100644 >>> --- = a/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml >>> +++ = b/Documentation/devicetree/bindings/display/amlogic,meson-dw-hdmi.yaml >>> @@ -55,6 +55,7 @@ properties: >>> - const: amlogic,meson-gx-dw-hdmi >>> - enum: >>> - amlogic,meson-g12a-dw-hdmi # G12A (S905X2, S905Y2, = S905D2) >>> + - amlogic,meson-s4-dw-hdmi # S4 (S905Y4) >>>=20 >>> reg: >>> maxItems: 1 >>>=20 >>> -- >>> 2.43.0 >>>=20 >>>=20 >>>=20 >>> _______________________________________________ >>> linux-amlogic mailing list >>> linux-amlogic@lists.infradead.org >>> http://lists.infradead.org/mailman/listinfo/linux-amlogic >> _______________________________________________ >> linux-amlogic mailing list >> linux-amlogic@lists.infradead.org >> http://lists.infradead.org/mailman/listinfo/linux-amlogic >=20