From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Raymond Hackley <raymondhackley@protonmail.com>,
linux-kernel@vger.kernel.org
Cc: Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Alim Akhtar <alim.akhtar@samsung.com>,
devicetree@vger.kernel.org, linux-arm-msm@vger.kernel.org,
linux-samsung-soc@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] ARM: dts: exynos: fix input keys with Linux event codes for midas
Date: Tue, 17 Oct 2023 11:51:43 +0200 [thread overview]
Message-ID: <7708e8fd-7b47-46c1-a98f-b1521620d5d2@linaro.org> (raw)
In-Reply-To: <20231017091953.43478-1-raymondhackley@protonmail.com>
On 17/10/2023 11:21, Raymond Hackley wrote:
> Input event code 139 stands for KEY_MENU, instead of KEY_OK as key-ok
> inplies. Fix all event codes with linux-event-codes.h included for midas.
Please re-phrase the subject and commit msg. If you replace numbers to
defines, which are eventually numbers as well, it is not a fix. There is
nothing to fix here.
If you fix actual key code from incorrect one to correct one, this must
be clearly stated and a separate commit..
Best regards,
Krzysztof
prev parent reply other threads:[~2023-10-17 9:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 9:21 Raymond Hackley
2023-10-17 9:51 ` Krzysztof Kozlowski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7708e8fd-7b47-46c1-a98f-b1521620d5d2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=raymondhackley@protonmail.com \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®