From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f177.google.com (mail-pl1-f177.google.com [209.85.214.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F224333740 for ; Sat, 17 Jan 2026 09:00:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768640420; cv=none; b=UO8bajCFP8bGx3qO+YyyLttxbOCJ1x+QZU3XZh+Ujfcu182GM+NK43g6KsgwwZXvwaHidMzo21w0Nughg0kycJ/8x2NMlrDFgWqgWD9OIdHz53l9OFWXPIR38zkggWBnefUEsr8XH7e0mcL8t2UgX1GfqRMxCOBfPzfgNqDIX4I= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1768640420; c=relaxed/simple; bh=TB2Ih0n3LLuiMAAwqIXoCn0N3ebOUHk1Hm7aW2tabnM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=WM5TcT1MSi3AD1OXeE0TX5vJvY0DXBVzEjG2laTYHY9jgHlsvysnkSeK8FFu8ihEw7vAUKRZBnWJmH3wWurlB53f264TfGQaDBcGYuh8tb9TR9ZyC4yiF3R4JXp02X9L2dW6Wp8DtZdeo4dWBrrJ9SE/tfye0Iy6h01aLsRPnmY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Gy9Wvb7O; arc=none smtp.client-ip=209.85.214.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Gy9Wvb7O" Received: by mail-pl1-f177.google.com with SMTP id d9443c01a7336-2a0a95200e8so18542135ad.0 for ; Sat, 17 Jan 2026 01:00:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1768640419; x=1769245219; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=I7bhIVKOwHgULhwTtDYRyo43zC62kJHUX67IghOCSwY=; b=Gy9Wvb7OUaUQElL8mQ0pIxQonG/wEsTVhPHs+JzkXlXrhph9iymJNlzW92m42kJZCe 5ZZc7rkBtPkkplx+Mcc3Kea/5bQu5Y7FcR0wnCRL9ak9TIL7chvUanLxvjGAdGqgQzjr po3abEk4A4Yi6QViHPIr7HHf+FyiiAMZlAVR9vzePqFFsi++gn7LIr9GscDLLrsn0M3E qcvMtEm8br6P5uiSocoYlqhLNeC+k6rwAXBHWw5WQeHyim2EoPK3zxqS/vCWTwcLYRbG 10R6rED3q1qHxmyfSUzA2iuaeoCH0mG7/q5OfxtIvDcsNccj5G9JhAohNu4SHbKiRI/h 3ptA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1768640419; x=1769245219; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=I7bhIVKOwHgULhwTtDYRyo43zC62kJHUX67IghOCSwY=; b=qLuCZhH9amg7plSDDlxtRRVIwGItt0mfOS1qdVEElV9u4KUIbY6p4RipNvJ+vae5ZN ecgLqSj5ijw8wz2Rg+8sAng4f7l6igG1zcYVGgyIkg+e+0CuGbe6vnD6XMakXV1h1RbZ X7ZxzJD5CDqldPR+JJttYm5tB8A1Q5uEl/Ol96NiRDEZsnajaN/XjRT7/+2fwsTLtQKh gul+Ba/kSHRtgewWdcY+B3/MUQQbtYe85u9D04/HKKWqoMLtUAbcMOt6gbZehutHwlh4 SrnZvCU2ICzl8wBscQiEQ23xP/dFi/bpfBT+v9VyolmkFD5H+ENNM2iJbNNVTVH6eD+P H74g== X-Forwarded-Encrypted: i=1; AJvYcCUIYVKKYKOU9vGd/c12E0i2Wdj6+xkez0KkI+hOvDowop6INlX525L6qL06xuuFWLvfZko3Or/IL6GUR1s=@vger.kernel.org X-Gm-Message-State: AOJu0YxnspwENlZuiyeNdLuoEflnxoD7PeBvek9H5ctLj6K0MBzXT8R1 PH2G/q5rsZ9EIPz1xOXL2HU8CeI1bF2ib2niWtcSCCtlpO4NA7S5477A X-Gm-Gg: AY/fxX6U5PowlXfUpox3TVr4Rc7g7F92RcaeL62CeJmQN7BidBp5a9PoHEBe570ft9u ffrbKXQRfDPN0daK+FUiWG7C1S0WZSMSNJ5s9V/u1Z6EBZfyOqUqpj8z+mH8s6wQC2PgEYUQd0V cP0bAqfbwN63jL8HO5e7tTcKf+ybXEbgionLaYqHjsRJ9zd0jtayjHOVZjmM68DrmvhuhOX/81R sX0LLk8K4uBwFP6EWZ2/bGFzwkGOSr+HMjRERCBVhIhpA5lOAQogstj4+UFqyP4Iv5ens3cU4F1 36qglpDr3uu0NDnr3Y/V7LwnwDNGsni4hiSw+wqk6BHyzd3Vr/ls5yi5a6rFJGEXf8GTAUNKrHi ZhlXsXwkH5pJ0UACN87DScNp14A5Pky9Gp61kYUp/ambqG9PQP1kGsfgbrdxJNvIcipxLwgk+1b NVEPgWulaPSvSpR50+iclv64+dYt3nbGzn6i1w64AbiEHa55LTO+C9VTVN2Jw= X-Received: by 2002:a17:903:13d0:b0:2a0:a92c:2cb6 with SMTP id d9443c01a7336-2a7175a63b4mr59826725ad.36.1768640418708; Sat, 17 Jan 2026 01:00:18 -0800 (PST) Received: from ?IPV6:240e:390:a92:e941:6d59:490b:11d7:ea3? ([240e:390:a92:e941:6d59:490b:11d7:ea3]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2a7190aa312sm42249585ad.10.2026.01.17.01.00.15 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 17 Jan 2026 01:00:18 -0800 (PST) Message-ID: <770acb41-64be-4446-bcea-ad8b03c5608c@gmail.com> Date: Sat, 17 Jan 2026 17:00:13 +0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 5/8] ext4: propagate flags to ext4_convert_unwritten_extents_endio() To: Ojaswin Mujoo , linux-ext4@vger.kernel.org, Theodore Ts'o Cc: Ritesh Harjani , Zhang Yi , Jan Kara , libaokun1@huawei.com, linux-kernel@vger.kernel.org References: <91a23f1c21837277b1ba24db359fe928380aa979.1768402426.git.ojaswin@linux.ibm.com> Content-Language: en-US From: Zhang Yi In-Reply-To: <91a23f1c21837277b1ba24db359fe928380aa979.1768402426.git.ojaswin@linux.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 1/14/2026 10:57 PM, Ojaswin Mujoo wrote: > Currently, callers like ext4_convert_unwritten_extents() pass > EXT4_EX_NOCACHE flag to avoid caching extents however this is not > respected by ext4_convert_unwritten_extents_endio(). Hence, modify it to > accept flags from the caller and to pass the flags on to other extent > manipulation functions it calls. This makes sure the NOCACHE flag is > respected throughout the code path. > > Also, since the caller already passes METADATA_NOFAIL and CONVERT flags > we don't need to explicitly pass it anymore. > > Signed-off-by: Ojaswin Mujoo > Reviewed-by: Jan Kara It looks good to me. Reviewed-by: Zhang Yi > --- > fs/ext4/extents.c | 9 +++------ > 1 file changed, 3 insertions(+), 6 deletions(-) > > diff --git a/fs/ext4/extents.c b/fs/ext4/extents.c > index 3d45abfb13cd..54f45b40fe73 100644 > --- a/fs/ext4/extents.c > +++ b/fs/ext4/extents.c > @@ -3784,7 +3784,7 @@ static struct ext4_ext_path *ext4_split_convert_extents(handle_t *handle, > static struct ext4_ext_path * > ext4_convert_unwritten_extents_endio(handle_t *handle, struct inode *inode, > struct ext4_map_blocks *map, > - struct ext4_ext_path *path) > + struct ext4_ext_path *path, int flags) > { > struct ext4_extent *ex; > ext4_lblk_t ee_block; > @@ -3801,15 +3801,12 @@ ext4_convert_unwritten_extents_endio(handle_t *handle, struct inode *inode, > (unsigned long long)ee_block, ee_len); > > if (ee_block != map->m_lblk || ee_len > map->m_len) { > - int flags = EXT4_GET_BLOCKS_CONVERT | > - EXT4_GET_BLOCKS_METADATA_NOFAIL; > - > path = ext4_split_convert_extents(handle, inode, map, path, > flags, NULL); > if (IS_ERR(path)) > return path; > > - path = ext4_find_extent(inode, map->m_lblk, path, 0); > + path = ext4_find_extent(inode, map->m_lblk, path, flags); > if (IS_ERR(path)) > return path; > depth = ext_depth(inode); > @@ -3942,7 +3939,7 @@ ext4_ext_handle_unwritten_extents(handle_t *handle, struct inode *inode, > /* IO end_io complete, convert the filled extent to written */ > if (flags & EXT4_GET_BLOCKS_CONVERT) { > path = ext4_convert_unwritten_extents_endio(handle, inode, > - map, path); > + map, path, flags); > if (IS_ERR(path)) > return path; > ext4_update_inode_fsync_trans(handle, inode, 1);