From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 829032D7813 for ; Tue, 25 Nov 2025 10:37:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764067079; cv=none; b=R/f70vIdE5Ff4/LZRiyKbr/bqdbbRwGwWaGmPn6yFl6Yw7RszI2pGnlN99oBk+BY2ZIAB+uIAEErOv5b50a7qU94oelFBZTt4XxPrPrw+RS54o0eRYg4W0M9GHPpmScvaabJb1tnkj5PxkGKaRqYNTNUT7jdxYcMCEO88sKsMuc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1764067079; c=relaxed/simple; bh=3UxvyTKMhFPzKhkKyo9X8C90xMdybEY1oVBD2xExz4o=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=t1o+Zl8l+Od26MKNTqYJRuwqQwuhsVU8PteGfaYKe1MpRx9/IdKKSwd2/M10gTnu1jpmzTU14COTJz/W7+0lEAE/Id5cPq6JiZRFeVvhw3d694DNZVGCJ0+d1HktYP9H0ab6WBK8ONA6+FfL2rT6oAwGQvEiwCy4E+z10QuQYck= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=l2TPd8o5; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="l2TPd8o5" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-47798ded6fcso32297875e9.1 for ; Tue, 25 Nov 2025 02:37:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1764067076; x=1764671876; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:from:to:cc:subject:date:message-id :reply-to; bh=GYC61ScVsBbr1quVLA1nHxdsxXyryY1uNeoSQ6wfNao=; b=l2TPd8o54sQLuD5D+loNaR+p6GCTwFqDSjpujLjiPU9n571fSuiRcvqDvPhDdJnKu6 3GZ+rPlc6wBnBswk6A8AOzG12QnLcBhW/C91L/6NAHy6Lfh+Gp+wCurJxZ0jD99PSQUz UXRCubKFDteHI8ND+tBEIKCMNwTvJaCBS8FHq08fMeM4HK+qnlbDdZgVGvhLMBBTVhz9 Dl7LBJEBkrvXqlIr/vgDXKYZdA6uTmRl4A2Dp/x/yjFXstH/AOD9j21I+GFnKzZFviuT Rhlxa3U0YHmnBr8gSTAtSvoSJNTngWELrt35LKAYp28ot2qg/renWq+h/VpenRPTGLNM e/sQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1764067076; x=1764671876; h=content-transfer-encoding:in-reply-to:organization:autocrypt :content-language:from:references:cc:to:subject:reply-to:user-agent :mime-version:date:message-id:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=GYC61ScVsBbr1quVLA1nHxdsxXyryY1uNeoSQ6wfNao=; b=jfUi1o9j1PMnV+JpGxYGG2MZF+2h5D37B7ehjl9AjJyGy/+t8nQMC7v/TIp8z5/RX5 TxN1pfrECJz2Jo9afhEDA2CzpDIiQ8a4rdpdVkcR65baHQplJVPbgvlZhsYKx0bUd4I7 scQVaPlKM0us5ucNF+HwyFUrh0DOWDi8o9BqD8ccGnYjc1Sgxeksa3dQZ6vBdpfjGDyW 1oeq0jQGAm5IRfX2GXtFotc3BMUwmuGDNzTvunAWQfSwMVmDuvVVI8T8MsC6L4U4IB7N nBhxIOsE/P6DhsVgGSFYcQaN/GCaREuDoeaYBOFe/3RXIIhS9OVmoxeAcgT4v1fITqt6 KV/A== X-Forwarded-Encrypted: i=1; AJvYcCW1K7lreCA7sR+0Nn7Yz/D+pBVUxakM+of/6ogoQO4cy8BmSZ48vO/2vM3GPf162bXbrX8KW5woawhtbBQ=@vger.kernel.org X-Gm-Message-State: AOJu0Yzvr0Rj3ZV9l9UZt2Q7/DfgV7F5feohfPJeDS8rrI4VZjVhiABD mv+iAntfGdWY7XPxXyEx/XuYNtAUO1vi5fRoDCJuMCEB4tKynP+XOWb77ZjiyUpqB7I= X-Gm-Gg: ASbGncvTLKEliJRkc3zstMkilw+eVJmseHeLvHNs6COAOMiSVtLG5gGBHyiCVTEBqTa uktKVg4UqdFt550vcusVWStZLhVchKYBAw9LvliWClZTdTFnQxgWNmOJUGCs8PC8KMoGZkSPUbG sAfPBD6PrpUnVcHrrqwTKSgcHThiXfwDp4K81eqCYx2o+XlDh/4Q964o90b+AP7cWF9rBjqZ2Hz VFLlACnO8Cv/qzjov4sN11fuleDRpUDdJXr4n85z9KkNDlkRf+7OVChkig/ULuL8SzcdYNNAP3Y ANt7azn51T1bmY/oHok+KrAi6MkY4nVRJq8SL1BgH8KUvFrYKQh957pwRcdtWtpz/ndcZrXDTb9 nIMrTuZAmiX13GlEWZisE+KfatanrdjRJ7cFy8vX9YKpBtgrYBsTpOd5AP0AU4fEMGkpsS9FnRt RFzhJBzCq9fCwmCLESANEiqxlMrVAn2QK57R2eaHyq5g6MXYtUtmx93g2XsAEk09o= X-Google-Smtp-Source: AGHT+IGP1SPCHIHtShZFolTs83W/8RAo7k/ZmXFb88XoMpqjN2qSC4HAz5PXdGGYvwwWQcNq0TysUg== X-Received: by 2002:a05:600c:a08:b0:477:aed0:f401 with SMTP id 5b1f17b1804b1-477c11254damr148828405e9.23.1764067075716; Tue, 25 Nov 2025 02:37:55 -0800 (PST) Received: from ?IPV6:2a01:e0a:3d9:2080:dea1:baf7:4d0c:118e? ([2a01:e0a:3d9:2080:dea1:baf7:4d0c:118e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-479052d9445sm12406665e9.11.2025.11.25.02.37.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 25 Nov 2025 02:37:55 -0800 (PST) Message-ID: <7716b83f-409c-4fa8-8232-89d3d1be5dd6@linaro.org> Date: Tue, 25 Nov 2025 11:37:54 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Reply-To: Neil Armstrong Subject: Re: [PATCH v3 0/7] Add TUXEDO Elite 14 Gen1 (X1E78100) To: Georg Gottleuber , Krzysztof Kozlowski , Stephan Gerhold Cc: Georg Gottleuber , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Ettore Chimenti , Srinivas Kandagatla , stefan.schmidt@linaro.org, wse@tuxedocomputers.com, cs@tuxedo.de References: <20251121142623.251118-1-ggo@tuxedocomputers.com> <280982b8-ce86-45aa-812b-ef1bf6e57e3d@kernel.org> From: Neil Armstrong Content-Language: en-US, fr Autocrypt: addr=neil.armstrong@linaro.org; keydata= xsBNBE1ZBs8BCAD78xVLsXPwV/2qQx2FaO/7mhWL0Qodw8UcQJnkrWmgTFRobtTWxuRx8WWP GTjuhvbleoQ5Cxjr+v+1ARGCH46MxFP5DwauzPekwJUD5QKZlaw/bURTLmS2id5wWi3lqVH4 BVF2WzvGyyeV1o4RTCYDnZ9VLLylJ9bneEaIs/7cjCEbipGGFlfIML3sfqnIvMAxIMZrvcl9 qPV2k+KQ7q+aXavU5W+yLNn7QtXUB530Zlk/d2ETgzQ5FLYYnUDAaRl+8JUTjc0CNOTpCeik 80TZcE6f8M76Xa6yU8VcNko94Ck7iB4vj70q76P/J7kt98hklrr85/3NU3oti3nrIHmHABEB AAHNKk5laWwgQXJtc3Ryb25nIDxuZWlsLmFybXN0cm9uZ0BsaW5hcm8ub3JnPsLAkQQTAQoA OwIbIwULCQgHAwUVCgkICwUWAgMBAAIeAQIXgBYhBInsPQWERiF0UPIoSBaat7Gkz/iuBQJk Q5wSAhkBAAoJEBaat7Gkz/iuyhMIANiD94qDtUTJRfEW6GwXmtKWwl/mvqQtaTtZID2dos04 YqBbshiJbejgVJjy+HODcNUIKBB3PSLaln4ltdsV73SBcwUNdzebfKspAQunCM22Mn6FBIxQ GizsMLcP/0FX4en9NaKGfK6ZdKK6kN1GR9YffMJd2P08EO8mHowmSRe/ExAODhAs9W7XXExw UNCY4pVJyRPpEhv373vvff60bHxc1k/FF9WaPscMt7hlkbFLUs85kHtQAmr8pV5Hy9ezsSRa GzJmiVclkPc2BY592IGBXRDQ38urXeM4nfhhvqA50b/nAEXc6FzqgXqDkEIwR66/Gbp0t3+r yQzpKRyQif3OwE0ETVkGzwEIALyKDN/OGURaHBVzwjgYq+ZtifvekdrSNl8TIDH8g1xicBYp QTbPn6bbSZbdvfeQPNCcD4/EhXZuhQXMcoJsQQQnO4vwVULmPGgtGf8PVc7dxKOeta+qUh6+ SRh3vIcAUFHDT3f/Zdspz+e2E0hPV2hiSvICLk11qO6cyJE13zeNFoeY3ggrKY+IzbFomIZY 4yG6xI99NIPEVE9lNBXBKIlewIyVlkOaYvJWSV+p5gdJXOvScNN1epm5YHmf9aE2ZjnqZGoM Mtsyw18YoX9BqMFInxqYQQ3j/HpVgTSvmo5ea5qQDDUaCsaTf8UeDcwYOtgI8iL4oHcsGtUX oUk33HEAEQEAAcLAXwQYAQIACQUCTVkGzwIbDAAKCRAWmrexpM/4rrXiB/sGbkQ6itMrAIfn M7IbRuiSZS1unlySUVYu3SD6YBYnNi3G5EpbwfBNuT3H8//rVvtOFK4OD8cRYkxXRQmTvqa3 3eDIHu/zr1HMKErm+2SD6PO9umRef8V82o2oaCLvf4WeIssFjwB0b6a12opuRP7yo3E3gTCS KmbUuLv1CtxKQF+fUV1cVaTPMyT25Od+RC1K+iOR0F54oUJvJeq7fUzbn/KdlhA8XPGzwGRy 4zcsPWvwnXgfe5tk680fEKZVwOZKIEuJC3v+/yZpQzDvGYJvbyix0lHnrCzq43WefRHI5XTT QbM0WUIBIcGmq38+OgUsMYu4NzLu7uZFAcmp6h8g Organization: Linaro In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 11/24/25 15:09, Georg Gottleuber wrote: > Hello Krzysztof. > > Am 22.11.25 um 12:15 schrieb Krzysztof Kozlowski: >> On 22/11/2025 12:00, Stephan Gerhold wrote: >>> On Sat, Nov 22, 2025 at 11:16:25AM +0100, Krzysztof Kozlowski wrote: >>>> On 21/11/2025 15:26, Georg Gottleuber wrote: >>>>> [...] >>>>> Initial support for TUXEDO Elite 14 Gen1 laptop. It is based on Qualcomm >>>>> Snapdragon X Elite SoC (X1E78100). >>>>> >>>> [...] >>>> >>>>> Because the SoC is now outdated and some functions still do not work as >>>>> well as customers would expect from the TUXEDO brand, TUXEDO Elite 14 Gen1 >>>>> will not be offered for sale. We would still like to submit our device >>>>> tree to the mainline kernel and thus contribute to Linux support for a >>>>> compatible device sold by Medion (SPRCHRGD 14 S1 Elite). At least in >>>>> Germany, this device was sold in many large stores. (An official press >>>>> statement will follow on our website.) >>>> >>>> For me this is unmergeable, because we do not take stuff which no one >>>> uses (no one can even use), and I am sad I put effort in reviewing AFTER >>>> this was known to be cancelled. > > In fact, there are a couple of these TUXEDO devices, some of these are > already being used by people outside the company (by Linaro). There are > also considerations to give the engineering samples to > Linux/ARM-(kernel) enthusiasts. > >>> I don't think we have any requirement to have a large user base in order >>> to merge changes. There is already support for plenty of cancelled >>> products with only a few (if any) remaining users in mainline, e.g. >>> >>> - Snapdragon X Elite Dev Kit (x1e001de-devkit), shipped only to a >>> handful of users before cancelled >>> - All ChromeOS SC7280 devices (including DTB variants for several >>> revisions of pre-production samples), never shipped to anyone >>> >> >> I discuss here the timing primarily and I don't know the timing about them. >> >>> There are also plenty of internal reference devices that only a handful >>> of people have access to (MTP, HDK, CRD etc). What makes these any >> >> They are still "maintained" and "offered", even if only for handful >> (like 3000 EACH variant) people. That's the amount of board of each >> variant, e.g. MTP8750, and all of them run some sort of Linux, even if >> downstream. So sorry, but 3000 (or whatever number it is) is not handful. >> >>> different? Ettore has been actively testing and contributing to the port >>> for the TUXEDO laptop, so if he wants to continue that, I don't think >>> anything speaks against merging this device tree. >> >> I won't be maintaining it, so not my effort in that, but since you speak >> about that - maintenance is an effort, thus I decide not to spend it on >> cancelled products. >>> In any case, I don't think the time reviewing these changes is wasted: >> >> I am happy that you do not find my time wasted, but I disagree on that >> because knowing this is cancelled, I would probably not care and review >> products which are not cancelled at this time. > > Do you maintain your position despite the above circumstances? > >>> As Georg wrote, there is also the Medion SPRCHRGD 14 S1 Elite laptop >>> that uses basically the same hardware design. I'm sure there are (or >>> eventually will be) users of that device who would appreciate having a >>> fully-functional device tree ready to use. There is an open issue in one >>> of the Ubuntu repositories for example [1] to add automatic DTB >>> selection for it. >>> >>> In other words, even if we decide against adding support for the >>> "x1e80100-tuxedo-elite-14-gen1", the same changes renamed to >>> "x1e80100-medion-sprchrgd-14-s1" would still be valid and valuable. >> >> That's why you send such patches with RFC title and FIRST (literally >> first) explanation in cover letter WHY, so people can decide. >> >>> I wouldn't expect any other changes to be needed, although obviously >>> someone with access to the device should confirm that before submitting. >> >> You still cannot apply my review to that other board, so still wasted >> time because I would need to review again. > > I understand your frustration, but I'm still learning how to contribute > to the Linux kernel. However, we may be able to find a constructive > solution. Here at TUXEDO, we have the necessary Medion device and have > already adapted the device tree. > > Would you review a patch set for Medion SPRCHRGD 14 S1 Elite? I think it's worth re-spining this patchset for the Medion SPRCHRGD 14 S1 Elite with a comment in the DT mentioning the device tree is compatible with the defunct Tuxedo Elite 14 Gen 1, since the Medion is an actual product people can buy it's worth it. I applied to first 3 patches, so you can remove them from the next version. Neil > > (This device is still on sale and can be found in many large electronics > stores, at least in Germany.) > > Best regards, > Georg > >> >> Best regards, >> Krzysztof >